Linux-m68k Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] m68k: mcfmmu: remove stale part of comment about steal_context
@ 2020-06-18  8:17 Mike Rapoport
  2020-06-18 11:48 ` Greg Ungerer
  0 siblings, 1 reply; 4+ messages in thread
From: Mike Rapoport @ 2020-06-18  8:17 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Greg Ungerer, Mike Rapoport, linux-m68k, Mike Rapoport

From: Mike Rapoport <rppt@linux.ibm.com>

The comment about steal_context() came from powerpc and a part of it
addresses differences between powerpc variants that are not really
relevant to m68k.

Remove that part of the comment.

Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
Hi,

I've found this by pure chance while grepping for pgalloc.h
It's been there since 2011, but I don't think it's a stable material, so I
didn't cc them.

 arch/m68k/mm/mcfmmu.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/m68k/mm/mcfmmu.c b/arch/m68k/mm/mcfmmu.c
index 29f47923aa46..cb9f8675d81b 100644
--- a/arch/m68k/mm/mcfmmu.c
+++ b/arch/m68k/mm/mcfmmu.c
@@ -214,11 +214,6 @@ void __init cf_mmu_context_init(void)
 
 /*
  * Steal a context from a task that has one at the moment.
- * This is only used on 8xx and 4xx and we presently assume that
- * they don't do SMP.  If they do then thicfpgalloc.hs will have to check
- * whether the MM we steal is in use.
- * We also assume that this is only used on systems that don't
- * use an MMU hash table - this is true for 8xx and 4xx.
  * This isn't an LRU system, it just frees up each context in
  * turn (sort-of pseudo-random replacement :).  This would be the
  * place to implement an LRU scheme if anyone was motivated to do it.
-- 
2.25.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] m68k: mcfmmu: remove stale part of comment about steal_context
  2020-06-18  8:17 [PATCH] m68k: mcfmmu: remove stale part of comment about steal_context Mike Rapoport
@ 2020-06-18 11:48 ` Greg Ungerer
  2020-06-18 12:09   ` Mike Rapoport
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Ungerer @ 2020-06-18 11:48 UTC (permalink / raw)
  To: Mike Rapoport, Geert Uytterhoeven; +Cc: linux-m68k, Mike Rapoport

Hi Mike,

On 18/6/20 6:17 pm, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
> 
> The comment about steal_context() came from powerpc and a part of it
> addresses differences between powerpc variants that are not really
> relevant to m68k.
> 
> Remove that part of the comment.
> 
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>

Acked-by: Greg Ungerer <gerg@linux-m68k.org>

Do you want me to carry that in my m68k (m68knommu) tree for v5.9?

Regards
Greg


> ---
> Hi,
> 
> I've found this by pure chance while grepping for pgalloc.h
> It's been there since 2011, but I don't think it's a stable material, so I
> didn't cc them.
> 
>   arch/m68k/mm/mcfmmu.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/arch/m68k/mm/mcfmmu.c b/arch/m68k/mm/mcfmmu.c
> index 29f47923aa46..cb9f8675d81b 100644
> --- a/arch/m68k/mm/mcfmmu.c
> +++ b/arch/m68k/mm/mcfmmu.c
> @@ -214,11 +214,6 @@ void __init cf_mmu_context_init(void)
>   
>   /*
>    * Steal a context from a task that has one at the moment.
> - * This is only used on 8xx and 4xx and we presently assume that
> - * they don't do SMP.  If they do then thicfpgalloc.hs will have to check
> - * whether the MM we steal is in use.
> - * We also assume that this is only used on systems that don't
> - * use an MMU hash table - this is true for 8xx and 4xx.
>    * This isn't an LRU system, it just frees up each context in
>    * turn (sort-of pseudo-random replacement :).  This would be the
>    * place to implement an LRU scheme if anyone was motivated to do it.
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] m68k: mcfmmu: remove stale part of comment about steal_context
  2020-06-18 11:48 ` Greg Ungerer
@ 2020-06-18 12:09   ` Mike Rapoport
  2020-06-18 12:25     ` Greg Ungerer
  0 siblings, 1 reply; 4+ messages in thread
From: Mike Rapoport @ 2020-06-18 12:09 UTC (permalink / raw)
  To: Greg Ungerer; +Cc: Geert Uytterhoeven, linux-m68k, Mike Rapoport

Hi Greg,

On Thu, Jun 18, 2020 at 09:48:42PM +1000, Greg Ungerer wrote:
> Hi Mike,
> 
> On 18/6/20 6:17 pm, Mike Rapoport wrote:
> > From: Mike Rapoport <rppt@linux.ibm.com>
> > 
> > The comment about steal_context() came from powerpc and a part of it
> > addresses differences between powerpc variants that are not really
> > relevant to m68k.
> > 
> > Remove that part of the comment.
> > 
> > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> 
> Acked-by: Greg Ungerer <gerg@linux-m68k.org>
> 
> Do you want me to carry that in my m68k (m68knommu) tree for v5.9?

Yes, please :)

> Regards
> Greg
> 
> 
> > ---
> > Hi,
> > 
> > I've found this by pure chance while grepping for pgalloc.h
> > It's been there since 2011, but I don't think it's a stable material, so I
> > didn't cc them.
> > 
> >   arch/m68k/mm/mcfmmu.c | 5 -----
> >   1 file changed, 5 deletions(-)
> > 
> > diff --git a/arch/m68k/mm/mcfmmu.c b/arch/m68k/mm/mcfmmu.c
> > index 29f47923aa46..cb9f8675d81b 100644
> > --- a/arch/m68k/mm/mcfmmu.c
> > +++ b/arch/m68k/mm/mcfmmu.c
> > @@ -214,11 +214,6 @@ void __init cf_mmu_context_init(void)
> >   /*
> >    * Steal a context from a task that has one at the moment.
> > - * This is only used on 8xx and 4xx and we presently assume that
> > - * they don't do SMP.  If they do then thicfpgalloc.hs will have to check
> > - * whether the MM we steal is in use.
> > - * We also assume that this is only used on systems that don't
> > - * use an MMU hash table - this is true for 8xx and 4xx.
> >    * This isn't an LRU system, it just frees up each context in
> >    * turn (sort-of pseudo-random replacement :).  This would be the
> >    * place to implement an LRU scheme if anyone was motivated to do it.
> > 

-- 
Sincerely yours,
Mike.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] m68k: mcfmmu: remove stale part of comment about steal_context
  2020-06-18 12:09   ` Mike Rapoport
@ 2020-06-18 12:25     ` Greg Ungerer
  0 siblings, 0 replies; 4+ messages in thread
From: Greg Ungerer @ 2020-06-18 12:25 UTC (permalink / raw)
  To: Mike Rapoport; +Cc: Geert Uytterhoeven, linux-m68k, Mike Rapoport

Hi Mike

On 18/6/20 10:09 pm, Mike Rapoport wrote:
> On Thu, Jun 18, 2020 at 09:48:42PM +1000, Greg Ungerer wrote:
>> On 18/6/20 6:17 pm, Mike Rapoport wrote:
>>> From: Mike Rapoport <rppt@linux.ibm.com>
>>>
>>> The comment about steal_context() came from powerpc and a part of it
>>> addresses differences between powerpc variants that are not really
>>> relevant to m68k.
>>>
>>> Remove that part of the comment.
>>>
>>> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
>>
>> Acked-by: Greg Ungerer <gerg@linux-m68k.org>
>>
>> Do you want me to carry that in my m68k (m68knommu) tree for v5.9?
> 
> Yes, please :)

Applied to for-next branch of m68knommu git tree.

Thanks!
Greg



>>> ---
>>> Hi,
>>>
>>> I've found this by pure chance while grepping for pgalloc.h
>>> It's been there since 2011, but I don't think it's a stable material, so I
>>> didn't cc them.
>>>
>>>    arch/m68k/mm/mcfmmu.c | 5 -----
>>>    1 file changed, 5 deletions(-)
>>>
>>> diff --git a/arch/m68k/mm/mcfmmu.c b/arch/m68k/mm/mcfmmu.c
>>> index 29f47923aa46..cb9f8675d81b 100644
>>> --- a/arch/m68k/mm/mcfmmu.c
>>> +++ b/arch/m68k/mm/mcfmmu.c
>>> @@ -214,11 +214,6 @@ void __init cf_mmu_context_init(void)
>>>    /*
>>>     * Steal a context from a task that has one at the moment.
>>> - * This is only used on 8xx and 4xx and we presently assume that
>>> - * they don't do SMP.  If they do then thicfpgalloc.hs will have to check
>>> - * whether the MM we steal is in use.
>>> - * We also assume that this is only used on systems that don't
>>> - * use an MMU hash table - this is true for 8xx and 4xx.
>>>     * This isn't an LRU system, it just frees up each context in
>>>     * turn (sort-of pseudo-random replacement :).  This would be the
>>>     * place to implement an LRU scheme if anyone was motivated to do it.
>>>
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-18  8:17 [PATCH] m68k: mcfmmu: remove stale part of comment about steal_context Mike Rapoport
2020-06-18 11:48 ` Greg Ungerer
2020-06-18 12:09   ` Mike Rapoport
2020-06-18 12:25     ` Greg Ungerer

Linux-m68k Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-m68k/0 linux-m68k/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-m68k linux-m68k/ https://lore.kernel.org/linux-m68k \
		linux-m68k@vger.kernel.org linux-m68k@lists.linux-m68k.org
	public-inbox-index linux-m68k

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-m68k


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git