From: "Lino Sanfilippo" <LinoSanfilippo@gmx.de>
Cc: netdev@vger.kernel.org, linux-m68k@vger.kernel.org,
Greg Ungerer <gerg@linux-m68k.org>
Subject: Re: [PATCH] net: fec: set dma_coherent_mask
Date: Tue, 27 Mar 2018 15:24:34 +0200 [thread overview]
Message-ID: <trinity-e93e9d10-7432-4fb0-a576-aeee9207df00-1522157074887@3c-app-gmx-bs61> (raw)
In-Reply-To: <1522071386-29743-1-git-send-email-gerg@linux-m68k.org>
Hi,
>
> + dma_set_coherent_mask(&fep->pdev->dev, DMA_BIT_MASK(32));
> +
> for (i = 0; i < fep->num_tx_queues; i++) {
> txq = kzalloc(sizeof(*txq), GFP_KERNEL);
> if (!txq) {
dma_set_coherent_mask() can fail, so the return value should be checked and
a failure be handled accordingly.
Regards,
Lino
prev parent reply other threads:[~2018-03-27 13:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 13:36 [PATCH] net: fec: set dma_coherent_mask Greg Ungerer
2018-03-27 12:59 ` Geert Uytterhoeven
2018-03-28 3:04 ` Andy Duan
2018-03-28 7:06 ` Geert Uytterhoeven
2018-03-28 7:15 ` Andy Duan
2018-03-28 7:27 ` Greg Ungerer
2018-03-28 7:57 ` Geert Uytterhoeven
2018-03-28 12:29 ` Greg Ungerer
2018-03-27 13:24 ` Lino Sanfilippo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-e93e9d10-7432-4fb0-a576-aeee9207df00-1522157074887@3c-app-gmx-bs61 \
--to=linosanfilippo@gmx.de \
--cc=gerg@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).