linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V3 0/5] smartpqi man page update
@ 2019-08-26 15:41 Don Brace
  2019-08-26 15:41 ` [PATCH V3 1/5] smartpqi: fix spelling error Don Brace
                   ` (4 more replies)
  0 siblings, 5 replies; 13+ messages in thread
From: Don Brace @ 2019-08-26 15:41 UTC (permalink / raw)
  To: mtk.manpages
  Cc: linux-man, Kevin.Barnett, scott.teel, Justin.Lindley,
	scott.benesh, bader.alisaleh, gerry.morong, mahesh.rajashekhara

These patches are based on the man pages in kernel.org

Changes since V1:
 - corrected copyright.

Changes since V2:
 - redacted patch to change the lockup action table
 - removed an unneeded .TP entry.
 - both changes from G. Branden Robinson's review.
 - thanks for your review input.

---

Dave Carroll (1):
      smartpqi: add module param to hide vsep

Don Brace (2):
      smartpqi: fix spelling error
      smartpqi: update copyright

Gilbert Wu (1):
      smartpqi: add module param expose ld first

Murthy Bhat (1):
      smartpqi: add sysfs entries


 man4/smartpqi.4 |   95 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 93 insertions(+), 2 deletions(-)

--
Signature

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH V3 1/5] smartpqi: fix spelling error
  2019-08-26 15:41 [PATCH V3 0/5] smartpqi man page update Don Brace
@ 2019-08-26 15:41 ` Don Brace
  2019-08-26 21:35   ` Michael Kerrisk (man-pages)
  2019-08-26 15:41 ` [PATCH V3 2/5] smartpqi: update copyright Don Brace
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 13+ messages in thread
From: Don Brace @ 2019-08-26 15:41 UTC (permalink / raw)
  To: mtk.manpages
  Cc: linux-man, Kevin.Barnett, scott.teel, Justin.Lindley,
	scott.benesh, bader.alisaleh, gerry.morong, mahesh.rajashekhara

- correct smarpqi to smartpqi

Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
 man4/smartpqi.4 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
index cf7c43034..704efb735 100644
--- a/man4/smartpqi.4
+++ b/man4/smartpqi.4
@@ -215,7 +215,7 @@ $ \c
 .in
 .SH VERSIONS
 The
-.B smarpqi
+.B smartpqi
 driver was added in Linux 4.9.
 .SH NOTES
 .SS Configuration


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH V3 2/5] smartpqi: update copyright
  2019-08-26 15:41 [PATCH V3 0/5] smartpqi man page update Don Brace
  2019-08-26 15:41 ` [PATCH V3 1/5] smartpqi: fix spelling error Don Brace
@ 2019-08-26 15:41 ` Don Brace
  2019-08-26 21:36   ` Michael Kerrisk (man-pages)
  2019-08-26 15:41 ` [PATCH V3 3/5] smartpqi: add module param expose ld first Don Brace
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 13+ messages in thread
From: Don Brace @ 2019-08-26 15:41 UTC (permalink / raw)
  To: mtk.manpages
  Cc: linux-man, Kevin.Barnett, scott.teel, Justin.Lindley,
	scott.benesh, bader.alisaleh, gerry.morong, mahesh.rajashekhara

Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
 man4/smartpqi.4 |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
index 704efb735..dc9ef1020 100644
--- a/man4/smartpqi.4
+++ b/man4/smartpqi.4
@@ -1,4 +1,5 @@
-.\" Copyright (C) 2016-2017, Microsemi Corporation
+.\" Copyright (C) 2019, Microchip Technology Inc. and its subsidiaries
+.\" Copyright (C) 2016-2018, Microsemi Corporation
 .\" Copyright (C) 2016, PMC-Sierra, Inc.
 .\" Written by Kevin Barnett <kevin.barnett@microsemi.com>
 .\"


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH V3 3/5] smartpqi: add module param expose ld first
  2019-08-26 15:41 [PATCH V3 0/5] smartpqi man page update Don Brace
  2019-08-26 15:41 ` [PATCH V3 1/5] smartpqi: fix spelling error Don Brace
  2019-08-26 15:41 ` [PATCH V3 2/5] smartpqi: update copyright Don Brace
@ 2019-08-26 15:41 ` Don Brace
  2019-08-26 21:45   ` Michael Kerrisk (man-pages)
  2019-08-26 15:41 ` [PATCH V3 4/5] smartpqi: add module param to hide vsep Don Brace
  2019-08-26 15:41 ` [PATCH V3 5/5] smartpqi: add sysfs entries Don Brace
  4 siblings, 1 reply; 13+ messages in thread
From: Don Brace @ 2019-08-26 15:41 UTC (permalink / raw)
  To: mtk.manpages
  Cc: linux-man, Kevin.Barnett, scott.teel, Justin.Lindley,
	scott.benesh, bader.alisaleh, gerry.morong, mahesh.rajashekhara

From: Gilbert Wu <gilbert.wu@microsemi.com>

Reviewed-by: Matt Perricone <matt.perricone@microsemi.com>
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Gilbert Wu <gilbert.wu@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
 man4/smartpqi.4 |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
index dc9ef1020..5389b8453 100644
--- a/man4/smartpqi.4
+++ b/man4/smartpqi.4
@@ -15,6 +15,7 @@ smartpqi \- Microsemi Smart Family SCSI driver
 .RB [ disable_heartbeat= { 0 | 1 }]
 .RB [ disable_ctrl_shutdown= { 0 | 1 }]
 .RB [ lockup_action= { none | reboot | panic }]
+.RB [ expose_ld_first= { 0 | 1 }]
 .YS
 .SH DESCRIPTION
 .B smartpqi
@@ -91,6 +92,10 @@ parameter	action
 \fBreboot\fP	reboot the system
 \fBpanic\fP	panic the system
 .TE
+.TP
+.BR expose_ld_first= { 0 | 1 }
+This option enables support for exposing logical devices to OS before physical devices.
+The default value is 0.
 .SH FILES
 .SS Device nodes
 Logical drives are accessed via the SCSI disk driver


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH V3 4/5] smartpqi: add module param to hide vsep
  2019-08-26 15:41 [PATCH V3 0/5] smartpqi man page update Don Brace
                   ` (2 preceding siblings ...)
  2019-08-26 15:41 ` [PATCH V3 3/5] smartpqi: add module param expose ld first Don Brace
@ 2019-08-26 15:41 ` Don Brace
  2019-08-26 21:46   ` Michael Kerrisk (man-pages)
  2019-08-26 15:41 ` [PATCH V3 5/5] smartpqi: add sysfs entries Don Brace
  4 siblings, 1 reply; 13+ messages in thread
From: Don Brace @ 2019-08-26 15:41 UTC (permalink / raw)
  To: mtk.manpages
  Cc: linux-man, Kevin.Barnett, scott.teel, Justin.Lindley,
	scott.benesh, bader.alisaleh, gerry.morong, mahesh.rajashekhara

From: Dave Carroll <david.carroll@microsemi.com>

Reviewed-by: Matt Perricone <matt.perricone@microsemi.com>
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Dave Carroll <david.carroll@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
 man4/smartpqi.4 |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
index 5389b8453..a8cc621a3 100644
--- a/man4/smartpqi.4
+++ b/man4/smartpqi.4
@@ -16,6 +16,7 @@ smartpqi \- Microsemi Smart Family SCSI driver
 .RB [ disable_ctrl_shutdown= { 0 | 1 }]
 .RB [ lockup_action= { none | reboot | panic }]
 .RB [ expose_ld_first= { 0 | 1 }]
+.RB [ hide_vsep= { 0 | 1 }]
 .YS
 .SH DESCRIPTION
 .B smartpqi
@@ -96,6 +97,10 @@ parameter	action
 .BR expose_ld_first= { 0 | 1 }
 This option enables support for exposing logical devices to OS before physical devices.
 The default value is 0.
+.TP
+.BR hide_vsep= { 0 | 1 }
+This option enables disabling exposure of the virtual SEP to the host. This is usually associated with direct attached drives.
+The default value is 0.
 .SH FILES
 .SS Device nodes
 Logical drives are accessed via the SCSI disk driver


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH V3 5/5] smartpqi: add sysfs entries
  2019-08-26 15:41 [PATCH V3 0/5] smartpqi man page update Don Brace
                   ` (3 preceding siblings ...)
  2019-08-26 15:41 ` [PATCH V3 4/5] smartpqi: add module param to hide vsep Don Brace
@ 2019-08-26 15:41 ` Don Brace
  2019-08-26 21:52   ` Michael Kerrisk (man-pages)
  4 siblings, 1 reply; 13+ messages in thread
From: Don Brace @ 2019-08-26 15:41 UTC (permalink / raw)
  To: mtk.manpages
  Cc: linux-man, Kevin.Barnett, scott.teel, Justin.Lindley,
	scott.benesh, bader.alisaleh, gerry.morong, mahesh.rajashekhara

From: Murthy Bhat <Murthy.Bhat@microsemi.com>

Reviewed-by: Matt Perricone <matt.perricone@microsemi.com>
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Signed-off-by: Murthy Bhat <Murthy.Bhat@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
 man4/smartpqi.4 |   80 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 80 insertions(+)

diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
index a8cc621a3..3f4473fa4 100644
--- a/man4/smartpqi.4
+++ b/man4/smartpqi.4
@@ -160,6 +160,86 @@ above
 for an explanation of the
 .I lockup_action
 values.
+.TP
+.IR /sys/class/scsi_host/host*/driver_version
+The
+.I driver_version
+attribute is read-only.
+This attribute contains the smartpqi driver version.
+.IP
+For example:
+.IP
+.in +2n
+.EX
+$ \c
+.B cat /sys/class/scsi_host/host1/driver_version
+1.1.2-126
+.EE
+.in
+.TP
+.IR /sys/class/scsi_host/host*/firmware_version
+The
+.I firmware_version
+attribute is read-only.
+This attribute contains the controller firmware version.
+.IP
+For example:
+.IP
+.in +2n
+.EX
+$ \c
+.B cat /sys/class/scsi_host/host1/firmware_version
+1.29-112
+.EE
+.in
+.TP
+.IR /sys/class/scsi_host/host*/model
+The
+.I model
+attribute is read-only.
+This attribute contains the product identification string of the controller.
+.IP
+For example:
+.IP
+.in +2n
+.EX
+$ \c
+.B cat /sys/class/scsi_host/host1/model
+1100-16i
+.EE
+.in
+.TP
+.IR /sys/class/scsi_host/host*/serial_number
+The
+.I serial_number
+attribute is read-only.
+This attribute contains the unique identification number of the controller.
+.IP
+For example:
+.IP
+.in +2n
+.EX
+$ \c
+.B cat /sys/class/scsi_host/host1/serial_number
+6A316373777
+.EE
+.in
+.TP
+.IR /sys/class/scsi_host/host*/vendor
+The
+.I vendor
+attribute is read-only.
+This attribute contains the vendor identification string of the controller.
+.IP
+For example:
+.IP
+.in +2n
+.EX
+$ \c
+.B cat /sys/class/scsi_host/host1/vendor
+Adaptec
+.EE
+.in
 .SS SmartPQI-specific disk attribute files in \f[BI]/sys\fP
 In the file specifications below,
 .I c


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH V3 1/5] smartpqi: fix spelling error
  2019-08-26 15:41 ` [PATCH V3 1/5] smartpqi: fix spelling error Don Brace
@ 2019-08-26 21:35   ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 13+ messages in thread
From: Michael Kerrisk (man-pages) @ 2019-08-26 21:35 UTC (permalink / raw)
  To: Don Brace
  Cc: mtk.manpages, linux-man, Kevin.Barnett, scott.teel,
	Justin.Lindley, scott.benesh, bader.alisaleh, gerry.morong,
	mahesh.rajashekhara

On 8/26/19 5:41 PM, Don Brace wrote:
> - correct smarpqi to smartpqi

Thanks, Don. Patch applied.

Cheers,

Michael

> Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>
> ---
>  man4/smartpqi.4 |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
> index cf7c43034..704efb735 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -215,7 +215,7 @@ $ \c
>  .in
>  .SH VERSIONS
>  The
> -.B smarpqi
> +.B smartpqi
>  driver was added in Linux 4.9.
>  .SH NOTES
>  .SS Configuration
> 
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH V3 2/5] smartpqi: update copyright
  2019-08-26 15:41 ` [PATCH V3 2/5] smartpqi: update copyright Don Brace
@ 2019-08-26 21:36   ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 13+ messages in thread
From: Michael Kerrisk (man-pages) @ 2019-08-26 21:36 UTC (permalink / raw)
  To: Don Brace
  Cc: mtk.manpages, linux-man, Kevin.Barnett, scott.teel,
	Justin.Lindley, scott.benesh, bader.alisaleh, gerry.morong,
	mahesh.rajashekhara

On 8/26/19 5:41 PM, Don Brace wrote:
> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>

Thanks, Don. Patch applied.

Cheers,

Michael

> ---
>  man4/smartpqi.4 |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
> index 704efb735..dc9ef1020 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -1,4 +1,5 @@
> -.\" Copyright (C) 2016-2017, Microsemi Corporation
> +.\" Copyright (C) 2019, Microchip Technology Inc. and its subsidiaries
> +.\" Copyright (C) 2016-2018, Microsemi Corporation
>  .\" Copyright (C) 2016, PMC-Sierra, Inc.
>  .\" Written by Kevin Barnett <kevin.barnett@microsemi.com>
>  .\"
> 
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH V3 3/5] smartpqi: add module param expose ld first
  2019-08-26 15:41 ` [PATCH V3 3/5] smartpqi: add module param expose ld first Don Brace
@ 2019-08-26 21:45   ` Michael Kerrisk (man-pages)
  2019-08-26 21:47     ` Don.Brace
  0 siblings, 1 reply; 13+ messages in thread
From: Michael Kerrisk (man-pages) @ 2019-08-26 21:45 UTC (permalink / raw)
  To: Don Brace
  Cc: mtk.manpages, linux-man, Kevin.Barnett, scott.teel,
	Justin.Lindley, scott.benesh, bader.alisaleh, gerry.morong,
	mahesh.rajashekhara, Gilbert Wu

Hello Don

Patch applied. But a question below.

On 8/26/19 5:41 PM, Don Brace wrote:
> From: Gilbert Wu <gilbert.wu@microsemi.com>
> 
> Reviewed-by: Matt Perricone <matt.perricone@microsemi.com>
> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> Signed-off-by: Gilbert Wu <gilbert.wu@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>
> ---
>  man4/smartpqi.4 |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
> index dc9ef1020..5389b8453 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -15,6 +15,7 @@ smartpqi \- Microsemi Smart Family SCSI driver
>  .RB [ disable_heartbeat= { 0 | 1 }]
>  .RB [ disable_ctrl_shutdown= { 0 | 1 }]
>  .RB [ lockup_action= { none | reboot | panic }]
> +.RB [ expose_ld_first= { 0 | 1 }]
>  .YS
>  .SH DESCRIPTION
>  .B smartpqi
> @@ -91,6 +92,10 @@ parameter	action
>  \fBreboot\fP	reboot the system
>  \fBpanic\fP	panic the system
>  .TE
> +.TP
> +.BR expose_ld_first= { 0 | 1 }
> +This option enables support for exposing logical devices to OS before physical devices.

Should "OS' instead be "the operating system"?

> +The default value is 0.
>  .SH FILES
>  .SS Device nodes
>  Logical drives are accessed via the SCSI disk driver

Thanks,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH V3 4/5] smartpqi: add module param to hide vsep
  2019-08-26 15:41 ` [PATCH V3 4/5] smartpqi: add module param to hide vsep Don Brace
@ 2019-08-26 21:46   ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 13+ messages in thread
From: Michael Kerrisk (man-pages) @ 2019-08-26 21:46 UTC (permalink / raw)
  To: Don Brace
  Cc: mtk.manpages, linux-man, Kevin.Barnett, scott.teel,
	Justin.Lindley, scott.benesh, bader.alisaleh, gerry.morong,
	mahesh.rajashekhara

Hello Don,

On 8/26/19 5:41 PM, Don Brace wrote:
> From: Dave Carroll <david.carroll@microsemi.com>
> 
> Reviewed-by: Matt Perricone <matt.perricone@microsemi.com>
> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> Signed-off-by: Dave Carroll <david.carroll@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>
> ---
>  man4/smartpqi.4 |    5 +++++
>  1 file changed, 5 insertions(+)

Patch applied.

Thanks,

Michael

> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
> index 5389b8453..a8cc621a3 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -16,6 +16,7 @@ smartpqi \- Microsemi Smart Family SCSI driver
>  .RB [ disable_ctrl_shutdown= { 0 | 1 }]
>  .RB [ lockup_action= { none | reboot | panic }]
>  .RB [ expose_ld_first= { 0 | 1 }]
> +.RB [ hide_vsep= { 0 | 1 }]
>  .YS
>  .SH DESCRIPTION
>  .B smartpqi
> @@ -96,6 +97,10 @@ parameter	action
>  .BR expose_ld_first= { 0 | 1 }
>  This option enables support for exposing logical devices to OS before physical devices.
>  The default value is 0.
> +.TP
> +.BR hide_vsep= { 0 | 1 }
> +This option enables disabling exposure of the virtual SEP to the host. This is usually associated with direct attached drives.
> +The default value is 0.
>  .SH FILES
>  .SS Device nodes
>  Logical drives are accessed via the SCSI disk driver
> 
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 13+ messages in thread

* RE: [PATCH V3 3/5] smartpqi: add module param expose ld first
  2019-08-26 21:45   ` Michael Kerrisk (man-pages)
@ 2019-08-26 21:47     ` Don.Brace
  2019-08-26 22:02       ` Michael Kerrisk (man-pages)
  0 siblings, 1 reply; 13+ messages in thread
From: Don.Brace @ 2019-08-26 21:47 UTC (permalink / raw)
  To: mtk.manpages, don.brace
  Cc: linux-man, Kevin.Barnett, Scott.Teel, Justin.Lindley,
	Scott.Benesh, bader.alisaleh, Gerry.Morong, Mahesh.Rajashekhara,
	gilbert.wu

-----Original Message-----
From: Michael Kerrisk (man-pages) [mailto:mtk.manpages@gmail.com] 
Sent: Monday, August 26, 2019 4:46 PM
To: Don Brace <don.brace@microsemi.com>
Cc: mtk.manpages@gmail.com; linux-man@vger.kernel.org; Kevin Barnett - C33748 <Kevin.Barnett@microchip.com>; Scott Teel - C33730 <Scott.Teel@microchip.com>; Justin Lindley - C33718 <Justin.Lindley@microchip.com>; Scott Benesh - C33703 <Scott.Benesh@microchip.com>; bader.alisaleh@microchip.com; Gerry Morong - C33720 <Gerry.Morong@microchip.com>; Mahesh Rajashekhara - I30583 <Mahesh.Rajashekhara@microchip.com>; Gilbert Wu <gilbert.wu@microsemi.com>
Subject: Re: [PATCH V3 3/5] smartpqi: add module param expose ld first

External E-Mail


Hello Don

Patch applied. But a question below.

On 8/26/19 5:41 PM, Don Brace wrote:
> From: Gilbert Wu <gilbert.wu@microsemi.com>
> 
> Reviewed-by: Matt Perricone <matt.perricone@microsemi.com>
> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> Signed-off-by: Gilbert Wu <gilbert.wu@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>
> ---
>  man4/smartpqi.4 |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4 index 
> dc9ef1020..5389b8453 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -15,6 +15,7 @@ smartpqi \- Microsemi Smart Family SCSI driver  .RB 
> [ disable_heartbeat= { 0 | 1 }]  .RB [ disable_ctrl_shutdown= { 0 | 1 
> }]  .RB [ lockup_action= { none | reboot | panic }]
> +.RB [ expose_ld_first= { 0 | 1 }]
>  .YS
>  .SH DESCRIPTION
>  .B smartpqi
> @@ -91,6 +92,10 @@ parameter	action
>  \fBreboot\fP	reboot the system
>  \fBpanic\fP	panic the system
>  .TE
> +.TP
> +.BR expose_ld_first= { 0 | 1 }
> +This option enables support for exposing logical devices to OS before physical devices.

Should "OS' instead be "the operating system"?

"The operating system" sounds better.
Thanks,
Don Brace

> +The default value is 0.
>  .SH FILES
>  .SS Device nodes
>  Logical drives are accessed via the SCSI disk driver

Thanks,

Michael



--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH V3 5/5] smartpqi: add sysfs entries
  2019-08-26 15:41 ` [PATCH V3 5/5] smartpqi: add sysfs entries Don Brace
@ 2019-08-26 21:52   ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 13+ messages in thread
From: Michael Kerrisk (man-pages) @ 2019-08-26 21:52 UTC (permalink / raw)
  To: Don Brace
  Cc: mtk.manpages, linux-man, Kevin.Barnett, scott.teel,
	Justin.Lindley, scott.benesh, bader.alisaleh, gerry.morong,
	mahesh.rajashekhara

Hello Don,

On 8/26/19 5:41 PM, Don Brace wrote:
> From: Murthy Bhat <Murthy.Bhat@microsemi.com>
> 
> Reviewed-by: Matt Perricone <matt.perricone@microsemi.com>
> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> Signed-off-by: Murthy Bhat <Murthy.Bhat@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>

Thanks. Patch applied.

Cheers,

Michael

> ---
>  man4/smartpqi.4 |   80 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 80 insertions(+)
> 
> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
> index a8cc621a3..3f4473fa4 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -160,6 +160,86 @@ above
>  for an explanation of the
>  .I lockup_action
>  values.
> +.TP
> +.IR /sys/class/scsi_host/host*/driver_version
> +The
> +.I driver_version
> +attribute is read-only.
> +This attribute contains the smartpqi driver version.
> +.IP
> +For example:
> +.IP
> +.in +2n
> +.EX
> +$ \c
> +.B cat /sys/class/scsi_host/host1/driver_version
> +1.1.2-126
> +.EE
> +.in
> +.TP
> +.IR /sys/class/scsi_host/host*/firmware_version
> +The
> +.I firmware_version
> +attribute is read-only.
> +This attribute contains the controller firmware version.
> +.IP
> +For example:
> +.IP
> +.in +2n
> +.EX
> +$ \c
> +.B cat /sys/class/scsi_host/host1/firmware_version
> +1.29-112
> +.EE
> +.in
> +.TP
> +.IR /sys/class/scsi_host/host*/model
> +The
> +.I model
> +attribute is read-only.
> +This attribute contains the product identification string of the controller.
> +.IP
> +For example:
> +.IP
> +.in +2n
> +.EX
> +$ \c
> +.B cat /sys/class/scsi_host/host1/model
> +1100-16i
> +.EE
> +.in
> +.TP
> +.IR /sys/class/scsi_host/host*/serial_number
> +The
> +.I serial_number
> +attribute is read-only.
> +This attribute contains the unique identification number of the controller.
> +.IP
> +For example:
> +.IP
> +.in +2n
> +.EX
> +$ \c
> +.B cat /sys/class/scsi_host/host1/serial_number
> +6A316373777
> +.EE
> +.in
> +.TP
> +.IR /sys/class/scsi_host/host*/vendor
> +The
> +.I vendor
> +attribute is read-only.
> +This attribute contains the vendor identification string of the controller.
> +.IP
> +For example:
> +.IP
> +.in +2n
> +.EX
> +$ \c
> +.B cat /sys/class/scsi_host/host1/vendor
> +Adaptec
> +.EE
> +.in
>  .SS SmartPQI-specific disk attribute files in \f[BI]/sys\fP
>  In the file specifications below,
>  .I c
> 
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH V3 3/5] smartpqi: add module param expose ld first
  2019-08-26 21:47     ` Don.Brace
@ 2019-08-26 22:02       ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 13+ messages in thread
From: Michael Kerrisk (man-pages) @ 2019-08-26 22:02 UTC (permalink / raw)
  To: Don.Brace
  Cc: Don Brace, linux-man, Kevin.Barnett, Scott.Teel, Justin.Lindley,
	Scott.Benesh, bader.alisaleh, Gerry.Morong, Mahesh.Rajashekhara,
	Gilbert Wu

Hello Don,

On Mon, 26 Aug 2019 at 23:48, <Don.Brace@microchip.com> wrote:
>
> -----Original Message-----
> From: Michael Kerrisk (man-pages) [mailto:mtk.manpages@gmail.com]
> Sent: Monday, August 26, 2019 4:46 PM
> To: Don Brace <don.brace@microsemi.com>
> Cc: mtk.manpages@gmail.com; linux-man@vger.kernel.org; Kevin Barnett - C33748 <Kevin.Barnett@microchip.com>; Scott Teel - C33730 <Scott.Teel@microchip.com>; Justin Lindley - C33718 <Justin.Lindley@microchip.com>; Scott Benesh - C33703 <Scott.Benesh@microchip.com>; bader.alisaleh@microchip.com; Gerry Morong - C33720 <Gerry.Morong@microchip.com>; Mahesh Rajashekhara - I30583 <Mahesh.Rajashekhara@microchip.com>; Gilbert Wu <gilbert.wu@microsemi.com>
> Subject: Re: [PATCH V3 3/5] smartpqi: add module param expose ld first
>
> External E-Mail
>
>
> Hello Don
>
> Patch applied. But a question below.
>
> On 8/26/19 5:41 PM, Don Brace wrote:
> > From: Gilbert Wu <gilbert.wu@microsemi.com>
> >
> > Reviewed-by: Matt Perricone <matt.perricone@microsemi.com>
> > Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> > Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> > Signed-off-by: Gilbert Wu <gilbert.wu@microsemi.com>
> > Signed-off-by: Don Brace <don.brace@microsemi.com>
> > ---
> >  man4/smartpqi.4 |    5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/man4/smartpqi.4 b/man4/smartpqi.4 index
> > dc9ef1020..5389b8453 100644
> > --- a/man4/smartpqi.4
> > +++ b/man4/smartpqi.4
> > @@ -15,6 +15,7 @@ smartpqi \- Microsemi Smart Family SCSI driver  .RB
> > [ disable_heartbeat= { 0 | 1 }]  .RB [ disable_ctrl_shutdown= { 0 | 1
> > }]  .RB [ lockup_action= { none | reboot | panic }]
> > +.RB [ expose_ld_first= { 0 | 1 }]
> >  .YS
> >  .SH DESCRIPTION
> >  .B smartpqi
> > @@ -91,6 +92,10 @@ parameter  action
> >  \fBreboot\fP reboot the system
> >  \fBpanic\fP  panic the system
> >  .TE
> > +.TP
> > +.BR expose_ld_first= { 0 | 1 }
> > +This option enables support for exposing logical devices to OS before physical devices.
>
> Should "OS' instead be "the operating system"?
>
> "The operating system" sounds better.
> Thanks,
> Don Brace

Thanks. Page amended.

Cheers,

Michael

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-08-26 22:03 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-26 15:41 [PATCH V3 0/5] smartpqi man page update Don Brace
2019-08-26 15:41 ` [PATCH V3 1/5] smartpqi: fix spelling error Don Brace
2019-08-26 21:35   ` Michael Kerrisk (man-pages)
2019-08-26 15:41 ` [PATCH V3 2/5] smartpqi: update copyright Don Brace
2019-08-26 21:36   ` Michael Kerrisk (man-pages)
2019-08-26 15:41 ` [PATCH V3 3/5] smartpqi: add module param expose ld first Don Brace
2019-08-26 21:45   ` Michael Kerrisk (man-pages)
2019-08-26 21:47     ` Don.Brace
2019-08-26 22:02       ` Michael Kerrisk (man-pages)
2019-08-26 15:41 ` [PATCH V3 4/5] smartpqi: add module param to hide vsep Don Brace
2019-08-26 21:46   ` Michael Kerrisk (man-pages)
2019-08-26 15:41 ` [PATCH V3 5/5] smartpqi: add sysfs entries Don Brace
2019-08-26 21:52   ` Michael Kerrisk (man-pages)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).