From: Christian Brauner <christian.brauner@ubuntu.com>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
Christian Brauner <christian@brauner.io>,
Jann Horn <jannh@google.com>,
Daniel Colascione <dancol@google.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Joel Fernandes <joel@joelfernandes.org>,
Linux API <linux-api@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-man <linux-man@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: For review: pidfd_open(2) manual page
Date: Mon, 23 Sep 2019 16:47:13 +0200 [thread overview]
Message-ID: <20190923144711.ssbrg6bdquhewo7q@wittgenstein> (raw)
In-Reply-To: <87tv939td6.fsf@mid.deneb.enyo.de>
On Mon, Sep 23, 2019 at 12:53:09PM +0200, Florian Weimer wrote:
> * Michael Kerrisk:
>
> > SYNOPSIS
> > int pidfd_open(pid_t pid, unsigned int flags);
>
> Should this mention <sys/types.h> for pid_t?
>
> > ERRORS
> > EINVAL flags is not 0.
> >
> > EINVAL pid is not valid.
> >
> > ESRCH The process specified by pid does not exist.
>
> Presumably, EMFILE and ENFILE are also possible errors, and so is
> ENOMEM.
So, error codes that could surface are:
EMFILE: too many open files
ENODEV: the anon inode filesystem is not available in this kernel (unlikely)
ENOMEM: not enough memory (to allocate the backing struct file)
ENFILE: you're over the max_files limit which can be set through proc
I think that should be it.
>
> > A PID file descriptor can be monitored using poll(2), select(2),
> > and epoll(7). When the process that it refers to terminates, the
> > file descriptor indicates as readable. Note, however, that in the
> > current implementation, nothing can be read from the file descrip‐
> > tor.
>
> “is indicated as readable” or “becomes readable”? Will reading block?
>
> > The pidfd_open() system call is the preferred way of obtaining a
> > PID file descriptor. The alternative is to obtain a file descrip‐
> > tor by opening a /proc/[pid] directory. However, the latter tech‐
> > nique is possible only if the proc(5) file system is mounted; fur‐
> > thermore, the file descriptor obtained in this way is not pol‐
> > lable.
>
> One question is whether the glibc wrapper should fall back back to the
> /proc subdirectory if it is not available. Probably not.
No, that would not be transparent to userspace. Especially because both
fds differ in what can be done with them.
>
> > static
> > int pidfd_open(pid_t pid, unsigned int flags)
> > {
> > return syscall(__NR_pidfd_open, pid, flags);
> > }
>
> Please call this function something else (not pidfd_open), so that the
> example continues to work if glibc provides the system call wrapper.
Agreed!
next prev parent reply other threads:[~2019-09-23 14:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 9:11 For review: pidfd_open(2) manual page Michael Kerrisk (man-pages)
2019-09-23 10:53 ` Florian Weimer
2019-09-23 11:26 ` Daniel Colascione
2019-09-23 20:22 ` Michael Kerrisk (man-pages)
2019-09-23 14:47 ` Christian Brauner [this message]
2019-09-23 20:22 ` Michael Kerrisk (man-pages)
2019-09-23 20:20 ` Michael Kerrisk (man-pages)
2019-09-23 20:41 ` Florian Weimer
2019-09-23 20:57 ` Michael Kerrisk (man-pages)
2019-09-24 7:38 ` Christian Brauner
2019-09-23 14:38 ` Christian Brauner
2019-09-23 20:21 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923144711.ssbrg6bdquhewo7q@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=christian@brauner.io \
--cc=dancol@google.com \
--cc=ebiederm@xmission.com \
--cc=fw@deneb.enyo.de \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).