[PATCH 1/1] getdents.2: Mention glibc support for getdents64()

[PATCH 1/1] getdents.2: Mention glibc support for getdents64()

[Petr Vorel]

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 man2/getdents.2 | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/man2/getdents.2 b/man2/getdents.2
index 712d23c58..a6b7aad1f 100644
--- a/man2/getdents.2
+++ b/man2/getdents.2
@@ -40,7 +40,8 @@ getdents, getdents64 \- get directory entries
 .fi
 .PP
 .IR Note :
-There are no glibc wrappers for these system calls; see NOTES.
+There is no glibc wrapper for getdents().
+Wrapper for getdents64() was added in glibc 2.30; see NOTES.
 .SH DESCRIPTION
 These are not the interfaces you are interested in.
 Look at
@@ -203,9 +204,11 @@ File descriptor does not refer to a directory.
 SVr4.
 .\" SVr4 documents additional ENOLINK, EIO error conditions.
 .SH NOTES
-Glibc does not provide a wrapper for these system calls; call them using
+Library support for getdents64() was added in glibc 2.30;
+there is no glibc wrapper for getdents();
+call getdents() (or getdents64() on earlier versions) requires using
 .BR syscall (2).
-You will need to define the
+In that case you will need to define the
 .I linux_dirent
 or
 .I linux_dirent64
-- 
2.23.0

Re: [PATCH 1/1] getdents.2: Mention glibc support for getdents64()

[Michael Kerrisk (man-pages)]

Hello Petr,

On 10/7/19 3:53 PM, Petr Vorel wrote:
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  man2/getdents.2 | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/man2/getdents.2 b/man2/getdents.2
> index 712d23c58..a6b7aad1f 100644

Thanks. Patch applied.

Cheers,

Michael


> --- a/man2/getdents.2
> +++ b/man2/getdents.2
> @@ -40,7 +40,8 @@ getdents, getdents64 \- get directory entries
>  .fi
>  .PP
>  .IR Note :
> -There are no glibc wrappers for these system calls; see NOTES.
> +There is no glibc wrapper for getdents().
> +Wrapper for getdents64() was added in glibc 2.30; see NOTES.
>  .SH DESCRIPTION
>  These are not the interfaces you are interested in.
>  Look at
> @@ -203,9 +204,11 @@ File descriptor does not refer to a directory.
>  SVr4.
>  .\" SVr4 documents additional ENOLINK, EIO error conditions.
>  .SH NOTES
> -Glibc does not provide a wrapper for these system calls; call them using
> +Library support for getdents64() was added in glibc 2.30;
> +there is no glibc wrapper for getdents();
> +call getdents() (or getdents64() on earlier versions) requires using
>  .BR syscall (2).
> -You will need to define the
> +In that case you will need to define the
>  .I linux_dirent
>  or
>  .I linux_dirent64
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Re: [PATCH 1/1] getdents.2: Mention glibc support for getdents64()

[Petr Vorel]

Hi Michael,

> On 10/7/19 3:53 PM, Petr Vorel wrote:
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> >  man2/getdents.2 | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)

> > diff --git a/man2/getdents.2 b/man2/getdents.2
> > index 712d23c58..a6b7aad1f 100644

> Thanks. Patch applied.
Thanks a lot. I still don't see this patch in master (nor in other branches),
but you just maybe haven't pushed the changes.

BTW it'd be great if you push patch "Add manpage for fsopen(2), fspick(2) and
fsmount(2)" [1] and "Add manpages for move_mount(2) and open_tree(2)" [2] I sent
2 months ago. It's based on David Howells' work with few obvious fixes.
It might not be perfect, but IMHO it's a good start and it'd be great to have
these recent syscalls documented.

Kind regards,
Petr

[1] https://marc.info/?l=linux-man&m=158109737807969&w=2
[2] https://marc.info/?l=linux-man&m=158109737907972&w=2

Re: [PATCH 1/1] getdents.2: Mention glibc support for getdents64()

[Michael Kerrisk (man-pages)]

Hello Petr,

On 4/14/20 8:10 PM, Petr Vorel wrote:
> Hi Michael,
> 
>> On 10/7/19 3:53 PM, Petr Vorel wrote:
>>> Signed-off-by: Petr Vorel <pvorel@suse.cz>
>>> ---
>>>  man2/getdents.2 | 9 ++++++---
>>>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
>>> diff --git a/man2/getdents.2 b/man2/getdents.2
>>> index 712d23c58..a6b7aad1f 100644
> 
>> Thanks. Patch applied.
> Thanks a lot. I still don't see this patch in master (nor in other branches),
> but you just maybe haven't pushed the changes.

Yes, I've puushed now.

> 
> BTW it'd be great if you push patch "Add manpage for fsopen(2), fspick(2) and
> fsmount(2)" [1] and "Add manpages for move_mount(2) and open_tree(2)" [2] I sent
> 2 months ago. It's based on David Howells' work with few obvious fixes.
> It might not be perfect, but IMHO it's a good start and it'd be great to have
> these recent syscalls documented.
> 
> Kind regards,
> Petr
> 
> [1] https://marc.info/?l=linux-man&m=158109737807969&w=2
> [2] https://marc.info/?l=linux-man&m=158109737907972&w=2

These patches are on my radar still, Pester me in 
a few days if nothing happens :-).

Thanks,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Re: [PATCH 1/1] getdents.2: Mention glibc support for getdents64()

[Petr Vorel]

Hi Michael,

...
> >> Thanks. Patch applied.
> > Thanks a lot. I still don't see this patch in master (nor in other branches),
> > but you just maybe haven't pushed the changes.

> Yes, I've puushed now.
Thanks a lot!

> > BTW it'd be great if you push patch "Add manpage for fsopen(2), fspick(2) and
> > fsmount(2)" [1] and "Add manpages for move_mount(2) and open_tree(2)" [2] I sent
> > 2 months ago. It's based on David Howells' work with few obvious fixes.
> > It might not be perfect, but IMHO it's a good start and it'd be great to have
> > these recent syscalls documented.

> > Kind regards,
> > Petr

> > [1] https://marc.info/?l=linux-man&m=158109737807969&w=2
> > [2] https://marc.info/?l=linux-man&m=158109737907972&w=2

> These patches are on my radar still, Pester me in 
> a few days if nothing happens :-).
Thanks a lot, fully understand that you're busy :).

Kind regards,
Petr