From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABC2ECA9EA0 for ; Fri, 25 Oct 2019 17:09:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87F4221D71 for ; Fri, 25 Oct 2019 17:09:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505796AbfJYRJB (ORCPT ); Fri, 25 Oct 2019 13:09:01 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:51551 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2505797AbfJYRHa (ORCPT ); Fri, 25 Oct 2019 13:07:30 -0400 Received: from [213.220.153.21] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iO33g-0000qH-Bv; Fri, 25 Oct 2019 17:07:28 +0000 Date: Fri, 25 Oct 2019 19:07:27 +0200 From: Christian Brauner To: "Michael Kerrisk (man-pages)" Cc: Christian Brauner , lkml , linux-man , Kees Cook , Florian Weimer , Oleg Nesterov , Arnd Bergmann , David Howells , Pavel Emelyanov , Andrew Morton , Adrian Reber , Andrei Vagin , Linux API , Jann Horn Subject: Re: For review: documentation of clone3() system call Message-ID: <20191025170726.rqsquw4v4cuhduek@wittgenstein> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org On Fri, Oct 25, 2019 at 06:59:31PM +0200, Michael Kerrisk (man-pages) wrote: > Hello Christian and all, > > I've made a first shot at adding documentation for clone3(). You can > see the diff here: > https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/?id=faa0e55ae9e490d71c826546bbdef954a1800969 > > In the end, I decided that the most straightforward approach was to > add the documentation as part of the existing clone(2) page. This has > the advantage of avoiding duplication of information across two pages, > and perhaps also makes it easier to see the commonality of the two > APIs. > > Because the new text is integrated into the existing page, I think it > makes most sense to just show that page text for review purposes. I > welcome input on the below. > > The notable changes are: > * In the first part of the page, up to and including the paragraph > with the subheading "The flags bit mask" > * Minor changes in the description of CLONE_CHILD_CLEARTID, > CLONE_CHILD_SETTID, CLONE_PARENT_SETTID, and CLONE_PIDFD, to reflect > the argument differences between clone() and clone2() > > Most of the resy of page is unchanged. > > I welcome fixes, suggestions for improvements, etc. Thank you Michael, for doing this. I will hopefully get around to reviewing this soon but it might take a few days (latest after next week :( because of OSS/LSS). Christian