Linux-man Archive on lore.kernel.org
 help / color / Atom feed
From: Aleksa Sarai <cyphar@cyphar.com>
To: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
	linux-man@vger.kernel.org, linux-api@vger.kernel.org,
	Ingo Molnar <mingo@kernel.org>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Jiri Olsa <jolsa@redhat.com>,
	Patrick Bellasi <patrick.bellasi@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sched_getattr.2: update to include changed size semantics
Date: Fri, 29 Nov 2019 00:55:06 +1100
Message-ID: <20191128135506.yo7432egjsg5ha5a@yavin.dot.cyphar.com> (raw)
In-Reply-To: <20191128130840.GA3719@calabresa>

[-- Attachment #1: Type: text/plain, Size: 2831 bytes --]

On 2019-11-28, Thadeu Lima de Souza Cascardo <cascardo@canonical.com> wrote:
> On Thu, Nov 28, 2019 at 11:01:40PM +1100, Aleksa Sarai wrote:
> > Due to a userspace breakage, commit 1251201c0d34 ("sched/core: Fix
> > uclamp ABI bug, clean up and robustify sched_read_attr() ABI logic and
> > code") changed the semantics of sched_getattr(2) when the userspace
> > struct is smaller than the kernel struct. Now, any trailing non-zero
> > data in the kernel structure is ignored when copying to userspace.
> > 
> > Ref: 1251201c0d34 ("sched/core: Fix uclamp ABI bug, clean up and
> >                     robustify sched_read_attr() ABI logic and code")
> > Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> > ---
> >  man2/sched_setattr.2 | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/man2/sched_setattr.2 b/man2/sched_setattr.2
> > index 76ffa14eba85..fbb67b8eb98b 100644
> > --- a/man2/sched_setattr.2
> > +++ b/man2/sched_setattr.2
> > @@ -284,10 +284,8 @@ structure,
> >  the additional bytes in the user-space structure are not touched.
> >  If the caller-provided structure is smaller than the kernel
> >  .I sched_attr
> > -structure and the kernel needs to return values outside the provided space,
> > -.BR sched_getattr ()
> > -fails with the error
> > -.BR E2BIG .
> > +structure, the kernel will silently not return any values which would be stored
> > +outside the provided space.
> >  As with
> >  .BR sched_setattr (),
> >  these semantics allow for future extensibility of the interface.
> > -- 
> > 2.24.0
> > 
> 
> I was thinking about documenting the difference in behavior of older kernels,
> before uclamp support.
> 
> However, in practice, for sched_getattr, the kernel never returned E2BIG (the
> code uses EFBIG incorrectly, in fact). It does, however, return EINVAL for
> sizes smaller than SCHED_ATTR_SIZE_VER0.

I've been told the EFBIG was actually a typo and it was always meant to
be E2BIG. But yes, the precise problem with the old semantics was that
they weren't tested "in the wild" with a proper struct upgrade -- hence
all of the headaches.

If we ever do implement a copy_struct_to_user() we are almost certainly
going to implement it with the new sched_getattr() semantics. To be
honest, I'm not sure I can imagine a case where an old userspace program
would benefit from being given an error saying that the kernel has some
properties that it doesn't understand. (sched_getattr() is also weird
for other reasons, such as the fact it takes a separate size argument.)

> However, E2BIG is still mentioned below as a possible return value for
> sched_getattr. Can you remove that too?

Will do.

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28 12:01 Aleksa Sarai
2019-11-28 13:08 ` Thadeu Lima de Souza Cascardo
2019-11-28 13:55   ` Aleksa Sarai [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191128135506.yo7432egjsg5ha5a@yavin.dot.cyphar.com \
    --to=cyphar@cyphar.com \
    --cc=acme@infradead.org \
    --cc=cascardo@canonical.com \
    --cc=jolsa@redhat.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=patrick.bellasi@arm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-man Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-man/0 linux-man/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-man linux-man/ https://lore.kernel.org/linux-man \
		linux-man@vger.kernel.org
	public-inbox-index linux-man

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-man


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git