Linux-man Archive on lore.kernel.org
 help / color / Atom feed
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Adrian Reber <areber@redhat.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH v2] clone.2: added clone3() set_tid information
Date: Mon, 2 Dec 2019 23:14:55 +0100
Message-ID: <20191202221452.4obywepdevq5dq2w@wittgenstein> (raw)
In-Reply-To: <20191202142740.59402-1-areber@redhat.com>

On Mon, Dec 02, 2019 at 03:27:40PM +0100, Adrian Reber wrote:
> Signed-off-by: Adrian Reber <areber@redhat.com>

I'm generally fine with all of this, so:

Acked-by: Christian Brauner <christian.brauner@ubuntu.com>

but should this maybe also mention that a pid namespace either already
needs to have a pid 1 or if it does not the chosen pid has to be set to
1. In short:
"Callers may only choose a pid > 1 in a given pid namespace if an init
process (i.e. a process with pid 1) already exists. Otherwise the pid
entry for this pid namespace must be 1."
or something like this. 

	Christian

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 14:27 Adrian Reber
2019-12-02 22:14 ` Christian Brauner [this message]
2019-12-04  7:00   ` Adrian Reber

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191202221452.4obywepdevq5dq2w@wittgenstein \
    --to=christian.brauner@ubuntu.com \
    --cc=areber@redhat.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-man Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-man/0 linux-man/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-man linux-man/ https://lore.kernel.org/linux-man \
		linux-man@vger.kernel.org
	public-inbox-index linux-man

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-man


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git