From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4ED5C432C0 for ; Mon, 2 Dec 2019 22:14:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BC9820718 for ; Mon, 2 Dec 2019 22:14:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725834AbfLBWO7 (ORCPT ); Mon, 2 Dec 2019 17:14:59 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:52514 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbfLBWO7 (ORCPT ); Mon, 2 Dec 2019 17:14:59 -0500 Received: from [213.220.153.21] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ibty4-0004UI-0Y; Mon, 02 Dec 2019 22:14:56 +0000 Date: Mon, 2 Dec 2019 23:14:55 +0100 From: Christian Brauner To: Adrian Reber Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org Subject: Re: [PATCH v2] clone.2: added clone3() set_tid information Message-ID: <20191202221452.4obywepdevq5dq2w@wittgenstein> References: <20191202142740.59402-1-areber@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191202142740.59402-1-areber@redhat.com> User-Agent: NeoMutt/20180716 Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org On Mon, Dec 02, 2019 at 03:27:40PM +0100, Adrian Reber wrote: > Signed-off-by: Adrian Reber I'm generally fine with all of this, so: Acked-by: Christian Brauner but should this maybe also mention that a pid namespace either already needs to have a pid 1 or if it does not the chosen pid has to be set to 1. In short: "Callers may only choose a pid > 1 in a given pid namespace if an init process (i.e. a process with pid 1) already exists. Otherwise the pid entry for this pid namespace must be 1." or something like this. Christian