Linux-man Archive on lore.kernel.org
 help / color / Atom feed
From: "Li Xinhai" <lixinhai.lxh@gmail.com>
To: "Mike Kravetz" <mike.kravetz@oracle.com>,
	"HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
Cc: n-horiguchi <n-horiguchi@ah.jp.nec.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	akpm <akpm@linux-foundation.org>, mhocko <mhocko@suse.com>,
	linux-man <linux-man@vger.kernel.org>
Subject: Re: [PATCH] mm/mempolicy: support MPOL_MF_STRICT for huge page mapping
Date: Thu, 13 Feb 2020 09:50:45 +0800
Message-ID: <2020021309504334686455@gmail.com> (raw)
In-Reply-To: <e135a4d1-c713-2003-13ea-f8b5695a7745@oracle.com>

On 2020-02-13 at 07:50 Mike Kravetz wrote:
>On 2/11/20 9:25 PM, Li Xinhai wrote:
>> On 2020-02-12 at 11:21 HORIGUCHI NAOYA(堀口 直也) wrote:
>>> On Mon, Feb 10, 2020 at 09:19:48AM -0800, Mike Kravetz wrote:
>>>> On 1/30/20 5:33 PM, Li Xinhai wrote:
>>> ...
>>>>>
>>>>> Signed-off-by: Li Xinhai <lixinhai.lxh@gmail.com>
>>>>> Cc: Michal Hocko <mhocko@suse.com>
>>>>> Cc: Mike Kravetz <mike.kravetz@oracle.com>
>>>>> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>>>>> Cc: linux-man <linux-man@vger.kernel.org>
>>>>
>>>> Hello Naoya,
>>>>
>>>> Do you have any thoughts on this?  In previous discussions you suggested this
>>>> approach of removing the special casing for hugetlb pages.  The code looks
>>>> good to me and patch is fine with commmit message modification.  Just wanted
>>>> to get your opinion.
>>>
>>> Hi Mike, Xinhai,
>>>
>>> The suggested change looks good to me, too.
>>>
>>> Thanks,
>>> Naoya Horiguchi
>>
>> Naoya, thanks for inspecting the change!
>
>Can you please send V2 of patch with an updated commit message.
>
>I would like the section that which lists the impact to "users using
>MPOL_MF_STRICT alone" to say something like this:
>If MPOL_MF_STRICT alone was previously used, hugetlb pages not following the
>memory policy would not cause an EIO error.  After this change, hugetlb pages
>are treated like all other pages.  If  MPOL_MF_STRICT alone is used and hugetlb
>pages do not follow memory policy an EIO error will be returned.
>--
>Mike Kravetz 

I will send a new patch, thanks.

      reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31  1:33 Li Xinhai
2020-02-01  3:28 ` Mike Kravetz
2020-02-01 13:56   ` Li Xinhai
2020-02-10 17:19 ` Mike Kravetz
2020-02-12  3:21   ` HORIGUCHI NAOYA(堀口 直也)
2020-02-12  5:25     ` Li Xinhai
2020-02-12 23:50       ` Mike Kravetz
2020-02-13  1:50         ` Li Xinhai [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2020021309504334686455@gmail.com \
    --to=lixinhai.lxh@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-man@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=mike.kravetz@oracle.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=naoya.horiguchi@nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-man Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-man/0 linux-man/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-man linux-man/ https://lore.kernel.org/linux-man \
		linux-man@vger.kernel.org
	public-inbox-index linux-man

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-man


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git