Re: [PATCH v2] vsock.7: add VMADDR_CID_LOCAL description

[Stefano Garzarella <sgarzare@redhat.com>]

On Mon, Feb 17, 2020 at 01:55:58PM +0000, Jorgen Hansen wrote:
> > From: Stefano Garzarella [mailto:sgarzare@redhat.com]
> > Sent: Friday, February 14, 2020 2:08 PM
> > To: mtk.manpages@gmail.com
> > Cc: Jorgen Hansen <jhansen@vmware.com>; linux-man@vger.kernel.org;
> > Stefan Hajnoczi <stefanha@redhat.com>; Dexuan Cui
> > <decui@microsoft.com>; netdev@vger.kernel.org
> > Subject: [PATCH v2] vsock.7: add VMADDR_CID_LOCAL description
> > 
> > Linux 5.6 added the new well-known VMADDR_CID_LOCAL for local
> > communication.
> > 
> > This patch explains how to use it and remove the legacy
> > VMADDR_CID_RESERVED no longer available.
> > 
> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> > ---
> > v2:
> >     * rephrased "Local communication" description [Stefan]
> >     * added a mention of previous versions that supported
> >       loopback only in the guest [Stefan]
> > ---
> 
> 
> > @@ -222,6 +232,11 @@ are valid.
> >  Support for VMware (VMCI) has been available since Linux 3.9.
> >  KVM (virtio) is supported since Linux 4.8.
> >  Hyper-V is supported since Linux 4.14.
> > +.PP
> > +VMADDR_CID_LOCAL is supported since Linux 5.6.
> > +Local communication in the guest and on the host is available since Linux
> > 5.6.
> > +Previous versions partially supported it only in the guest and only
> > +with some transports (VMCI and virtio).
> 
> Maybe rephrase the last part slightly to something like:
> 
> Previous versions only supported local communication within a guest (not on the host),
> and only with some transports (VMCI and virtio).

I think it is better, I'll send a v3 with this part changed :-)

> 
> Otherwise, looks good to me. Thanks for making this update.
> 
> Reviewed-by: Jorgen Hansen <jhansen@vmware.com>
> 

Thanks,
Stefano