From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D02E0C34034 for ; Tue, 18 Feb 2020 09:59:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1E8121D56 for ; Tue, 18 Feb 2020 09:59:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AIuVuXet" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726327AbgBRJ7r (ORCPT ); Tue, 18 Feb 2020 04:59:47 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:56726 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726363AbgBRJ7r (ORCPT ); Tue, 18 Feb 2020 04:59:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582019985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t8eyLEjJkU8sIdEC16q3jhFcx07tfSetwgj0/6SmRN8=; b=AIuVuXetjKeukSFV7QTiSS9IRpF8MjHRIgqeXH/7GWZ0XZ6F7QZUzIna+qQjZ6GS5VNRl3 87Re5Wm8W+m/CIEDtX4f7l4iQBcwwgHmhJKBxeQgpGAfJ0BwR2DA9ZYDmIQCx4nd1zMqbI 3FEmkwEAK0QEnFg/cwlZuIwnISyjcIw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-406-bd20n_EJMJKERPn4uTitPQ-1; Tue, 18 Feb 2020 04:59:43 -0500 X-MC-Unique: bd20n_EJMJKERPn4uTitPQ-1 Received: by mail-wm1-f71.google.com with SMTP id n17so813188wmk.1 for ; Tue, 18 Feb 2020 01:59:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t8eyLEjJkU8sIdEC16q3jhFcx07tfSetwgj0/6SmRN8=; b=Kf7cSR+OiieHXr1ODEyAGVs4fsBUW2U0FelLX2yjgI8ZK4v3BzktpGvzQqTqTv4qEj /CoF0Fx+QJG8guP/3hbc4IB7PONOydMg5L4AjZeE3xw6JjYttc82abIwBgsap13uKO7A sGdDCgmj7H8xOFfUpNtkku6Ftyg34t+2+bmO0SGxRnUTEsBdgrrwQ/hfkK+OBFuZG64h IQKzBnKXSxYBNaEyh9tRlrmRS61Dj0eusQizIDu5VsF/REp+t/Lu9+WDaiyPJncqlDDi BoWVuCYPY5lX1ALf4/Sc2CJTPRFAA9kJikH9aQnTd3JWiNRE3vEPiZf58H1orSjy7mPg 21XQ== X-Gm-Message-State: APjAAAUFy68/8o7joCKjnd64wsbtJqrAx0nXwuNlj1RCws0SOiCkhuKg T3z62xxy+Ftp4GIYv2UQTwmj1pWs3bQ5PiiFYJAFX1CvwmrCgu57UcjKIUw3ogQQpGBHgCUKxlU ECyDwfJD4jAZsFIAFFdGA X-Received: by 2002:a5d:540f:: with SMTP id g15mr26951311wrv.86.1582019982596; Tue, 18 Feb 2020 01:59:42 -0800 (PST) X-Google-Smtp-Source: APXvYqwePfeSJTNnPPtdjW1ezHXtYzYsxnhdZ7k4RJxR+fpByDcCmLltpiM3YK/9gTUXEXBHAuTVow== X-Received: by 2002:a5d:540f:: with SMTP id g15mr26951293wrv.86.1582019982380; Tue, 18 Feb 2020 01:59:42 -0800 (PST) Received: from steredhat (host209-4-dynamic.27-79-r.retail.telecomitalia.it. [79.27.4.209]) by smtp.gmail.com with ESMTPSA id 21sm2913906wmo.8.2020.02.18.01.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 01:59:41 -0800 (PST) Date: Tue, 18 Feb 2020 10:59:40 +0100 From: Stefano Garzarella To: Stefan Hajnoczi Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, Dexuan Cui , Jorgen Hansen , netdev@vger.kernel.org Subject: Re: [PATCH v3] vsock.7: add VMADDR_CID_LOCAL description Message-ID: <20200218095940.vnyva3lknsfsxxs5@steredhat> References: <20200217173121.159132-1-sgarzare@redhat.com> <20200218095319.GB786556@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200218095319.GB786556@stefanha-x1.localdomain> Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org On Tue, Feb 18, 2020 at 09:53:19AM +0000, Stefan Hajnoczi wrote: > On Mon, Feb 17, 2020 at 06:31:21PM +0100, Stefano Garzarella wrote: > > Linux 5.6 added the new well-known VMADDR_CID_LOCAL for > > local communication. > > > > This patch explains how to use it and remove the legacy > > VMADDR_CID_RESERVED no longer available. > > > > Reviewed-by: Jorgen Hansen > > Signed-off-by: Stefano Garzarella > > --- > > v3: > > * rephrased "Previous versions" part [Jorgen] > > v2: > > * rephrased "Local communication" description [Stefan] > > * added a mention of previous versions that supported > > loopback only in the guest [Stefan] > > --- > > man7/vsock.7 | 19 +++++++++++++++++-- > > 1 file changed, 17 insertions(+), 2 deletions(-) > > > > diff --git a/man7/vsock.7 b/man7/vsock.7 > > index c5ffcf07d..219e3505f 100644 > > --- a/man7/vsock.7 > > +++ b/man7/vsock.7 > > @@ -127,8 +127,8 @@ There are several special addresses: > > means any address for binding; > > .B VMADDR_CID_HYPERVISOR > > (0) is reserved for services built into the hypervisor; > > -.B VMADDR_CID_RESERVED > > -(1) must not be used; > > +.B VMADDR_CID_LOCAL > > +(1) is the well-known address for local communication (loopback); > > .B VMADDR_CID_HOST > > (2) > > is the well-known address of the host. > > @@ -164,6 +164,16 @@ Consider using > > .B VMADDR_CID_ANY > > when binding instead of getting the local CID with > > .BR IOCTL_VM_SOCKETS_GET_LOCAL_CID . > > +.SS Local communication > > +The > > +.B VMADDR_CID_LOCAL > > +(1) directs packets to the same host that generated them. This is useful > > Please see my comment on v2. "The VMADDR_CID_LOCAL (1) directs packets > ..." sounds unnatural. Please drop "The". I received it just now :O but you sent it 4 days ago! Sorry for that! I'll send v4 dropping "The". Thanks, Stefano