From: Jan Kara <jack@suse.cz>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Amir Goldstein <amir73il@gmail.com>,
linux-man <linux-man@vger.kernel.org>,
alexandermv@gmail.com,
Matthew Bobrowski <mbobrowski@mbobrowski.org>,
Jan Kara <jack@suse.cz>
Subject: Re: Kernel bugzilla 198569: fanotify_mark() and FAN_Q_OVERFLOW
Date: Thu, 23 Apr 2020 13:23:52 +0200 [thread overview]
Message-ID: <20200423112352.GM3737@quack2.suse.cz> (raw)
In-Reply-To: <CAKgNAkjshc5bjT2gc7wBU6nkq1BxrcV6mEs6JSuepxFjHtupOA@mail.gmail.com>
Hi Michael!
On Thu 23-04-20 12:36:26, Michael Kerrisk (man-pages) wrote:
> Would you be able to take a look at
> https://bugzilla.kernel.org/show_bug.cgi?id=198569
>
> It relates to some text you added to the fanotify_mark(2) manual page:
>
> FAN_Q_OVERFLOW
> Create an event when an overflow of the event queue occurs.
> The size of the event queue is limited to 16384 entries if
> FAN_UNLIMITED_QUEUE is not set in fanotify_init(2).
>
> This was in the following commit
>
> [[
> commit 5d730f864a6603b090cd1078668cede05d02b8c4
> Author: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Date: Tue Nov 8 23:13:38 2016 +0100
>
> fanotify_mark.2: Mention FAN_Q_OVERFLOW
>
> To receive overflow events it is necessary to set this bit
> in fanotify_mark().
> ]]
>
> As far as I can see, FAN_Q_OVERFLOW (test program, reading the kernel
> source) is only an output flag. But on the other hand, I know you are
> generally careful, so I wonder if something changed (though, at a
> quick glance, I could not see evidence that it has).
Yeah, the manpage is wrong AFAICT. FAN_Q_OVERFLOW is not accepted in the
input mask. It is only output event flag.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-04-23 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 10:36 Kernel bugzilla 198569: fanotify_mark() and FAN_Q_OVERFLOW Michael Kerrisk (man-pages)
2020-04-23 11:23 ` Jan Kara [this message]
2020-04-23 12:19 ` Amir Goldstein
2020-04-23 12:42 ` Michael Kerrisk (man-pages)
2020-04-23 16:42 ` Amir Goldstein
2020-05-15 11:44 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423112352.GM3737@quack2.suse.cz \
--to=jack@suse.cz \
--cc=alexandermv@gmail.com \
--cc=amir73il@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=mbobrowski@mbobrowski.org \
--cc=mtk.manpages@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).