From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F001FC433DF for ; Tue, 9 Jun 2020 10:02:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5E5A207C3 for ; Tue, 9 Jun 2020 10:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591696930; bh=RWvA/egJNR2+v+decCg83OM5wqAsGNKdFJYEQrto1Ko=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jhHPI+w2t9st3pmqNCLhUTjPnXq/wn4v+67VqQg3dPkwxdDWWiYxbVJPn3RAr096X 0WQo7Y3L++3VBJEriIwAqWeOg0qGeCGyO23N/LPTWJUzr0bGWEj+gPrZmZWWZH3Rmb ipRj/AK9JrBjkttKQFm19Tbm85NBeBndjU44P9gQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727012AbgFIKCI (ORCPT ); Tue, 9 Jun 2020 06:02:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:33844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726286AbgFIKCH (ORCPT ); Tue, 9 Jun 2020 06:02:07 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4281207C3; Tue, 9 Jun 2020 10:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591696927; bh=RWvA/egJNR2+v+decCg83OM5wqAsGNKdFJYEQrto1Ko=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XIcI0NI+m3Pjb85pqODykVVez33oYrBxREtDzx9VHafhVBXgYKb5O/aikGDsFfPoc zSseZqs9tVcsqIM64LZUeAvqkvNq6sl1xzQ71o7JmNsjFYS/EccVc6dl0m9A0m1H6F /mwkx4/Ff5TOtMdku7bDdhvbFRbQJqy95rN53zoo= Date: Tue, 9 Jun 2020 11:02:03 +0100 From: Will Deacon To: Dave Martin Cc: Michael Kerrisk , linux-man@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Amit Daniel Kachhap , Mark Rutland Subject: Re: [PATCH v2 5/6] prctl.2: Add PR_PAC_RESET_KEYS (arm64) Message-ID: <20200609100202.GB25362@willie-the-truck> References: <1590614258-24728-1-git-send-email-Dave.Martin@arm.com> <1590614258-24728-6-git-send-email-Dave.Martin@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1590614258-24728-6-git-send-email-Dave.Martin@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org On Wed, May 27, 2020 at 10:17:37PM +0100, Dave Martin wrote: > Add documentation for the PR_PAC_RESET_KEYS ioctl added in Linux > 5.0 for arm64. [...] > +If the arguments are invalid, > +and in particular if > +.I arg2 > +contains set bits that are unrecognized > +or that correspond to a key not available on this platform, > +the call fails with error > +.BR EINVAL . > +.IP > +.B Warning: > +Because the compiler or run-time environment > +may be using some or all of the keys, > +a successful > +.IP > +For more information, see the kernel source file > +.I Documentation/arm64/pointer\-authentication.rst > +.\"commit b693d0b372afb39432e1c49ad7b3454855bc6bed > +(or > +.I Documentation/arm64/pointer\-authentication.txt > +before Linux 5.3). > +.B PR_PAC_RESET_KEYS > +may crash the calling process. I might be misreading this, but this looks like the kernel reference appears mid-sentence. Regardless, I think we should drop the kernel doc reference, as I mentioned on the SVE patches. With that: Acked-by: Will Deacon Will