From: Arkadiusz Drabczyk <arkadiusz@drabczyk.org>
To: Walter Harms <wharms@bfs.de>
Cc: Jakub Wilk <jwilk@jwilk.net>,
Michael Kerrisk <mtk.manpages@gmail.com>,
"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>
Subject: Re: [PATCH] fread.3: Explain that file position is moved after calling fread()/fwrite()
Date: Wed, 17 Jun 2020 19:30:10 +0200 [thread overview]
Message-ID: <20200617173010.vekk35vrslmtdm6r@comp.lan> (raw)
In-Reply-To: <3294b2a2fae14460984e2f3162f7ec35@bfs.de>
On Wed, Jun 17, 2020 at 07:46:25AM +0000, Walter Harms wrote:
> Hi,
> i do not think character is correct it would confuse fseek() it says:
> "The new position, measured in bytes"
ok, v2 already sent.
> to make things more complicated fread has a "size" and returns the
> number of "things" read (" This number equals the number of bytes
> transferred only when size is 1.").
>
> therefor i would suggest to move the success case
> > > +The file position indicator for the stream is advanced by the number
> > > +of characters successfully read or written.
> into the "description section"
ok, let's see what Michael thinks about it.
> And add a word about partial reads into the "return value" section. E.g.
> to make clear what happens when you try to read size=10 while only 4 are left.
>
Isn't it already covered by this fragment:
"If an error occurs, or the end of the file is reached, the return
value is a short item count (or zero)."
?
--
Arkadiusz Drabczyk <arkadiusz@drabczyk.org>
next prev parent reply other threads:[~2020-06-17 17:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 18:26 [PATCH] fread.3: Explain that file position is moved after calling fread()/fwrite() Arkadiusz Drabczyk
2020-06-16 19:00 ` Jakub Wilk
2020-06-16 22:50 ` Arkadiusz Drabczyk
2020-06-17 7:46 ` AW: " Walter Harms
2020-06-17 17:30 ` Arkadiusz Drabczyk [this message]
2020-06-18 8:37 ` Walter Harms
2020-06-18 11:43 ` Arkadiusz Drabczyk
2020-06-18 14:32 ` AW: [PATCH] fread.3: return value Walter Harms
2020-06-18 19:16 ` Arkadiusz Drabczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617173010.vekk35vrslmtdm6r@comp.lan \
--to=arkadiusz@drabczyk.org \
--cc=jwilk@jwilk.net \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).