From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD19C433E0 for ; Sun, 5 Jul 2020 06:55:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B489320BED for ; Sun, 5 Jul 2020 06:55:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593932121; bh=kBMlJanR1enACjjFDoR+XJ5J4RiDm9o74tcWF6LEt+U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=clC0R37IVqO30r8UNiX2Iw/dWCe/q0K8/W2EOEWNw6O/Eq4fST3GB16cfnqiJ4boB 2KjpDNC1Vg+8CPL8tNic9IRmkjLkB3M6Z3QFIb68I/zC63rIHzc+Jd9ntin0P2VdQA UepobHa5cq/SL4izwkWmJ4NRzmjtw6VQyqmx9+lE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726271AbgGEGzS (ORCPT ); Sun, 5 Jul 2020 02:55:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:36596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbgGEGzR (ORCPT ); Sun, 5 Jul 2020 02:55:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD96B20771; Sun, 5 Jul 2020 06:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593932117; bh=kBMlJanR1enACjjFDoR+XJ5J4RiDm9o74tcWF6LEt+U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wb3qZj3CnNZxBoPTvh7p6HB4/tGtTeV11dCiNMA1QWiwXZ2N8IyhuogdQUhlLNNOM NIKiy3C/HWOmNGuLmp3EhGI3R+XOAb15g4SCDejhGdQtisAf+WdoRNr55sAUXGCLNp J57TWI3lwdht4d84rQIRhIZ/Vh79TiUzX71QFP1o= Date: Sun, 5 Jul 2020 08:55:14 +0200 From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: Al Viro , "Michael Kerrisk (man-pages)" , Shuah Khan , Linux API , Linux FS Devel , Linux Kernel Mailing List , linux-man@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" Subject: Re: [PATCH 3/3] selftests: add readfile(2) selftests Message-ID: <20200705065514.GA34145@kroah.com> References: <20200704140250.423345-1-gregkh@linuxfoundation.org> <20200704140250.423345-4-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org On Sat, Jul 04, 2020 at 08:38:26PM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Sat, Jul 4, 2020 at 4:05 PM Greg Kroah-Hartman > wrote: > > Test the functionality of readfile(2) in various ways. > > > > Also provide a simple speed test program to benchmark using readfile() > > instead of using open()/read()/close(). > > > > Signed-off-by: Greg Kroah-Hartman > > Any benchmark results to share? Yes, the readfile_speed.c file will show you that on your machine, I'll post the results of that for two of my machines when I send the next version of this patch series. > > > --- /dev/null > > +++ b/tools/testing/selftests/readfile/readfile.c > > > +static void readfile(const char *filename) > > +{ > > +// int root_fd; > > ??? Ugh, sorry about that, I obviously didn't clean up my last tests from this file, thanks for catching that. I should add more tests to validate the flag handling as well, will do all of that for the next version, thanks for noticing this. greg k-h