From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: linux-man <linux-man@vger.kernel.org>
Subject: Re: [PATCH] man1/*: srcfix: remove superfluous quotes around space-free arguments
Date: Mon, 13 Jul 2020 21:51:30 +0000 [thread overview]
Message-ID: <20200713215130.GA7245@rhi.hi.is> (raw)
In-Reply-To: <CAKgNAkjG6mov6to301WzOznPB1WVAOtXytid5PF7iPk7eb3PGg@mail.gmail.com>
On Mon, Jul 06, 2020 at 11:53:50AM +0200, Michael Kerrisk (man-pages) wrote:
> Bjarni,
>
> On Sun, 5 Jul 2020 at 15:25, Bjarni Ingi Gislason <bjarniig@rhi.hi.is> wrote:
> >
> > Remove quotes around a space-free argument for the single-font macros.
>
> Your commit message doesn't explain why this patch/this series is
> useful. Please explain.
>
Remove the misuse of quotation marks.
####
Know yourself, and the kinds of errors you make. Once you have
found and fixed a bug, make sure that you eliminate other bugs
that might be similar. Think about what happened so you can
avoid making that kid of mistake again.
Brian W. Kernighan, Rob Pike "The Practice of
Programming". Addison-Wesley. 1999. Page 137.
--
Bjarni I. Gislason
prev parent reply other threads:[~2020-07-13 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 13:25 [PATCH] man1/*: srcfix: remove superfluous quotes around space-free arguments Bjarni Ingi Gislason
2020-07-06 9:53 ` Michael Kerrisk (man-pages)
2020-07-13 21:51 ` Bjarni Ingi Gislason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713215130.GA7245@rhi.hi.is \
--to=bjarniig@rhi.hi.is \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).