linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "G. Branden Robinson" <g.branden.robinson@gmail.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: linux-man@vger.kernel.org,
	Alejandro Colomar <alx.manpages@gmail.com>,
	Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [PATCH] termios.3: SPARC architecture has 4 different Bnnn constants
Date: Sun, 1 Aug 2021 21:22:30 +1000	[thread overview]
Message-ID: <20210801112229.w75qb3sggampa757@localhost.localdomain> (raw)
In-Reply-To: <20210731145501.9944-1-pali@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]

Hi, Pali!

At 2021-07-31T16:55:01+0200, Pali Rohár wrote:
> SPARC is special, it does not have Bnnn constants for baud rates above
> 2000000. Instead it defines 4 Bnnn constants with smaller baud rates.
> 
> This difference between SPARC and non-SPARC architectures is present
> in both glibc API (termios.h) and also kernel ioctl API
> (asm/termbits.h).
[...]
>  	B1500000
>  	B2000000
> +.ft P

I see you're following existing termios(3) page practice here, so this
feedback may be more for Alex and Michael than you; it's not a
criticism.

I would discourage the use of the *roff 'ft' request in man pages.
Here, it is redunant because the following PP macro will set the font
style back to roman anyway.

I also discourage the use of tab characters in man page sources (outside
of tbl(1) tables).

I'll show my recommendation in a few lines.

> +.fi
> +.PP
> +On SPARC architecture are additionally supported these constants:
> +.PP
> +.nf
> +.ft B
> +	B76800
> +	B153600
> +	B307200
> +	B614400
> +.ft P
> +.fi

Here's how I'd do that:

.P
On the SPARC architecture,
the following additional constants are supported.
.RS
.TP
.B B76800
.TQ
.B B153600
.TQ
.B B307200
.TQ
.B  B614400
.RE

Why would I do it this way?  I'm trying to keep the size of the language
we ask man page writers to learn as small as possible, and I especially
try to keep the number of *roff requests they have to know as close to
zero as possible.  There are already two ways to change fonts: through
macros and escape sequences.  Personally, I'd like to protect casual man
page writers from having to learn the third.  (And, again, outside of
tbl(1) tables, I'd prefer they not have to know the second [escapes].)

Regards,
Branden

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2021-08-01 11:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 14:55 [PATCH] termios.3: SPARC architecture has 4 different Bnnn constants Pali Rohár
2021-08-01 10:55 ` Alejandro Colomar (man-pages)
2021-08-01 11:22 ` G. Branden Robinson [this message]
2021-08-01 12:13   ` Alejandro Colomar (man-pages)
2021-08-04  6:14     ` G. Branden Robinson
2021-09-10 22:17       ` Alejandro Colomar (man-pages)
2021-08-01 11:35 ` [PATCH v2] " Pali Rohár
2021-08-01 12:16   ` Alejandro Colomar (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210801112229.w75qb3sggampa757@localhost.localdomain \
    --to=g.branden.robinson@gmail.com \
    --cc=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=pali@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).