Linux-man Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] man3/*: srcfix: remove superfluous quotes around space-free arguments
@ 2020-07-05 13:40 Bjarni Ingi Gislason
  2020-07-06  4:31 ` Jakub Wilk
  0 siblings, 1 reply; 4+ messages in thread
From: Bjarni Ingi Gislason @ 2020-07-05 13:40 UTC (permalink / raw)
  To: mtk.manpages; +Cc: linux-man

  Remove quotes around a space-free argument for the single-font macros.

  Fix a font issue in "strfmon.3".

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 man3/getline.3        | 14 +++++++-------
 man3/isalpha.3        |  2 +-
 man3/posix_memalign.3 |  2 +-
 man3/realpath.3       |  4 ++--
 man3/setlocale.3      |  2 +-
 man3/strcoll.3        |  4 ++--
 man3/strfmon.3        |  4 ++--
 7 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/man3/getline.3 b/man3/getline.3
index 0dc3a562d..37800c649 100644
--- a/man3/getline.3
+++ b/man3/getline.3
@@ -64,7 +64,7 @@ The buffer is null-terminated and includes the newline character, if
 one was found.
 .PP
 If
-.I "*lineptr"
+.I *lineptr
 is set to NULL and
 .I *n
 is set 0 before the call, then
@@ -77,26 +77,26 @@ failed.
 .PP
 Alternatively, before calling
 .BR getline (),
-.I "*lineptr"
+.I *lineptr
 can contain a pointer to a
 .BR malloc (3)\-allocated
 buffer
-.I "*n"
+.I *n
 bytes in size.
 If the buffer is not large enough to hold the line,
 .BR getline ()
 resizes it with
 .BR realloc (3),
 updating
-.I "*lineptr"
+.I *lineptr
 and
-.I "*n"
+.I *n
 as necessary.
 .PP
 In either case, on a successful call,
-.I "*lineptr"
+.I *lineptr
 and
-.I "*n"
+.I *n
 will be updated to reflect the buffer address and allocated size respectively.
 .PP
 .BR getdelim ()
diff --git a/man3/isalpha.3 b/man3/isalpha.3
index a620c6bf0..02fc03f4d 100644
--- a/man3/isalpha.3
+++ b/man3/isalpha.3
@@ -349,7 +349,7 @@ locale.
 For example,
 .BR isupper ()
 will not recognize an A-umlaut (\(:A) as an uppercase letter in the default
-.B "C"
+.B C
 locale.
 .SH SEE ALSO
 .BR iswalnum (3),
diff --git a/man3/posix_memalign.3 b/man3/posix_memalign.3
index 74955528b..ae375cc8c 100644
--- a/man3/posix_memalign.3
+++ b/man3/posix_memalign.3
@@ -251,7 +251,7 @@ if suitable feature test macros are defined (see above).
 On many systems there are alignment restrictions, for example, on buffers
 used for direct block device I/O.
 POSIX specifies the
-.I "pathconf(path,_PC_REC_XFER_ALIGN)"
+.I pathconf(path,_PC_REC_XFER_ALIGN)
 call that tells what alignment is needed.
 Now one can use
 .BR posix_memalign ()
diff --git a/man3/realpath.3 b/man3/realpath.3
index de43eccf3..44a8bd516 100644
--- a/man3/realpath.3
+++ b/man3/realpath.3
@@ -66,9 +66,9 @@ bytes,
 in the buffer pointed to by
 .IR resolved_path .
 The resulting path will have no symbolic link,
-.I "/./"
+.I /./
 or
-.I "/../"
+.I /../
 components.
 .PP
 If
diff --git a/man3/setlocale.3 b/man3/setlocale.3
index a913bc663..a9ea2e922 100644
--- a/man3/setlocale.3
+++ b/man3/setlocale.3
@@ -129,7 +129,7 @@ is an ISO 639 language code,
 is an ISO 3166 country code, and
 .I codeset
 is a character set or encoding identifier like
-.B "ISO-8859-1"
+.B ISO-8859-1
 or
 .BR "UTF-8" .
 For a list of all supported locales, try "locale \-a" (see
diff --git a/man3/strcoll.3 b/man3/strcoll.3
index 292a798f2..a870f49cd 100644
--- a/man3/strcoll.3
+++ b/man3/strcoll.3
@@ -83,9 +83,9 @@ T}	Thread safety	MT-Safe locale
 POSIX.1-2001, POSIX.1-2008, C89, C99, SVr4, 4.3BSD.
 .SH NOTES
 In the
-.I "POSIX"
+.I POSIX
 or
-.I "C"
+.I C
 locales
 .BR strcoll ()
 is equivalent to
diff --git a/man3/strfmon.3 b/man3/strfmon.3
index 924eb8187..a90c88187 100644
--- a/man3/strfmon.3
+++ b/man3/strfmon.3
@@ -29,10 +29,10 @@ strfmon, strfmon_l \- convert monetary value to a string
 .B #include <monetary.h>
 .PP
 .BI "ssize_t strfmon(char *" s ", size_t " max ", const char *" format ,
-.B "...);"
+.IB  ... );
 .PP
 .BI "ssize_t strfmon_l(char *" s ", size_t " max ", locale_t " locale ,
-.B const char *" format , "...);"
+.BI "const char *" format , ... );
 .fi
 .SH DESCRIPTION
 The
-- 
2.27.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] man3/*: srcfix: remove superfluous quotes around space-free arguments
  2020-07-05 13:40 [PATCH] man3/*: srcfix: remove superfluous quotes around space-free arguments Bjarni Ingi Gislason
@ 2020-07-06  4:31 ` Jakub Wilk
  2020-07-06  9:20   ` Michael Kerrisk (man-pages)
  2020-07-06 11:51   ` Michael Kerrisk (man-pages)
  0 siblings, 2 replies; 4+ messages in thread
From: Jakub Wilk @ 2020-07-06  4:31 UTC (permalink / raw)
  To: Bjarni Ingi Gislason; +Cc: Michael Kerrisk, linux-man

THe strfmon(3) change is unrelated to the other changes, and should have 
been in a separate patch.

* Bjarni Ingi Gislason <bjarniig@rhi.hi.is>, 2020-07-05, 13:40:
>--- a/man3/strfmon.3
>+++ b/man3/strfmon.3
>@@ -29,10 +29,10 @@ strfmon, strfmon_l \- convert monetary value to a string
> .B #include <monetary.h>
> .PP
> .BI "ssize_t strfmon(char *" s ", size_t " max ", const char *" format ,
>-.B "...);"
>+.IB  ... );

For variadic function the convention seems to be to format "..." in 
bold; see scanf(3), printf(3), wprintf(3) and execv(3) man pages. This 
makes sense, because unlike argument names, "..." appear literally in 
the function prototypes.

>-.B const char *" format , "...);"
>+.BI "const char *" format , ... );

Ditto. So this line should be:

.BI "const char *" format ", ...);"

-- 
Jakub Wilk

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] man3/*: srcfix: remove superfluous quotes around space-free arguments
  2020-07-06  4:31 ` Jakub Wilk
@ 2020-07-06  9:20   ` Michael Kerrisk (man-pages)
  2020-07-06 11:51   ` Michael Kerrisk (man-pages)
  1 sibling, 0 replies; 4+ messages in thread
From: Michael Kerrisk (man-pages) @ 2020-07-06  9:20 UTC (permalink / raw)
  To: Jakub Wilk, Bjarni Ingi Gislason; +Cc: mtk.manpages, linux-man

On 7/6/20 6:31 AM, Jakub Wilk wrote:
> THe strfmon(3) change is unrelated to the other changes, and should have 
> been in a separate patch.

Exactly. 

Bjarni, it's bets if you don't mix unrelated changes tinto the same patch.

Thanks,

Michael

> * Bjarni Ingi Gislason <bjarniig@rhi.hi.is>, 2020-07-05, 13:40:
>> --- a/man3/strfmon.3
>> +++ b/man3/strfmon.3
>> @@ -29,10 +29,10 @@ strfmon, strfmon_l \- convert monetary value to a string
>> .B #include <monetary.h>
>> .PP
>> .BI "ssize_t strfmon(char *" s ", size_t " max ", const char *" format ,
>> -.B "...);"
>> +.IB  ... );
> 
> For variadic function the convention seems to be to format "..." in 
> bold; see scanf(3), printf(3), wprintf(3) and execv(3) man pages. This 
> makes sense, because unlike argument names, "..." appear literally in 
> the function prototypes.
> 
>> -.B const char *" format , "...);"
>> +.BI "const char *" format , ... );
> 
> Ditto. So this line should be:
> 
> .BI "const char *" format ", ...);"
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] man3/*: srcfix: remove superfluous quotes around space-free arguments
  2020-07-06  4:31 ` Jakub Wilk
  2020-07-06  9:20   ` Michael Kerrisk (man-pages)
@ 2020-07-06 11:51   ` Michael Kerrisk (man-pages)
  1 sibling, 0 replies; 4+ messages in thread
From: Michael Kerrisk (man-pages) @ 2020-07-06 11:51 UTC (permalink / raw)
  To: Jakub Wilk, Bjarni Ingi Gislason; +Cc: mtk.manpages, linux-man

On 7/6/20 6:31 AM, Jakub Wilk wrote:
> THe strfmon(3) change is unrelated to the other changes, and should have 
> been in a separate patch.
> 
> * Bjarni Ingi Gislason <bjarniig@rhi.hi.is>, 2020-07-05, 13:40:
>> --- a/man3/strfmon.3
>> +++ b/man3/strfmon.3
>> @@ -29,10 +29,10 @@ strfmon, strfmon_l \- convert monetary value to a string
>> .B #include <monetary.h>
>> .PP
>> .BI "ssize_t strfmon(char *" s ", size_t " max ", const char *" format ,
>> -.B "...);"
>> +.IB  ... );
> 
> For variadic function the convention seems to be to format "..." in 
> bold; see scanf(3), printf(3), wprintf(3) and execv(3) man pages. This 
> makes sense, because unlike argument names, "..." appear literally in 
> the function prototypes.
> 
>> -.B const char *" format , "...);"
>> +.BI "const char *" format , ... );
> 
> Ditto. So this line should be:
> 
> .BI "const char *" format ", ...);"

Thanks, Jakub. Fixed.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-05 13:40 [PATCH] man3/*: srcfix: remove superfluous quotes around space-free arguments Bjarni Ingi Gislason
2020-07-06  4:31 ` Jakub Wilk
2020-07-06  9:20   ` Michael Kerrisk (man-pages)
2020-07-06 11:51   ` Michael Kerrisk (man-pages)

Linux-man Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-man/0 linux-man/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-man linux-man/ https://lore.kernel.org/linux-man \
		linux-man@vger.kernel.org
	public-inbox-index linux-man

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-man


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git