From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4977CC433DF for ; Thu, 25 Jun 2020 23:38:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25E4C2084D for ; Thu, 25 Jun 2020 23:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593128282; bh=+rJ274nAaeCSx6ZoT5xGykTxK4T6ZZZLmSREOV4fy3c=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=tRx4wDrutgntdR4QPcpB+Q6ia6Dgq1T3/RSpvSGAXJPzeqDNw5AX5Ibubo4HHE02n WYP4WLsBa38bhO69cLoAVwMZtAClW+rgDMnIR7r6Pbk3RvvP3qjR8gJ+BpSBsufPn7 ZNpZw3RXArLxpeEQz42sOqbhgOWFv1iGBpH68Ptc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726028AbgFYXiB (ORCPT ); Thu, 25 Jun 2020 19:38:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:42288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbgFYXiB (ORCPT ); Thu, 25 Jun 2020 19:38:01 -0400 Received: from tleilax.poochiereds.net (68-20-15-154.lightspeed.rlghnc.sbcglobal.net [68.20.15.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7CC6F2084D; Thu, 25 Jun 2020 23:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593128281; bh=+rJ274nAaeCSx6ZoT5xGykTxK4T6ZZZLmSREOV4fy3c=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=WBHS2UDCBY4nW2fcA+mei/bKA2n3sGoAUUuQKTcg1/hXLX8ehiuvhEh+rwLQjCfSV PfzCJYLvMRE9+qrLRxavGS5VGaTCy08qJIkxi9ys1tMtQR/U0mEuDLmjdedKFBtaZe 2mGa+uUzYJ727wiaPFzAw/A4O3DX8AoYLTJv0i9o= Message-ID: <36f0f92ef664b4b62d6b2d06961a548d4dc5527b.camel@kernel.org> Subject: Re: [PATCH][man-pages] sync.2: syncfs() now returns errors if writeback fails From: Jeff Layton To: "Michael Kerrisk (man-pages)" , Eric Biggers Cc: linux-man@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 25 Jun 2020 19:37:59 -0400 In-Reply-To: <54c5ef29-0f12-5f55-8f54-73b20f56925e@gmail.com> References: <20200610103347.14395-1-jlayton@kernel.org> <20200610155013.GA1339@sol.localdomain> <54c5ef29-0f12-5f55-8f54-73b20f56925e@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.3 (3.36.3-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org On Thu, 2020-06-25 at 11:45 +0200, Michael Kerrisk (man-pages) wrote: > Hi Jeff, > > Any progress with v2 of this patch? > > Thanks, > > Michael > Just sent it. Thanks for the reminder! > > On 6/10/20 11:19 PM, Jeff Layton wrote: > > On Wed, 2020-06-10 at 08:50 -0700, Eric Biggers wrote: > > > On Wed, Jun 10, 2020 at 06:33:47AM -0400, Jeff Layton wrote: > > > > A patch has been merged for v5.8 that changes how syncfs() reports > > > > errors. Change the sync() manpage accordingly. > > > > > > > > Signed-off-by: Jeff Layton > > > > --- > > > > man2/sync.2 | 24 +++++++++++++++++++++++- > > > > 1 file changed, 23 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/man2/sync.2 b/man2/sync.2 > > > > index 7198f3311b05..27e04cff5845 100644 > > > > --- a/man2/sync.2 > > > > +++ b/man2/sync.2 > > > > @@ -86,11 +86,26 @@ to indicate the error. > > > > is always successful. > > > > .PP > > > > .BR syncfs () > > > > -can fail for at least the following reason: > > > > +can fail for at least the following reasons: > > > > .TP > > > > .B EBADF > > > > .I fd > > > > is not a valid file descriptor. > > > > +.TP > > > > +.B EIO > > > > +An error occurred during synchronization. > > > > +This error may relate to data written to any file on the filesystem, or on > > > > +metadata related to the filesytem itself. > > > > +.TP > > > > +.B ENOSPC > > > > +Disk space was exhausted while synchronizing. > > > > +.TP > > > > +.BR ENOSPC ", " EDQUOT > > > > +Data was written to a files on NFS or another filesystem which does not > > > > +allocate space at the time of a > > > > +.BR write (2) > > > > +system call, and some previous write failed due to insufficient > > > > +storage space. > > > > .SH VERSIONS > > > > .BR syncfs () > > > > first appeared in Linux 2.6.39; > > > > @@ -121,6 +136,13 @@ or > > > > .BR syncfs () > > > > provide the same guarantees as fsync called on every file in > > > > the system or filesystem respectively. > > > > +.PP > > > > +In mainline kernel versions prior to 5.8, > > > > +.\" commit 735e4ae5ba28c886d249ad04d3c8cc097dad6336 > > > > +.BR syncfs () > > > > +will only fail with EBADF when passed a bad file descriptor. In 5.8 > > > > +and later kernels, it will also report an error if one or more inodes failed > > > > +to be written back since the last syncfs call. > > > > > > The sentence "In mainline kernel versions prior to 5.8, syncfs() will only fail > > > with EBADF when passed a bad file descriptor" is ambiguous. It could mean that > > > EBADF can now mean other things too. > > > > > > Maybe write: "In mainline kernel versions prior to 5.8, syncfs() will only fail > > > when passed a bad file descriptor (EBADF)." > > > > > > - Eric > > > > Good point. Fixed in my tree using your verbiage. I'll send out a v2 > > patch once I give others a chance to comment. > > > > Thanks! > > > > -- Jeff Layton