From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Manfred Spraul <manfred@colorfullife.com>,
Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: mtk.manpages@gmail.com, "Alejandro Colomar (mailing lists,
readonly)" <alx.mailinglists@gmail.com>,
Davidlohr Bueso <dbueso@suse.de>,
linux-man@vger.kernel.org, Joe Lawrence <joe.lawrence@redhat.com>,
Robert Kettler <robert.kettler@outlook.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH] semctl.2: Correct SEM_STAT_ANY description
Date: Wed, 30 Dec 2020 16:51:37 +0100 [thread overview]
Message-ID: <38525dfc-e909-8fc2-ffc7-f38f7c280166@gmail.com> (raw)
In-Reply-To: <d588d638-5abe-eb2a-e336-3e6fe31ad525@colorfullife.com>
On 12/30/20 3:33 PM, Manfred Spraul wrote:
> Hi Michael,
>
> On 12/30/20 2:35 PM, Michael Kerrisk (man-pages) wrote:
>> Hi Manfred,
>>
>> On 12/30/20 12:20 PM, Manfred Spraul wrote:
>>> On 12/30/20 3:03 AM, Yang Xu wrote:
>>>> Hi Manfred
>>>>> Hi,
>>>>>
>>>>>
>>>>> On 12/22/20 12:55 PM, Alejandro Colomar (mailing lists; readonly) wrote:
>>>>>> Hi Yang,
>>>>>>
>>>>>> It looks good to me.
>>>>>> I'll add a few people that might want to comment.
>>>>> The code returns a semid_ds structure, and if I take strace as reference
>>>>> implementation, then user space expects a semid_ds as well.
>>>>> https://github.com/strace/strace/commit/8f0870a780bfd8cd9a91c3b7ad05baccda10bc84
>>>>>
>>>>>
>>>>>
>>>>> In addition, the current page is self-inconsistent: seminfo doesn't
>>>>> contain sem_perm.
>>>> semctl manpage doesn't say seminfo contain sem_perm. Or, I miss something?
>>> The current man page says that SEM_STAT_ANY returns a seminfo structure,
>>> without checking sem_perm.
>>>
>>> This is self-inconsistent: struct seminfo contains global
>>> (per-namespace) information, sem_perm.mode is a per-array information.
>>>
>>> I.e.: It is clear that the man page needs to be updated, and not the code.
>> After reading this thread, I'm not quite clear. Do you mean some
>> additional change is required after Xang Yu's patch?
>
> Sorry for the confusion:
>
> No further changes are required.
>
> (I have crosschecked shmctl, msgctl, actual code, and strace as user
> space example: After Xang Yu's patch is applied, everything is consistent)
Thanks, Manfred! It's clear to me now.
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2020-12-30 15:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 5:55 [PATCH] semctl.2: Correct SEM_STAT_ANY description Yang Xu
2020-12-22 11:55 ` Alejandro Colomar (mailing lists; readonly)
2020-12-29 5:09 ` Yang Xu
2020-12-29 10:38 ` Manfred Spraul
2020-12-29 11:12 ` Alejandro Colomar (mailing lists; readonly)
2020-12-30 2:03 ` Yang Xu
2020-12-30 11:20 ` Manfred Spraul
2020-12-30 13:35 ` Michael Kerrisk (man-pages)
2020-12-30 14:33 ` Manfred Spraul
2020-12-30 15:51 ` Michael Kerrisk (man-pages) [this message]
2021-01-07 6:54 ` Yang Xu
2020-12-29 11:03 Alejandro Colomar
2021-01-07 13:05 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38525dfc-e909-8fc2-ffc7-f38f7c280166@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=alx.mailinglists@gmail.com \
--cc=dbueso@suse.de \
--cc=ebiederm@xmission.com \
--cc=joe.lawrence@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-man@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mhocko@kernel.org \
--cc=robert.kettler@outlook.com \
--cc=xuyang2018.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).