From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: mtk.manpages@gmail.com,
Elvira Khabirova <lineprinter@altlinux.org>,
linux-man@vger.kernel.org
Subject: Re: [PATCH] ptrace.2: document struct ptrace_syscall_info
Date: Fri, 13 Sep 2019 20:48:21 +0200 [thread overview]
Message-ID: <4bcd01d4-fd94-1802-d600-08eb55c649ab@gmail.com> (raw)
In-Reply-To: <20190913154013.GA23393@altlinux.org>
On 9/13/19 5:40 PM, Dmitry V. Levin wrote:
> On Thu, Sep 12, 2019 at 11:17:52AM +0200, Michael Kerrisk (man-pages) wrote:
>> Hello Dmitry,
>>
>> On 9/11/19 7:38 PM, Dmitry V. Levin wrote:
>>> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
>>> ---
>>> man2/ptrace.2 | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++-
>>> 1 file changed, 50 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/man2/ptrace.2 b/man2/ptrace.2
>>> index ff897bb19..b030247e6 100644
>>> --- a/man2/ptrace.2
>>> +++ b/man2/ptrace.2
>>> @@ -1026,7 +1026,56 @@ If the size of the data to be written by the kernel exceeds the size
>>> specified by the
>>> .I addr
>>> argument, the output data is truncated.
>>> -.\" FIXME Document 'struct ptrace_syscall_info'
>>> +.IP
>>> +The
>>> +.I ptrace_syscall_info
>>> +structure contains the following fields:
>>> +.IP
>>> +.in
>>> +.EX
>>> +struct ptrace_syscall_info {
>>> + __u8 op; /* PTRACE_SYSCALL_INFO_* value
>>> + describing the kind
>>> + of system call stop,
>>> + see <linux/ptrace.h> */
>>> + __u32 arch; /* AUDIT_ARCH_* value,
>>> + see seccomp(2) */
>>> + __u64 instruction_pointer; /* CPU instruction pointer */
>>> + __u64 stack_pointer; /* CPU stack pointer */
>>> + union {
>>> + struct {
>>> + __u64 nr; /* System call number */
>>> + __u64 args[6]; /* System call arguments */
>>> + } entry; /* Information specific to
>>> + system call entry stops */
>>> + struct {
>>> + __s64 rval; /* System call return value */
>>> + __u8 is_error; /* System call error flag */
>>> + } exit; /* Information specific to
>>> + system call exit stops */
>>> + struct {
>>> + __u64 nr; /* System call number */
>>> + __u64 args[6]; /* System call arguments */
>>> + __u32 ret_data; /* The SECCOMP_RET_DATA portion
>>> + of SECCOMP_RET_TRACE return
>>> + value */
>>> + } seccomp; /* Information specific to
>>> + PTRACE_EVENT_SECCOMP stops */
>>> + };
>>> +};
>>> +.EE
>>> +.in
>>> +.IP
>>> +.IR op ,
>>> +.IR arch ,
>>> +.IR instruction_pointer ,
>>> +and
>>> +.I stack_pointer
>>> +fields are defined for all kinds of ptrace system call stops.
>>> +The rest of the structure is a union, one should read only those fields
>>> +that are meaningful for the kind of system call stop specified by the
>>> +.IR op
>>> +field.
>>> .\"
>>> .SS Death under ptrace
>>> When a (possibly multithreaded) process receives a killing signal
>>
>> Thanks. I've applied, and done some light editing.
>>
>> I also added some pieces. Could you please take a look at commits
>> f04534d22c69 [1] and 227a3682312 [2] let me know if they are okay.
>
> Thanks. The only thing that needs correction is
> "Boolean: is rval != 0?" comment about is_error field.
>
> In fact, is_error is a boolean that tells whether rval field
> contains a non-error return value (e.g. file descriptor) or
> an error value (e.g. -ERRORCODE).
Thanks for checking this Dmitry. I see what I missed before.
I've now changed the text here to be:
__u8 is_error; /* System call error flag;
Boolean: does rval contain
an error value (\-ERRCODE) or
a nonerror return value? */
Thanks,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2019-09-13 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 12:38 [PATCH] ptrace.2: document PTRACE_GET_SYSCALL_INFO Dmitry V. Levin
2019-09-10 10:51 ` Michael Kerrisk (man-pages)
2019-09-11 17:38 ` [PATCH] ptrace.2: document struct ptrace_syscall_info Dmitry V. Levin
2019-09-12 9:17 ` Michael Kerrisk (man-pages)
2019-09-13 15:40 ` Dmitry V. Levin
2019-09-13 18:48 ` Michael Kerrisk (man-pages) [this message]
2019-09-13 19:37 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bcd01d4-fd94-1802-d600-08eb55c649ab@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=ldv@altlinux.org \
--cc=lineprinter@altlinux.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).