From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A05E3C49ED7 for ; Fri, 20 Sep 2019 14:37:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DDC420B7C for ; Fri, 20 Sep 2019 14:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568990235; bh=5HAhAebBZoeewPB0vmMb1b3bjdyfMmVXggFjC4H9i48=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=u+1Jl9mgJeVAMbifEs1DqUJqQXUsNBEJN8wzJd3xk3mfWll9ptP9q3yoOBnMXVOya +CHsa+4przIhTEfSP78GPUfKNlWa1jWrKpjQTSXerhFvWYvFREXmOfzF4HYrq+BDg8 GNyFtNtw3x/LasKYLmz/+iDc7YPydPRkMuOhMMrs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392402AbfITOge (ORCPT ); Fri, 20 Sep 2019 10:36:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:48854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392393AbfITOgd (ORCPT ); Fri, 20 Sep 2019 10:36:33 -0400 Received: from localhost (c-67-180-165-146.hsd1.ca.comcast.net [67.180.165.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CF1A20B7C; Fri, 20 Sep 2019 14:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568990193; bh=5HAhAebBZoeewPB0vmMb1b3bjdyfMmVXggFjC4H9i48=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZH3tHXmLqO1lr6eSQBTC5QZcb9FXINbLuqz8clSFgWnVtlctVx5JKUjsW0+VJyHI1 bYGXSDBPWSfI9s82VhPTyZXFhH7dSOWySHn2tpO7sjBTBSzyrCmpymV1Ilm32TdM5d DRrYOso2oNPhSw5kzSwB6dis4b2dy1roXi3MG7CY= From: Andy Lutomirski To: Theodore Tso Cc: LKML , Linux API , Kees Cook , "Jason A. Donenfeld" , "Ahmed S. Darwish" , Lennart Poettering , "Eric W. Biederman" , "Alexander E. Patrakov" , Michael Kerrisk , Willy Tarreau , Matthew Garrett , Ext4 Developers List , linux-man , Andy Lutomirski Subject: [PATCH v2 1/7] random: Don't wake crng_init_wait when crng_init == 1 Date: Fri, 20 Sep 2019 07:36:23 -0700 Message-Id: <7d54ef8512b06baf396f12584f7f48a9558ecd0f.1568990048.git.luto@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org crng_init_wait is only used to wayt for crng_init to be set to 2, so there's no point to waking it when crng_init is set to 1. Remove the unnecessary wake_up_interruptible() call. Signed-off-by: Andy Lutomirski --- drivers/char/random.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/char/random.c b/drivers/char/random.c index 5d5ea4ce1442..d152612e08fc 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -946,7 +946,6 @@ static int crng_fast_load(const char *cp, size_t len) if (crng_init_cnt >= CRNG_INIT_CNT_THRESH) { invalidate_batched_entropy(); crng_init = 1; - wake_up_interruptible(&crng_init_wait); pr_notice("random: fast init done\n"); } return 1; -- 2.21.0