linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: Nadav Amit <nadav.amit@gmail.com>, linux-man@vger.kernel.org
Cc: "Michael Kerrisk )" <mtk.manpages@gmail.com>,
	Peter Xu <peterx@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Nadav Amit <namit@vmware.com>
Subject: Re: [PATCH 2/2] userfaultfd.2: fix userfaultfd_demo output
Date: Mon, 14 Mar 2022 13:28:15 +0100	[thread overview]
Message-ID: <82553a60-e387-53d2-db66-493bace8c9e2@gmail.com> (raw)
In-Reply-To: <20220307184852.20351-2-namit@vmware.com>

Hi Nadav,

On 3/7/22 19:48, Nadav Amit wrote:
> From: Nadav Amit <namit@vmware.com>
> 
> A bug in the kernel caused in recent version a different output (masked
> offset). Update the output of the demo program accordingly.

Please add to the commit message some info about the bug,
especially some links to LKML discussions and the patch set that fixes it.

Thanks,

Alex

> 
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
>  man2/userfaultfd.2 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/man2/userfaultfd.2 b/man2/userfaultfd.2
> index cee7c01d2..779ff8817 100644
> --- a/man2/userfaultfd.2
> +++ b/man2/userfaultfd.2
> @@ -648,7 +648,7 @@ Address returned by mmap() = 0x7fd30106c000
>  
>  fault_handler_thread():
>      poll() returns: nready = 1; POLLIN = 1; POLLERR = 0
> -    UFFD_EVENT_PAGEFAULT event: flags = 0; address = 7fd30106c00f
> +    UFFD_EVENT_PAGEFAULT event: flags = 0; address = 7fd30106c000
>          (uffdio_copy.copy returned 4096)
>  Read address 0x7fd30106c00f in main(): A
>  Read address 0x7fd30106c40f in main(): A
> @@ -657,7 +657,7 @@ Read address 0x7fd30106cc0f in main(): A
>  
>  fault_handler_thread():
>      poll() returns: nready = 1; POLLIN = 1; POLLERR = 0
> -    UFFD_EVENT_PAGEFAULT event: flags = 0; address = 7fd30106d00f
> +    UFFD_EVENT_PAGEFAULT event: flags = 0; address = 7fd30106d000
>          (uffdio_copy.copy returned 4096)
>  Read address 0x7fd30106d00f in main(): B
>  Read address 0x7fd30106d40f in main(): B
> @@ -666,7 +666,7 @@ Read address 0x7fd30106dc0f in main(): B
>  
>  fault_handler_thread():
>      poll() returns: nready = 1; POLLIN = 1; POLLERR = 0
> -    UFFD_EVENT_PAGEFAULT event: flags = 0; address = 7fd30106e00f
> +    UFFD_EVENT_PAGEFAULT event: flags = 0; address = 7fd30106e000
>          (uffdio_copy.copy returned 4096)
>  Read address 0x7fd30106e00f in main(): C
>  Read address 0x7fd30106e40f in main(): C

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

  reply	other threads:[~2022-03-14 12:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 18:48 [PATCH 1/2] ioctl_userfaultfd.2: add UFFD_FEATURE_EXACT_ADDRESS Nadav Amit
2022-03-07 18:48 ` [PATCH 2/2] userfaultfd.2: fix userfaultfd_demo output Nadav Amit
2022-03-14 12:28   ` Alejandro Colomar (man-pages) [this message]
2023-04-08 13:34   ` Alejandro Colomar
2023-04-10 19:57     ` Nadav Amit
2023-06-02  0:18       ` Alejandro Colomar
2022-03-14 12:23 ` [PATCH 1/2] ioctl_userfaultfd.2: add UFFD_FEATURE_EXACT_ADDRESS Alejandro Colomar (man-pages)
2023-03-30 22:52   ` Alejandro Colomar
2023-04-04 16:01     ` Nadav Amit
2023-04-08 13:32       ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82553a60-e387-53d2-db66-493bace8c9e2@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=david@redhat.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=nadav.amit@gmail.com \
    --cc=namit@vmware.com \
    --cc=peterx@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).