Re: openat2.h location (openat2.2)

Re: openat2.h location (openat2.2)

[Michael Kerrisk (man-pages)]

[CC += Aleksa, linux-man@]

Hello Petr,

I'm bringing Aleksa, the creator of the system call, into CC.

Aleksa, the issue is that the header file (<openat2.h>) documented in
the manual page that you sent does not (yet) exist (and the bug
reporter therefore suggests that the manual page should say to include
<linux/openat2.h>.

I'm guessing that there is (or was) a plan to add a <openat2.h> header
file to glibc. What is the status?

With best regards,

Michael

On Tue, 30 Jun 2020 at 16:17, pgajdos <pgajdos@suse.cz> wrote:
>
> Hello Michael,
>
> https://bugzilla.suse.com/show_bug.cgi?id=1173382
>
> reporter proposes
>
> Index: man-pages-5.07/man2/openat2.2
> ===================================================================
> --- man-pages-5.07.orig/man2/openat2.2  2020-06-09 14:45:54.000000000 +0200
> +++ man-pages-5.07/man2/openat2.2       2020-06-30 16:07:09.655352702 +0200
> @@ -29,7 +29,7 @@ openat2 \- open and possibly create a fi
>  .B #include <sys/types.h>
>  .B #include <sys/stat.h>
>  .B #include <fcntl.h>
> -.B #include <openat2.h>
> +.B #include <linux/openat2.h>
>  .PP
>  .BI "int openat2(int " dirfd ", const char *" pathname ,
>  .BI "            struct open_how *" how ", size_t " size ");
>
> Thanks,
> Petr
>
> --
> Have a lot of fun!



--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Re: openat2.h location (openat2.2)

[Aleksa Sarai]

[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]

On 2020-06-30, Michael Kerrisk (man-pages) <mtk.manpages@gmail.com> wrote:
> [CC += Aleksa, linux-man@]
> 
> Hello Petr,
> 
> I'm bringing Aleksa, the creator of the system call, into CC.
> 
> Aleksa, the issue is that the header file (<openat2.h>) documented in
> the manual page that you sent does not (yet) exist (and the bug
> reporter therefore suggests that the manual page should say to include
> <linux/openat2.h>.
> 
> I'm guessing that there is (or was) a plan to add a <openat2.h> header
> file to glibc. What is the status?

Yes, Florian asked me to put the openat2 definitions into a separate
header (openat2.h) so that it could be just copied by glibc rather than
having to do any more hacks around <fcntl.h>.

I guess those plans haven't come to fruition yet? I'm fine with telling
users to use <linux/openat2.h> in the meantime.

> With best regards,
> 
> Michael
> 
> On Tue, 30 Jun 2020 at 16:17, pgajdos <pgajdos@suse.cz> wrote:
> >
> > Hello Michael,
> >
> > https://bugzilla.suse.com/show_bug.cgi?id=1173382
> >
> > reporter proposes
> >
> > Index: man-pages-5.07/man2/openat2.2
> > ===================================================================
> > --- man-pages-5.07.orig/man2/openat2.2  2020-06-09 14:45:54.000000000 +0200
> > +++ man-pages-5.07/man2/openat2.2       2020-06-30 16:07:09.655352702 +0200
> > @@ -29,7 +29,7 @@ openat2 \- open and possibly create a fi
> >  .B #include <sys/types.h>
> >  .B #include <sys/stat.h>
> >  .B #include <fcntl.h>
> > -.B #include <openat2.h>
> > +.B #include <linux/openat2.h>
> >  .PP
> >  .BI "int openat2(int " dirfd ", const char *" pathname ,
> >  .BI "            struct open_how *" how ", size_t " size ");
> >
> > Thanks,
> > Petr
> >
> > --
> > Have a lot of fun!

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: openat2.h location (openat2.2)

[Florian Weimer]

* Aleksa Sarai:

> On 2020-06-30, Michael Kerrisk (man-pages) <mtk.manpages@gmail.com> wrote:
>> [CC += Aleksa, linux-man@]
>> 
>> Hello Petr,
>> 
>> I'm bringing Aleksa, the creator of the system call, into CC.
>> 
>> Aleksa, the issue is that the header file (<openat2.h>) documented in
>> the manual page that you sent does not (yet) exist (and the bug
>> reporter therefore suggests that the manual page should say to include
>> <linux/openat2.h>.
>> 
>> I'm guessing that there is (or was) a plan to add a <openat2.h> header
>> file to glibc. What is the status?
>
> Yes, Florian asked me to put the openat2 definitions into a separate
> header (openat2.h) so that it could be just copied by glibc rather than
> having to do any more hacks around <fcntl.h>.

We still need to document the original *at functions. 8-( That's a
precondition for adding openat2 (which should come with its own
documentation right from the start).

<https://sourceware.org/pipermail/libc-alpha/2020-May/113545.html>

> I guess those plans haven't come to fruition yet? I'm fine with telling
> users to use <linux/openat2.h> in the meantime.

If we include <linux/openat2.h> from the glibc header, the transition
should be unproblematic because there won't be any multi-definition
errors.

Thanks,
Florian