From: ebiederm@xmission.com (Eric W. Biederman)
To: Jann Horn <jannh@google.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Theodore Tso <tytso@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Ahmed S. Darwish" <darwish.07@gmail.com>,
Lennart Poettering <mzxreary@0pointer.de>,
"Alexander E. Patrakov" <patrakov@gmail.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Willy Tarreau <w@1wt.eu>, Matthew Garrett <mjg59@srcf.ucam.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-man <linux-man@vger.kernel.org>
Subject: Re: [PATCH v2 7/7] random: Remove kernel.random.read_wakeup_threshold
Date: Wed, 25 Sep 2019 20:09:26 -0500 [thread overview]
Message-ID: <87sgoj2795.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <CAG48ez2tnJzLNCgAqCC+AOKuLGBSvBRi2_HZ97bEJ0zP1kWLHg@mail.gmail.com> (Jann Horn's message of "Tue, 24 Sep 2019 22:30:55 +0200")
Jann Horn <jannh@google.com> writes:
> On Fri, Sep 20, 2019 at 4:37 PM Andy Lutomirski <luto@kernel.org> wrote:
>> It has no effect any more, so remove it. We can revert this if
>> there is some user code that expects to be able to set this sysctl.
>>
>> Signed-off-by: Andy Lutomirski <luto@kernel.org>
>> ---
>> drivers/char/random.c | 18 +-----------------
>> 1 file changed, 1 insertion(+), 17 deletions(-)
>>
>> diff --git a/drivers/char/random.c b/drivers/char/random.c
> [...]
>> - {
>> - .procname = "read_wakeup_threshold",
>
> There's a line in bin_random_table in kernel/sysctl_binary.c that
> refers to this sysctl, that should probably also be deleted?
I think it should be safe to leave in kernel/sysctl_binary.c
This reminds me. I think we may finally be at a point where we can
remove practically all of kernel/sysctl_binary.c
I need to double check but last I looked no distro enables
COINFIG_SYSCTL_SYSCALL anymore. Ubunutu was the last distro I know of
that enabled it, and I think it has been a year or more since Ubuntu
disabled CONFIG_SYSCTL_SYSCALL.
Eric
next prev parent reply other threads:[~2019-09-26 1:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 14:36 [PATCH v2 0/7] Rework random blocking Andy Lutomirski
2019-09-20 14:36 ` [PATCH v2 1/7] random: Don't wake crng_init_wait when crng_init == 1 Andy Lutomirski
2019-09-20 14:36 ` [PATCH v2 2/7] random: Add GRND_INSECURE to return best-effort non-cryptographic bytes Andy Lutomirski
2019-09-20 14:36 ` [PATCH v2 3/7] random: Ignore GRND_RANDOM in getentropy(2) Andy Lutomirski
2019-09-20 14:36 ` [PATCH v2 4/7] random: Make /dev/random be almost like /dev/urandom Andy Lutomirski
2019-09-20 14:36 ` [PATCH v2 5/7] random: Remove the blocking pool Andy Lutomirski
2019-09-20 14:36 ` [PATCH v2 6/7] random: Delete code to pull data into pools Andy Lutomirski
2019-09-20 14:36 ` [PATCH v2 7/7] random: Remove kernel.random.read_wakeup_threshold Andy Lutomirski
2019-09-24 20:30 ` Jann Horn
2019-09-26 1:09 ` Eric W. Biederman [this message]
2019-09-20 14:46 ` [PATCH v2 0/7] Rework random blocking Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgoj2795.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=Jason@zx2c4.com \
--cc=darwish.07@gmail.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=mtk.manpages@gmail.com \
--cc=mzxreary@0pointer.de \
--cc=patrakov@gmail.com \
--cc=tytso@google.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).