From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 05/18] Add io_uring IO interface Date: Tue, 29 Jan 2019 09:19:54 -0700 Message-ID: <9a66c000-62f3-7567-7919-31e61e28defa@kernel.dk> References: <20190123153536.7081-1-axboe@kernel.dk> <20190123153536.7081-6-axboe@kernel.dk> <20190128145700.GA9795@lst.de> <2729ab43-b2bf-44b0-d41d-dbb495ddffbf@kernel.dk> <20190129063043.GC2996@lst.de> <4b12d149-99f7-0b2e-0c3f-9b477ce48520@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: owner-linux-aio@kvack.org To: Arnd Bergmann Cc: Christoph Hellwig , Linux FS-devel Mailing List , linux-aio , linux-block , Jeff Moyer , Avi Kivity , Linux API , linux-man , Deepa Dinamani List-Id: linux-man@vger.kernel.org On 1/29/19 9:18 AM, Arnd Bergmann wrote: > On Tue, Jan 29, 2019 at 4:20 PM Jens Axboe wrote: >> On 1/29/19 4:58 AM, Arnd Bergmann wrote: >>> On Tue, Jan 29, 2019 at 7:30 AM Christoph Hellwig wrote: >>>>> On Mon, Jan 28, 2019 at 11:25:12AM -0700, Jens Axboe wrote: >>>>>> Especially with poll support now in the series, don't we need a Ñ•igmask >>>>>> argument similar to pselect/ppoll/io_pgetevents now to deal with signal >>>>>> blocking during waiting for events? >>>>> >>>>> Is there any way to avoid passing in the sigset_t size? If it's just a >>>>> 32-bit/64-bit thing, surely the in_compat_syscall() could cover it? Or >>>>> are there other cases that need to be catered to? >>>> >>>> As far as I can tell we never look at it, never looked at it and don't >>>> have any plans to look at it anytime soon. But when I tried to omit >>>> it for io_pgetevents I got stong pushback and thus had to add the >>>> crazy double indirection calling convention. >> >> That's good info. I am currently using set_user_sigmask() for it. >> I'd really like to avoid having to pass in a sigset_t size for the >> system call, however. > > I really wouldn't do it, given that all other signal handling interfaces > are prepared for longer signal masks. You /could/ probably extend > it later with a flags bit to signify a longer mask instead of using > the entire register to hold the bit length, it just seems really > inconsistent with all other system calls. Damnit! OK, I'll keep what I currently have then. -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org