From: David Hildenbrand <david@redhat.com>
To: Yang Shi <yang.shi@linux.alibaba.com>,
mhocko@suse.com, mtk.manpages@gmail.com,
akpm@linux-foundation.org
Cc: linux-man@vger.kernel.org, linux-api@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] move_pages.2: Returning positive value is a new error case
Date: Fri, 31 Jan 2020 11:49:19 +0100 [thread overview]
Message-ID: <9aac5bff-3a18-ec5f-5aa0-82c38d367590@redhat.com> (raw)
In-Reply-To: <1580322632-93332-1-git-send-email-yang.shi@linux.alibaba.com>
On 29.01.20 19:30, Yang Shi wrote:
> Since commit a49bd4d71637 ("mm, numa: rework do_pages_move"),
> the semantic of move_pages() has changed to return the number of
> non-migrated pages if they were result of a non-fatal reasons (usually a
> busy page). This was an unintentional change that hasn't been noticed
> except for LTP tests which checked for the documented behavior.
>
> There are two ways to go around this change. We can even get back to the
> original behavior and return -EAGAIN whenever migrate_pages is not able
> to migrate pages due to non-fatal reasons. Another option would be to
> simply continue with the changed semantic and extend move_pages
> documentation to clarify that -errno is returned on an invalid input or
> when migration simply cannot succeed (e.g. -ENOMEM, -EBUSY) or the
> number of pages that couldn't have been migrated due to ephemeral
> reasons (e.g. page is pinned or locked for other reasons).
>
> We decided to keep the second option in kernel because this behavior is in
> place for some time without anybody complaining and possibly new users
> depending on it. Also it allows to have a slightly easier error handling
> as the caller knows that it is worth to retry when err > 0.
>
> Update man pages to reflect the new semantic.
>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Michael Kerrisk <mtk.manpages@gmail.com>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> ---
> man2/move_pages.2 | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/man2/move_pages.2 b/man2/move_pages.2
> index 1bf1053..c6cf3f8 100644
> --- a/man2/move_pages.2
> +++ b/man2/move_pages.2
> @@ -164,9 +164,13 @@ returns zero.
> .\" do the right thing?
> On error, it returns \-1, and sets
> .I errno
> -to indicate the error.
> +to indicate the error. Or positive value to report the number of
> +non-migrated pages.
"If a positive value is returned, it's the number of non-migrated pages".
> .SH ERRORS
> .TP
> +.B Positive value
> +The number of non-migrated pages if they were result of a non-fatal
> +reasons since version 4.17.
s/result/the result/ ?
s/a reasons/reasons/ ?
s/since version 4.17/(since 4.17)/ ?
> .B E2BIG
> Too many pages to move.
> Since Linux 2.6.29,
>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-01-31 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 18:30 [PATCH] move_pages.2: Returning positive value is a new error case Yang Shi
2020-01-29 18:58 ` Michal Hocko
2020-01-29 19:05 ` Yang Shi
2020-01-29 19:11 ` Michal Hocko
2020-01-31 10:49 ` David Hildenbrand [this message]
2020-01-31 19:40 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aac5bff-3a18-ec5f-5aa0-82c38d367590@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mtk.manpages@gmail.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).