From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 885B2C4320D for ; Tue, 24 Sep 2019 20:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CEBD21655 for ; Tue, 24 Sep 2019 20:31:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hGoESwSU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2410503AbfIXUbX (ORCPT ); Tue, 24 Sep 2019 16:31:23 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:35664 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2410527AbfIXUbW (ORCPT ); Tue, 24 Sep 2019 16:31:22 -0400 Received: by mail-oi1-f194.google.com with SMTP id x3so2896669oig.2 for ; Tue, 24 Sep 2019 13:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gnH1hIumhjs1U65zhqlbJaNofnYNZHTIm6gh8mVIcKU=; b=hGoESwSUjxVfPEzR+jVxVH90xU0VZFNySAY+QJr5Ig7OAEMxPiAhSXT0T5BVxUmAON VeaFnceD+Y/2frLM2/SFPSS80AfXO3O2CqmUUKXKLeUurtYf7ndNfA3zU2UpsaJVFyPo tprbtU/jvGMX+1vWgsJRahVfj6VrP51gYcXGbyCHpHI4qkIFkxHULr/BbaJ5ej1FKdAy DQRIc3RPA5rzPl+p49+FX4vqtsuuw3f3qZ3u+WfAzgJlG8DVL8SfewF48oKDKpEbdUxg pkoaPhcDUFMLh2oY7vayI6feQ9fDc9r+hkRU4u7hZIfnRfYypAxa5W5SR+o+S/ARfowd 3Rcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gnH1hIumhjs1U65zhqlbJaNofnYNZHTIm6gh8mVIcKU=; b=HC0GovPbCRw8WyZY78Uhpj1iq90KJUs/XPcsa18ps+KaMC10A+CC5atKWE2ABJDk82 dIO0PTFKQ8rlZ4ngoes/MYTfrUGM+MCXcXitTOl+7WHENGWF4sMEG0ZaZ6WPg+sNX++J F4HoJsWb3dnDKoJ4+S0/6GRC2OO9ka0BNSR/bbf2trYrZtCJ3B9Wbbw3BHQBdOIphqDC qF1sukc/vPhDhzZEicdS8aPz3Em9FoVJdp27O8bXk/HMQ7puEylhQBgMyauJ8ceIqcLL tBf+tsbAnd2yBvZcynRT59JytjTRfQBqGbb291yv9IyJCgdxLrzJJc3jP0PRC6DtMxIf n5LA== X-Gm-Message-State: APjAAAWkpVQNujLBGxi+FYD5oH39kIpZ1tCe19Hfg+huj41lesxeJiuX GBocAo7lXzudyDUTPrkpK7g1NSBNYEmheBYOzpLDyA== X-Google-Smtp-Source: APXvYqxniVpvMNA+bj/yUEKpmVq/ao8OQjFhfGsHKuXQQKykILeLG60EsYREEBp+78hGREeG2Q58F/qZGtcpArkKizM= X-Received: by 2002:aca:b506:: with SMTP id e6mr1794758oif.39.1569357081429; Tue, 24 Sep 2019 13:31:21 -0700 (PDT) MIME-Version: 1.0 References: <66b16acf2953fc033abc9641b9cf43d23e75a8e9.1568990048.git.luto@kernel.org> In-Reply-To: <66b16acf2953fc033abc9641b9cf43d23e75a8e9.1568990048.git.luto@kernel.org> From: Jann Horn Date: Tue, 24 Sep 2019 22:30:55 +0200 Message-ID: Subject: Re: [PATCH v2 7/7] random: Remove kernel.random.read_wakeup_threshold To: Andy Lutomirski Cc: Theodore Tso , LKML , Linux API , Kees Cook , "Jason A. Donenfeld" , "Ahmed S. Darwish" , Lennart Poettering , "Eric W. Biederman" , "Alexander E. Patrakov" , Michael Kerrisk , Willy Tarreau , Matthew Garrett , Ext4 Developers List , linux-man Content-Type: text/plain; charset="UTF-8" Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org On Fri, Sep 20, 2019 at 4:37 PM Andy Lutomirski wrote: > It has no effect any more, so remove it. We can revert this if > there is some user code that expects to be able to set this sysctl. > > Signed-off-by: Andy Lutomirski > --- > drivers/char/random.c | 18 +----------------- > 1 file changed, 1 insertion(+), 17 deletions(-) > > diff --git a/drivers/char/random.c b/drivers/char/random.c [...] > - { > - .procname = "read_wakeup_threshold", There's a line in bin_random_table in kernel/sysctl_binary.c that refers to this sysctl, that should probably also be deleted?