From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Walter Harms <wharms@bfs.de>
Cc: Florin Blanaru <florin.blanaru96@gmail.com>,
linux-man <linux-man@vger.kernel.org>,
Adam Borowski <kilobyte@angband.pl>
Subject: Re: Quick fix for syscall man page
Date: Mon, 9 Sep 2019 14:42:16 +0200 [thread overview]
Message-ID: <CAKgNAkhx2GxfW85C8Ef7ZYmohpYLpV2vX_N-PDrsturmmgb2oA@mail.gmail.com> (raw)
In-Reply-To: <5D761692.9090905@bfs.de>
Hello Walter,
On Mon, 9 Sep 2019 at 11:08, walter harms <wharms@bfs.de> wrote:
>
>
>
> Am 09.09.2019 10:52, schrieb Michael Kerrisk (man-pages):
> > [Adding Adam Borowski in CC, since he wrote the riscv text back at the
> > start of 2018, andand he may have a comment.]
> >
> > On Thu, 5 Sep 2019 at 18:35, Florin Blanaru <florin.blanaru96@gmail.com> wrote:
> >>
> >> http://man7.org/linux/man-pages/man2/syscall.2.html
> >>
> >> In the first table, for the riscv Arch/ABI, the instruction should be
> >> ecall instead of scall.
> >>
> >> According the official manual, the instruction has been renamed.
> >> https://content.riscv.org/wp-content/uploads/2017/05/riscv-spec-v2.2.pdf
> >>
> >> "The SCALL and SBREAK instructions have been renamed to ECALL and
> >> EBREAK, re-spectively. Their encoding and functionality are
> >> unchanged."
> >
>
> Maybe it would be helpful to add a "footnote" that this is a rename only.
> Otherwise people may get confused.
Yes, perhaps that would be helpful. I updated the patch to be as below.
Thanks!
Michael
diff --git a/man2/syscall.2 b/man2/syscall.2
index 77e6bccdd..53118c297 100644
--- a/man2/syscall.2
+++ b/man2/syscall.2
@@ -196,7 +196,7 @@ mips syscall v0 v0 v1 a3 1, 6
nios2 trap r2 r2 - r7
parisc ble 0x100(%sr2, %r0) r20 r28 - -
powerpc sc r0 r3 - r0 1
-riscv scall a7 a0 a1 -
+riscv ecall a7 a0 a1 - 7
s390 svc 0 r1 r2 r3 - 3
s390x svc 0 r1 r2 r3 - 3
superh trap #0x17 r3 r0 r1 - 4, 6
@@ -298,6 +298,11 @@ in the system call interface, even if it is
defined in the System V ABI.
.in
.ft P
\}
+.IP [7]
+On riscv, the
+.I ecall
+instruction was formerly named
+.IR scall .
.PP
The second table shows the registers used to pass the system call arguments.
.if t \{\
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2019-09-09 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 16:34 Quick fix for syscall man page Florin Blanaru
2019-09-09 8:52 ` Michael Kerrisk (man-pages)
2019-09-09 9:08 ` walter harms
2019-09-09 12:42 ` Michael Kerrisk (man-pages) [this message]
2019-09-09 18:27 ` Adam Borowski
2019-09-10 8:26 ` Michael Kerrisk (man-pages)
2019-09-10 10:45 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKgNAkhx2GxfW85C8Ef7ZYmohpYLpV2vX_N-PDrsturmmgb2oA@mail.gmail.com \
--to=mtk.manpages@gmail.com \
--cc=florin.blanaru96@gmail.com \
--cc=kilobyte@angband.pl \
--cc=linux-man@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).