From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90065C432C0 for ; Tue, 19 Nov 2019 11:48:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 651FC20885 for ; Tue, 19 Nov 2019 11:48:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BRemhWVF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727511AbfKSLsn (ORCPT ); Tue, 19 Nov 2019 06:48:43 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:42799 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726351AbfKSLsn (ORCPT ); Tue, 19 Nov 2019 06:48:43 -0500 Received: by mail-ed1-f68.google.com with SMTP id m13so16782073edv.9 for ; Tue, 19 Nov 2019 03:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=XY5VZYHOr0/zLOO5Z+XWD2AFc0THVY+EIBAeHhTFG24=; b=BRemhWVFzpWhGMg9ssWpEDvz9YNMixZv/J8S+ibCz9rYcAg5wvovdVNB803OOS1/sp ZjT0yKOgABIqVZ63I/yuECbbV/GxqRt4mMIasbZIdFAnEprVGjQaMxF9Rz/pfdgQqGZJ S51wz4197VgGEcbN2Yza581EPa2f7P7uZHECP/LdHWn7N4AZWZ8x9d/v/GflJhGELoe9 yLAWiCznvvseNuwr5P+QjeG9noDF/TGrPYo/ALfkCl8zXjaX8ZTvlB7BZud66JmgJCJn YBGvH1QIgxpmGCD1fMmNEFme/Oxx81EVCWvg9yEBkknCrAtr/cDuvHzyj2rsXtsyOyaG D+BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=XY5VZYHOr0/zLOO5Z+XWD2AFc0THVY+EIBAeHhTFG24=; b=sxK9w/zrLVHXVjBc1j9/lffTGENirW5RLjM4u7WJIsV5lp/ERweTt8dPk2k2WluNU0 ZirDedjkf2NM10DEL/TLfQjqkNHnUvoYOpYu4KLlmFMOm6+4P57lA2Srl01Nfuxd7NsI f8riYYjDoMUOLnJXJbJIxzWTV34rmDrqsgW4rweFxnyBfOrJkq2RdZVBCyUxNUa9wEV7 G3BQoKqcrqs09mwjcQThwto+GvF6H7p59dztVvun9DiLseVpbMrbhuJ/IqXadV13b8Yl /DvZJimSina0lcupLHyMVt5CmVcJP8oW4jleW5Pecl6z/rV/qu+qN2xsXmXV5na0rteb OSyg== X-Gm-Message-State: APjAAAUjUlJvH0cl9ppgoMeLU/fepCBVzwlbaKImeDPlqdr96z4fxmOA EWUaiBmZMjDDpv80yLSrMI+ikWGsUX8HEdw6VbhJJUsV X-Google-Smtp-Source: APXvYqxwka3Dp8UHw6roz89rCletbDhZj8VQRsl0ATjyXf2QjtgDO8VH/tB5dh63WvQ7qiux1NkiV2UePVn3q+XBdBI= X-Received: by 2002:a17:906:8319:: with SMTP id j25mr33299363ejx.170.1574164121118; Tue, 19 Nov 2019 03:48:41 -0800 (PST) MIME-Version: 1.0 References: <87bltgdb00.fsf@mid.deneb.enyo.de> In-Reply-To: <87bltgdb00.fsf@mid.deneb.enyo.de> Reply-To: mtk.manpages@gmail.com From: "Michael Kerrisk (man-pages)" Date: Tue, 19 Nov 2019 12:48:30 +0100 Message-ID: Subject: Re: [PATCH] bpf-helpers.7: Remove duplicated words and add missing articles To: Florian Weimer Cc: linux-man , Quentin Monnet , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org Hi Florian, This page is autogenerated from text in the kernel source. See man-pages commit 53666f6c30451cde [[ Generating the page itself is a two-step process. First, the documentation is extracted from include/uapi/linux/bpf.h, and converted to a RST (reStructuredText-formatted) page, with the relevant script from Linux sources: $ ./scripts/bpf_helpers_doc.py > /tmp/bpf-helpers.rst The second step consists in turning the RST document into the final man page, with rst2man: $ rst2man /tmp/bpf-helpers.rst > bpf-helpers.7 ]] I've just refreshed this manual page as per the above steps, and the typos you note below are still present. You'd need to craft a patch against the kernel source file include/uapi/linux/bpf.h. Or perhaps Quentin or Daniel (who I think roughly own this file) might make the changes directly. Thanks, Michael On Tue, 12 Nov 2019 at 22:45, Florian Weimer wrote: > > Signed-off-by: Florian Weimer > --- > man7/bpf-helpers.7 | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/man7/bpf-helpers.7 b/man7/bpf-helpers.7 > index 6f07f476e..0ac569c1d 100644 > --- a/man7/bpf-helpers.7 > +++ b/man7/bpf-helpers.7 > @@ -1546,8 +1546,8 @@ Where t_enabled is the time enabled for event and t_running is > the time running for event since last normalization. The > enabled and running times are accumulated since the perf event > open. To achieve scaling factor between two invocations of an > -eBPF program, users can can use CPU id as the key (which is > -typical for perf array usage model) to remember the previous > +eBPF program, users can use the CPU id as the key (which is > +typical for the perf array usage model) to remember the previous > value and do the calculation inside the eBPF program. > .TP > .B Return > @@ -1605,7 +1605,7 @@ the return value of the probed function, and to set it to \fIrc\fP\&. > The first argument is the context \fIregs\fP on which the kprobe > works. > .sp > -This helper works by setting setting the PC (program counter) > +This helper works by setting the PC (program counter) > to an override function which is run in place of the original > probed function. This means the probed function is not run at > all. The replacement function just returns with the required > -- > 2.20.1 > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/