From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0B43C433E0 for ; Sun, 5 Jul 2020 11:24:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB88D2073E for ; Sun, 5 Jul 2020 11:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726799AbgGELYU (ORCPT ); Sun, 5 Jul 2020 07:24:20 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:36334 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726454AbgGELYU (ORCPT ); Sun, 5 Jul 2020 07:24:20 -0400 Received: by mail-ot1-f68.google.com with SMTP id 72so29692648otc.3; Sun, 05 Jul 2020 04:24:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HxueHSFVe1aY1SfjGzwH+5B9lPYaHFHBKRhJv4KWryk=; b=nCWku/S1kkUEpt6XI/Vm3rAtbrZw+4HlOldVW6VCujhqHnbBLmpH3U77+YCRkbH278 hCZ4MjxAEKlFbrBrOnaaQ5oXD9ZNM7C6534DOdvRP/jNl3EqozlXI16+pOfQGuHZugVN SIKe+ZNfrJ+zII4aGBcu6plOEPj2BWIKxCKRrmoDKRmqMxwmCUTjoqjdiLKTtRIgFnbw yUWseV2Dr2QtoQHuOTi4Y9ahC8t5M1Y/niPPwFFRLzQmLYMzZ1syuPnFFspmz39exobB 58nedWlJIBgTfs77UQATqydRDWtw4X+H54k3hDNq4ce86DiCfONvURO3IXtnJQSiT/t4 z5jA== X-Gm-Message-State: AOAM530acvyzhicDfyPktu6HuKAVRB+MBQtSEwv9VN5PpmJbqjNq6TvF a31I9U9pBnOpQSJcrH7ZjUUHbIFJ2yX6EvjNdBI= X-Google-Smtp-Source: ABdhPJy/L7XGfZyHJsgsdBjJrruteRX+ylOfRwuY53cd1zwMZL1gYan2bpX+i/exMvPsL3QjXVT37Dd41cZNOTtRE/o= X-Received: by 2002:a05:6830:1451:: with SMTP id w17mr25172162otp.250.1593948259060; Sun, 05 Jul 2020 04:24:19 -0700 (PDT) MIME-Version: 1.0 References: <20200704140250.423345-1-gregkh@linuxfoundation.org> <20200704140250.423345-4-gregkh@linuxfoundation.org> <20200705065514.GA34145@kroah.com> In-Reply-To: <20200705065514.GA34145@kroah.com> From: Geert Uytterhoeven Date: Sun, 5 Jul 2020 13:24:07 +0200 Message-ID: Subject: Re: [PATCH 3/3] selftests: add readfile(2) selftests To: Greg Kroah-Hartman Cc: Al Viro , "Michael Kerrisk (man-pages)" , Shuah Khan , Linux API , Linux FS Devel , Linux Kernel Mailing List , linux-man@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org Hi Greg, On Sun, Jul 5, 2020 at 8:55 AM Greg Kroah-Hartman wrote: > On Sat, Jul 04, 2020 at 08:38:26PM +0200, Geert Uytterhoeven wrote: > > On Sat, Jul 4, 2020 at 4:05 PM Greg Kroah-Hartman > > wrote: > > > Test the functionality of readfile(2) in various ways. > > > > > > Also provide a simple speed test program to benchmark using readfile() > > > instead of using open()/read()/close(). > > > > > > Signed-off-by: Greg Kroah-Hartman > > > --- /dev/null > > > +++ b/tools/testing/selftests/readfile/readfile.c > > > > > +static void readfile(const char *filename) > > > +{ > > > +// int root_fd; > > > > ??? > > Ugh, sorry about that, I obviously didn't clean up my last tests from > this file, thanks for catching that. Reading about seq_file behavior, did the commented-out test for "/sys/kernel/debug/usb/devices" work? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds