From: "Hayes, Bill" <bill.hayes@hpe.com>
To: "ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>
Cc: "mtk.manpages@gmail.com" <mtk.manpages@gmail.com>,
"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>
Subject: Should lseek manpage reference OCFS2 versus OCFS?
Date: Tue, 22 Oct 2019 22:30:09 +0000 [thread overview]
Message-ID: <CS1PR8401MB1031A3AE826CBEE15E95F60D8B680@CS1PR8401MB1031.NAMPRD84.PROD.OUTLOOK.COM> (raw)
On the lseek man page (http://man7.org/linux/man-pages/man2/lseek.2.html), in its description of SEEK_DATA and SEEK_HOLE it says that: The SEEK_HOLE and SEEK_DATA operations are supported for the following filesystems:
* Btrfs (since Linux 3.1)
* OCFS (since Linux 3.2)
* XFS (since Linux 3.5)
* ext4 (since Linux 3.8)
* tmpfs(5) (since Linux 3.8)
* NFS (since Linux 3.18)
* FUSE (since Linux 4.5)
I think that the reference to OCFS on the manpage should actually be to the OCFS2 file system.
I think the 'OCFS (since Linux 3.2)' manpage reference is referring to this commit to OCFS2:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/fs?id=93862d5e1ab875664c6cc95254fc365028a48bb1
This OCFS2 commit was included as part of the Linux 3.2-rc4 drop (https://lwn.net/Articles/470337/).
Can someone with more experience with OCFS and OCFS2 confirm that the manpage should be changed to OCFS2 instead of OCFS?
Bill
commit 93862d5e1ab875664c6cc95254fc365028a48bb1
Author: Sunil Mushran <sunil.mushran@oracle.com>
Date: Mon Jul 25 14:58:15 2011 -0700
ocfs2: Implement llseek()
SEEK_HOLE sets the file pointer to the start of either a hole or an unwritten
(preallocated) extent, that is greater than or equal to the supplied offset.
SEEK_DATA sets the file pointer to the start of an allocated extent (not
unwritten) that is greater than or equal to the supplied offset.
If the supplied offset is on a desired region, then the file pointer is set
to it. Offsets greater than or equal to the file size return -ENXIO.
Unwritten (preallocated) extents are considered holes because the file system
treats reads to such regions in the same way as it does to holes.
Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
next reply other threads:[~2019-10-22 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 22:30 Hayes, Bill [this message]
2019-10-23 7:17 ` Should lseek manpage reference OCFS2 versus OCFS? walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR8401MB1031A3AE826CBEE15E95F60D8B680@CS1PR8401MB1031.NAMPRD84.PROD.OUTLOOK.COM \
--to=bill.hayes@hpe.com \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).