From: Alejandro Colomar <alx@kernel.org>
To: Don Brace <don.brace@microchip.com>
Cc: linux-man@vger.kernel.org
Subject: Re: [PATCH v9 2/3] smartpqi: remove sysfs entry for version
Date: Wed, 25 Oct 2023 01:10:03 +0200 [thread overview]
Message-ID: <ZThOy783p2lCDQcF@debian> (raw)
In-Reply-To: <20231024220153.36748-3-don.brace@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]
Hi Don,
On Tue, Oct 24, 2023 at 05:01:52PM -0500, Don Brace wrote:
> Remove the "version" sysfs entry. This entry was changed into
> two sysfs entries: driver_version and firmware_version.
>
> Add HISTORY section.
> Enumerate old sysfs entries replaced by newer entries.
>
> Signed-off-by: Don Brace <don.brace@microchip.com>
> Suggested-by: Alejandro Colomar <alx@kernel.org>
> Signed-off-by: Don Brace <don.brace@microchip.com>
> ---
> man4/smartpqi.4 | 25 +++++++------------------
> 1 file changed, 7 insertions(+), 18 deletions(-)
>
> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
> index ea8bd5e2d612..0cb018d01fc5 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -145,24 +145,6 @@ changes, so the user should not normally have to write to this file.
> Doing so may be useful when hot-plugging devices such as tape drives or
> entire storage boxes containing pre-configured logical volumes.
> .TP
> -.IR /sys/class/scsi_host/host * /version
> -The host
> -.I version
> -attribute is a read-only attribute.
> -This attribute contains the driver version and the controller firmware
> -version.
> -.IP
> -For example:
> -.IP
> -.in +4n
> -.EX
> -$ \c
> -.B cat /sys/class/scsi_host/host1/version
> -driver: 1.1.2\-126
> -firmware: 1.29\-112
> -.EE
> -.in
> -.TP
> .IR /sys/class/scsi_host/host * /lockup_action
> The host
> .I lockup_action
> @@ -393,6 +375,13 @@ refer to the User Guide for the controller,
> which can be found by searching for the specific controller at
> .UR https://www.microchip.com/design-centers/storage
> .UE .
> +.SH HISTORY
> +.I /sys/class/scsi_host/host*/version
> +was replaced by two sysfs entries:
> +.IP
> +.I /sys/class/scsi_host/host*/driver_version
> +.IP
> +.I /sys/class/scsi_host/host*/firmware_version
Should we maybe specify when this changed? Do you think that would be
relevant to programmers?
Thanks,
Alex
> .SH SEE ALSO
> .BR cciss (4),
> .BR hpsa (4),
> --
> 2.42.0.482.g2e8e77cbac
>
--
<https://www.alejandro-colomar.es/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-10-24 23:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 22:01 [PATCH v9 0/3] smartpqi man page updates Don Brace
2023-10-24 22:01 ` [PATCH v9 1/3] smartpqi: update host attribute descriptions Don Brace
2023-10-24 23:04 ` Alejandro Colomar
2023-10-24 22:01 ` [PATCH v9 2/3] smartpqi: remove sysfs entry for version Don Brace
2023-10-24 23:10 ` Alejandro Colomar [this message]
2023-10-24 22:01 ` [PATCH v9 3/3] smartpqi: add device attributes Don Brace
2023-10-24 23:18 ` Alejandro Colomar
2023-10-24 23:23 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZThOy783p2lCDQcF@debian \
--to=alx@kernel.org \
--cc=don.brace@microchip.com \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).