linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <colomar.6.4.3@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org,
	libc-alpha@sourceware.org
Subject: Re: [PATCH 0/6] Add loff_t & off64_t, and update off_t
Date: Tue, 27 Oct 2020 17:35:07 +0100	[thread overview]
Message-ID: <b0b5a70c-7a45-d73b-4ddc-0fcc7e26bfae@gmail.com> (raw)
In-Reply-To: <20201027162114.47521-1-colomar.6.4.3@gmail.com>

Hi Alex,

On 10/27/20 5:21 PM, Alejandro Colomar wrote:
> Hi M,
> 
> I added some details to off_t,
> and added loff_t and off64_t to the page.
> 
> Maybe you would like to improve some wording on these patches.
> There are a few lines that don't convince me fully...
> 
> I might start working on fixing the messy *lseek* pages.

See my other mail. On reflection, I think that those pages are
in a "good enough" state.

And, you raced off a bit too quick for me. I definitely
think loff_t should not be added. And I'm pretty doubtful
about adding off64_t as well.

I've applied patch 2 in this series.

Thanks,

Michael


> Alejandro Colomar (6):
>   system_data_types.7: off_t: SEE ALSO: Uncomment loff_t, off64_t
>   system_data_types.7: off_t: Add note about _FILE_OFFSET_BITS
>   system_data_types.7: Add 'loff_t'
>   loff_t.3: New link to system_data_types(7)
>   system_data_types.7: Add 'off64_t'
>   off64_t.3: New link to system_data_types(7)
> 
>  man3/loff_t.3            |  1 +
>  man3/off64_t.3           |  1 +
>  man7/system_data_types.7 | 76 ++++++++++++++++++++++++++++++++++++----
>  3 files changed, 71 insertions(+), 7 deletions(-)
>  create mode 100644 man3/loff_t.3
>  create mode 100644 man3/off64_t.3
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

      parent reply	other threads:[~2020-10-27 16:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 16:21 [PATCH 0/6] Add loff_t & off64_t, and update off_t Alejandro Colomar
2020-10-27 16:21 ` [PATCH 1/6] system_data_types.7: off_t: SEE ALSO: Uncomment loff_t, off64_t Alejandro Colomar
2020-10-27 16:21 ` [PATCH 2/6] system_data_types.7: off_t: Add note about _FILE_OFFSET_BITS Alejandro Colomar
2020-10-27 16:36   ` Michael Kerrisk (man-pages)
2020-10-27 16:21 ` [PATCH 3/6] system_data_types.7: Add 'loff_t' Alejandro Colomar
2020-10-27 16:21 ` [PATCH 4/6] loff_t.3: New link to system_data_types(7) Alejandro Colomar
2020-10-27 16:21 ` [PATCH 5/6] system_data_types.7: Add 'off64_t' Alejandro Colomar
2020-10-27 16:42   ` Michael Kerrisk (man-pages)
2020-10-27 16:21 ` [PATCH 6/6] off64_t.3: New link to system_data_types(7) Alejandro Colomar
2020-10-27 16:35 ` Michael Kerrisk (man-pages) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0b5a70c-7a45-d73b-4ddc-0fcc7e26bfae@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=colomar.6.4.3@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).