From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: mtk.manpages@gmail.com, Oleg Nesterov <oleg@redhat.com>,
Christian Brauner <christian@brauner.io>,
Jann Horn <jannh@google.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Daniel Colascione <dancol@google.com>,
Joel Fernandes <joel@joelfernandes.org>,
linux-man <linux-man@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: For review: pidfd_send_signal(2) manual page
Date: Mon, 23 Sep 2019 22:27:47 +0200 [thread overview]
Message-ID: <ca28a4d7-0c0e-2dee-b875-dc28b5dd0f0c@gmail.com> (raw)
In-Reply-To: <20190923142932.2gujbddnzyp4ujeu@wittgenstein>
Hello Christian,
On 9/23/19 4:29 PM, Christian Brauner wrote:
> On Mon, Sep 23, 2019 at 11:12:00AM +0200, Michael Kerrisk (man-pages) wrote:
>> Hello Christian and all,
>>
>> Below, I have the rendered version of the current draft of
>> the pidfd_send_signal(2) manual page that I have written.
>> The page source can be found in a Git branch at:
>> https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/log/?h=draft_pidfd
>>
>> I would be pleased to receive corrections and notes on any
>> details that should be added. (For example, are there error
>> cases that I have missed?)
>>
>> Would you be able to review please?
>
> Michael,
>
> A big big thank you for doing this! Really appreciated.
> I'm happy to review this!
>
>>
>> Thanks,
>>
>> Michael
>>
>>
>> NAME
>> pidfd_send_signal - send a signal to a process specified by a file
>> descriptor
>>
>> SYNOPSIS
>> int pidfd_send_signal(int pidfd, int sig, siginfo_t info,
>> unsigned int flags);
>>
>> DESCRIPTION
>> The pidfd_send_signal() system call sends the signal sig to the
>> target process referred to by pidfd, a PID file descriptor that
>> refers to a process.
>>
>> If the info argument points to a siginfo_t buffer, that buffer
>> should be populated as described in rt_sigqueueinfo(2).
>>
>> If the info argument is a NULL pointer, this is equivalent to
>> specifying a pointer to a siginfo_t buffer whose fields match the
>> values that are implicitly supplied when a signal is sent using
>> kill(2):
>>
>> * si_signo is set to the signal number;
>> * si_errno is set to 0;
>> * si_code is set to SI_USER;
>> * si_pid is set to the caller's PID; and
>> * si_uid is set to the caller's real user ID.
>>
>> The calling process must either be in the same PID namespace as
>> the process referred to by pidfd, or be in an ancestor of that
>> namespace.
>>
>> The flags argument is reserved for future use; currently, this
>> argument must be specified as 0.
>>
>> RETURN VALUE
>> On success, pidfd_send_signal() returns 0. On success, -1 is
>
> This should probably be "On error, -1 is [...]".
Thanks. Fixed.
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2019-09-23 20:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 9:12 For review: pidfd_send_signal(2) manual page Michael Kerrisk (man-pages)
2019-09-23 11:26 ` Florian Weimer
2019-09-23 14:23 ` Christian Brauner
2019-09-24 19:44 ` Michael Kerrisk (man-pages)
2019-09-24 19:57 ` Christian Brauner
2019-09-24 20:07 ` Christian Brauner
2019-09-24 21:00 ` Michael Kerrisk (man-pages)
2019-09-24 21:08 ` Daniel Colascione
2019-09-25 13:46 ` Michael Kerrisk (man-pages)
2019-09-24 21:53 ` Christian Brauner
2019-09-25 13:46 ` Michael Kerrisk (man-pages)
2019-09-25 13:51 ` Florian Weimer
2019-09-25 14:02 ` Michael Kerrisk (man-pages)
2019-09-25 13:53 ` Christian Brauner
2019-09-25 14:29 ` Michael Kerrisk (man-pages)
2019-09-24 19:43 ` Michael Kerrisk (man-pages)
2019-09-25 1:48 ` Jann Horn
2019-09-23 11:31 ` Daniel Colascione
2019-09-24 19:42 ` Michael Kerrisk (man-pages)
2019-09-23 14:29 ` Christian Brauner
2019-09-23 20:27 ` Michael Kerrisk (man-pages) [this message]
2019-09-23 21:27 ` Eric W. Biederman
2019-09-24 19:10 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca28a4d7-0c0e-2dee-b875-dc28b5dd0f0c@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=christian@brauner.io \
--cc=dancol@google.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).