From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH] quotactl.2: add EINVAL situation of Q_XQUOTARM call
Date: Sat, 14 Dec 2019 02:55:56 +0100 [thread overview]
Message-ID: <ca655f38-5269-d0bc-55df-74a74197e4dd@gmail.com> (raw)
In-Reply-To: <1575353153-18936-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>
Hello Yang Xu,
On 12/3/19 7:05 AM, Yang Xu wrote:
> Since kernel commit 3dd4d40b4208("xfs: Sanity check flags
> of Q_XQUOTARM call"), it has added flags check. If it is
> not usr,grp,prj quota type, it will report EINVAL.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
> man2/quotactl.2 | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/man2/quotactl.2 b/man2/quotactl.2
> index 34d3cfca8..d636818bd 100644
> --- a/man2/quotactl.2
> +++ b/man2/quotactl.2
> @@ -666,8 +666,10 @@ value containing flags (the same as in
> .I d_flags
> field of
> .I fs_disk_quota
> -structure) which identify what types of quota should be removed
> -(note that the quota type passed in the
> +structure, check flags since Linux 5.5)
> +.\" 3dd4d40b420846dd35869ccc8f8627feef2cff32
> +which identify what types of quota
> +should be removed(note that the quota type passed in the
> .I cmd
> argument is ignored, but should remain valid in order to pass preliminary
> quotactl syscall handler checks).
> @@ -736,6 +738,12 @@ is
> .BR Q_QUOTAON ,
> but the specified quota file is corrupted.
> .TP
> +.B EINVAL
> +.I cmd
> +is
> +.BR Q_XQUOTARM ,
> +but the addr does not point to valid quota types.
> +.TP
> .B ENOENT
> The file specified by
> .I special
Thanks. I applied you patch, and then tweaked a little,
so that the change became as below.
Thanks,
Michael
diff --git a/man2/quotactl.2 b/man2/quotactl.2
index 34d3cfca8..43552a0d6 100644
--- a/man2/quotactl.2
+++ b/man2/quotactl.2
@@ -666,11 +666,13 @@ value containing flags (the same as in
.I d_flags
field of
.I fs_disk_quota
-structure) which identify what types of quota should be removed
-(note that the quota type passed in the
+structure)
+which identify what types of quota
+should be removed.
+(Note that the quota type passed in the
.I cmd
argument is ignored, but should remain valid in order to pass preliminary
-quotactl syscall handler checks).
+quotactl syscall handler checks.)
.IP
Quotas must have already been turned off.
The
@@ -736,6 +738,15 @@ is
.BR Q_QUOTAON ,
but the specified quota file is corrupted.
.TP
+.BR EINVAL " (since Linux 5.5)"
+.\" 3dd4d40b420846dd35869ccc8f8627feef2cff32
+.I cmd
+is
+.BR Q_XQUOTARM ,
+but
+.I addr
+does not point to valid quota types.
+.TP
.B ENOENT
The file specified by
.I special
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
prev parent reply other threads:[~2019-12-14 1:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 6:05 [PATCH] quotactl.2: add EINVAL situation of Q_XQUOTARM call Yang Xu
2019-12-14 1:55 ` Michael Kerrisk (man-pages) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca655f38-5269-d0bc-55df-74a74197e4dd@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=xuyang2018.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).