From: Yang Shi <yang.shi@linux.alibaba.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Michal Hocko <mhocko@kernel.org>,
John Hubbard <jhubbard@nvidia.com>,
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
cl@linux.com, cai@lca.pw, akpm@linux-foundation.org,
linux-man@vger.kernel.org, linux-api@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] move_pages.2: not return ENOENT if the page are already on the target nodes
Date: Thu, 2 Jan 2020 14:15:12 -0800 [thread overview]
Message-ID: <d081b674-b360-4a0a-eec3-cf7434003cc5@linux.alibaba.com> (raw)
In-Reply-To: <87lfqtcfyo.fsf@x220.int.ebiederm.org>
On 12/30/19 7:49 PM, Eric W. Biederman wrote:
> Yang Shi <yang.shi@linux.alibaba.com> writes:
>
>> On 12/18/19 2:17 AM, Michal Hocko wrote:
>>> On Tue 17-12-19 23:36:09, John Hubbard wrote:
>>> [...]
>>>> diff --git a/man2/move_pages.2 b/man2/move_pages.2
>>>> index 2d96468fa..1bf1053f2 100644
>>>> --- a/man2/move_pages.2
>>>> +++ b/man2/move_pages.2
>>>> @@ -191,12 +191,6 @@ was specified or an attempt was made to migrate pages of a kernel thread.
>>>> .B ENODEV
>>>> One of the target nodes is not online.
>>>> .TP
>>>> -.B ENOENT
>>>> -No pages were found that require moving.
>>>> -All pages are either already
>>>> -on the target node, not present, had an invalid address or could not be
>>>> -moved because they were mapped by multiple processes.
>>>> -.TP
>>>> .B EPERM
>>>> The caller specified
>>>> .B MPOL_MF_MOVE_ALL
>>>>
>>>> ...But I'm not sure if we should change the implementation, instead, so
>>>> that it *can* return ENOENT. That's the main question to resolve before
>>>> creating any more patches, I think.
>>> I would start by dropping any note about ENOENT first. I am not really
>>> sure there is a reasonable usecase for it but maybe somebody comes up
>>> with something and only then we should consider it.
>>>
>>> Feel free to add
>>> Acked-by: Michal Hocko <mhocko@suse.com>
>>>
>>> ideally with a kernel commit which removed the ENOENT.
>> A quick audit doesn't show kernel code or comment notes about ENOENT
>> wrongly. The status could be set as ENOENT if the page is not present
>> (follow_page() returns NULL), and man page does match what kernel
>> does.
> Doesn't the function one layer up then consume the ENOENT?
No, it doesn't. The return value would be reset unconditionally by
store_status(). This is what the man page patch tries to correct.
>
> Eric
next prev parent reply other threads:[~2020-01-02 22:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 1:34 [PATCH] move_pages.2: not return ENOENT if the page are already on the target nodes Yang Shi
2019-12-06 1:47 ` John Hubbard
2019-12-06 7:47 ` Michal Hocko
2019-12-06 8:25 ` John Hubbard
2019-12-06 9:45 ` Michal Hocko
2019-12-06 17:31 ` Yang Shi
2019-12-06 18:00 ` Qian Cai
2019-12-06 18:19 ` Christopher Lameter
2019-12-06 17:26 ` Yang Shi
2019-12-14 1:55 ` Michael Kerrisk (man-pages)
2019-12-18 7:36 ` John Hubbard
2019-12-18 10:17 ` Michal Hocko
2019-12-31 3:00 ` Yang Shi
2019-12-31 3:49 ` Eric W. Biederman
2020-01-02 22:15 ` Yang Shi [this message]
2019-12-31 2:49 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d081b674-b360-4a0a-eec3-cf7434003cc5@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=ebiederm@xmission.com \
--cc=jhubbard@nvidia.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).