From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Tycho Andersen <tycho@tycho.pizza>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH] fsync: note syncfs in in SEE ALSO
Date: Tue, 10 Aug 2021 23:34:27 +0200 [thread overview]
Message-ID: <daad13cb-384f-13b3-9fc2-fc4ee10afd33@gmail.com> (raw)
In-Reply-To: <20210728181603.2694191-1-tycho@tycho.pizza>
Hi Tycho,
On 7/28/21 8:16 PM, Tycho Andersen wrote:
> I didn't know about this syscall until just now somehow, but it seems
> reasonable to mention it in the fsync.
>
> Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
> ---
> man2/fsync.2 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/man2/fsync.2 b/man2/fsync.2
> index 0f070ed2c..32238dc07 100644
> --- a/man2/fsync.2
> +++ b/man2/fsync.2
> @@ -200,6 +200,7 @@ to guarantee safe operation.
> .BR pwritev (2),
> .BR sync (2),
> .BR sync_file_range (2),
> +.BR syncfs (2),
> .BR fflush (3),
> .BR fileno (3),
> .BR hdparm (8),
>
> base-commit: fbe71b1b79e72be3b9afc44b5d479e7fd84b598a
I'm hesitant about this. syncfs(2) is documented in the sync(2)
page, which is already in SEE ALSO. Knowing that, do you still
think this patch has benefit?
Thanks,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2021-08-10 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 18:16 [PATCH] fsync: note syncfs in in SEE ALSO Tycho Andersen
2021-08-10 21:34 ` Michael Kerrisk (man-pages) [this message]
2021-08-10 21:53 ` Tycho Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daad13cb-384f-13b3-9fc2-fc4ee10afd33@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=tycho@tycho.pizza \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).