From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A64C433EF for ; Sun, 20 Mar 2022 18:15:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343509AbiCTSQe (ORCPT ); Sun, 20 Mar 2022 14:16:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343505AbiCTSQ3 (ORCPT ); Sun, 20 Mar 2022 14:16:29 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD8B7527EC; Sun, 20 Mar 2022 11:15:05 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id n35so5768846wms.5; Sun, 20 Mar 2022 11:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hBX2k7bP0JuTGs4Va/cZqoPnNWMc+mP7VB6dwkEnym8=; b=a7edImwHxElUp+nxiHhoczI85uybUug2XQbZiUj8jMu6GG9oZjIyONWdpgH98fh0W2 wg7cBnyT85R9tRkGV5SQm3qjxZkdTdKD6FPHX50zQXHVP9ZsMiXplcHGGSkIicsGE6fD sX7DW+Psq/1IeC/wWv2uw+kMKaLkeygDVvBk7d/4hn0GGTcmvjGwyc8exMaRmZngbYFw 0uQWQddLDXWQh34kd4kf/BBJmPkJKMTkQOAX6OSwsR2tzDfbi1dg4I6+EuEa82Xczkk3 tyb2MIR2ooKbgL8fTjyxm6bWeha43bgPtKiXwS22r7cPQZ+5fvrANHu8IY33Q5wqXVwv JIDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hBX2k7bP0JuTGs4Va/cZqoPnNWMc+mP7VB6dwkEnym8=; b=HxPyogpQUkS+jCJi291GdsEq+gcicRQh8zOZ6HlvcMbZhEXjpBTxawt69MonkwKJxa gJ98yLg79SwpTdE13xf+fbREvewC1lLOLZcpC8ctNoX5pIB6IJ5cNDyn5zVfnB0DNt6T WN3hoDtzZGsqgznPNhQfkqYGgc+TUIZ5q8ycEsEvHU7KXIUCIf1ikwD7SkgVUSByP151 gihy7WfIIQl9+3YeEH2SQn394WIv6LLAbRJYV/IacJx2T1C1Dka1c8ddJeDd4drRTS8C fT0LyBB4vzFTXekQLON4iu1gQxgkWkNNS10GN7JVLJgbwIam6M2O9tgbljUvAEG/RmsT rpdw== X-Gm-Message-State: AOAM53266yFL7qhHOjs9MBkLEccEH1akWL7MmOxph4fGdpBxWJcJHpST i4M8JtPDJTXBuuj5q6lFzda3cBPFiZB6Auq+ X-Google-Smtp-Source: ABdhPJyveFwD1BJnTecZ7BvTG+hVgQovZ0eEhZCc0YsQ1xX+FrRyk5mGeQO6lFVJvUIYkVDodWGjZg== X-Received: by 2002:a05:600c:4e0d:b0:38c:a6da:adec with SMTP id b13-20020a05600c4e0d00b0038ca6daadecmr946252wmq.145.1647800104485; Sun, 20 Mar 2022 11:15:04 -0700 (PDT) Received: from [192.168.0.160] ([170.253.36.171]) by smtp.gmail.com with ESMTPSA id a18-20020a05600c349200b0038ca453a887sm1598598wmq.19.2022.03.20.11.15.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Mar 2022 11:15:04 -0700 (PDT) Message-ID: Date: Sun, 20 Mar 2022 19:15:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [patch] console_codes.4: ffix Content-Language: en-US To: "G. Branden Robinson" Cc: nick black , Michael Kerrisk , linux-kernel@vger.kernel.org, linux-man@vger.kernel.org References: <20220320160217.gws42lklp6ishzub@localhost.localdomain> From: "Alejandro Colomar (man-pages)" In-Reply-To: <20220320160217.gws42lklp6ishzub@localhost.localdomain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org Hi, nick, and Branden! On 3/20/22 17:02, G. Branden Robinson wrote: > Hi Nick, > > Alex has been waiting on me for a review of this patch. I took longer > than I should have because I thought he was expecting a technical > evaluation of the accuracy of the sequences documented.[1] Now I see it > was just a matter of man(7) and tbl(1) syntactical and style review. No, you were originally right. I did mean both, but especially "a technical evaluation of the accuracy of the sequences documented". You did it anyway, so thanks! :) > > Easy bits first. > >> Remove CSI prefix from the list of non-CSI escapes. > > +1 > >> End all items of said list with periods, matching other sections of >> the page. > > +1 > >> Fix up the busted OSC command list (reset palette and set palette). > >> ESC ] OSC T{ >> -(Should be: Operating system command) >> -ESC ] P \fInrrggbb\fP: set palette, with parameter >> -given in 7 hexadecimal digits after the final P :-(. >> -Here \fIn\fP is the color (0\(en15), and \fIrrggbb\fP indicates >> +Operating System Command prefix. >> +T} >> +ESC ] R Reset palette. >> +ESC ] P T{ >> +Set palette, with parameter given in 7 hexadecimal digits \fInrrggbb\fP after >> +the final P. Here \fIn\fP is the color (0\(en15), and \fIrrggbb\fP indicates >> the red/green/blue values (0\(en255). >> -ESC ] R: reset palette >> T} > > Yes, this was majorly hosed up, syntactically. What you have is good > repair to obvious damage. +1. > > I have some suggestions for further improvement, but please don't gate > the patch application on these. [...] Okay, thanks! nick, can you please resend the patch? I've lost the original email. Cheers, Alex -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/