From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.anw.at ([195.234.101.228]:55841 "EHLO mail.anw.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966053AbeBMX3o (ORCPT ); Tue, 13 Feb 2018 18:29:44 -0500 Subject: Re: [PATCH V2 1/3] media: dvb-core: Store device structure in dvb_register_device To: linux-media@vger.kernel.org Cc: mchehab@s-opensource.com, rjkm@metzlerbros.de, d.scheller@gmx.net References: <1513862559-19725-1-git-send-email-jasmin@anw.at> <1513862559-19725-2-git-send-email-jasmin@anw.at> From: "Jasmin J." Message-ID: <0008ba49-3a90-bc05-a0a8-31c28cc481ec@anw.at> Date: Wed, 14 Feb 2018 00:29:37 +0100 MIME-Version: 1.0 In-Reply-To: <1513862559-19725-2-git-send-email-jasmin@anw.at> Content-Type: text/plain; charset=utf-8 Content-Language: de-AT Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi! Please hold on in merging this series, because I have to investigate a hint I got related to the buffer size handshake of the protocol driver: https://www.linuxtv.org/pipermail/linux-dvb/2007-July/019116.html BR, Jasmin On 12/21/2017 02:22 PM, Jasmin J. wrote: > From: Jasmin Jessich > > The device created by device_create in dvb_register_device was not > available for DVB device drivers. > Added "struct device *dev" to "struct dvb_device" and store the created > device. > > Signed-off-by: Jasmin Jessich > Acked-by: Ralph Metzler > --- > drivers/media/dvb-core/dvbdev.c | 1 + > drivers/media/dvb-core/dvbdev.h | 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c > index 060c60d..f55eff1 100644 > --- a/drivers/media/dvb-core/dvbdev.c > +++ b/drivers/media/dvb-core/dvbdev.c > @@ -538,6 +538,7 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev, > __func__, adap->num, dnames[type], id, PTR_ERR(clsdev)); > return PTR_ERR(clsdev); > } > + dvbdev->dev = clsdev; > dprintk("DVB: register adapter%d/%s%d @ minor: %i (0x%02x)\n", > adap->num, dnames[type], id, minor, minor); > > diff --git a/drivers/media/dvb-core/dvbdev.h b/drivers/media/dvb-core/dvbdev.h > index bbc1c20..1f2d2ff 100644 > --- a/drivers/media/dvb-core/dvbdev.h > +++ b/drivers/media/dvb-core/dvbdev.h > @@ -147,10 +147,11 @@ struct dvb_adapter { > * @tsout_num_entities: Number of Transport Stream output entities > * @tsout_entity: array with MC entities associated to each TS output node > * @tsout_pads: array with the source pads for each @tsout_entity > + * @dev: pointer to struct device that is associated with the dvb device > * > * This structure is used by the DVB core (frontend, CA, net, demux) in > * order to create the device nodes. Usually, driver should not initialize > - * this struct diretly. > + * this struct directly. > */ > struct dvb_device { > struct list_head list_head; > @@ -183,6 +184,7 @@ struct dvb_device { > #endif > > void *priv; > + struct device *dev; > }; > > /** >