linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <martinax.krasteva@linux.intel.com>
To: "'Rob Herring'" <robh@kernel.org>
Cc: <linux-media@vger.kernel.org>, <robh+dt@kernel.org>,
	<mchehab@kernel.org>, <devicetree@vger.kernel.org>,
	<daniele.alessandrelli@linux.intel.com>,
	<gjorgjix.rosikopulos@linux.intel.com>,
	<sakari.ailus@linux.intel.com>
Subject: RE: [PATCH 1/2] dt-bindings: media: Add bindings for imx334
Date: Mon, 30 Nov 2020 10:58:05 -0000	[thread overview]
Message-ID: <002101d6c707$b103c0c0$130b4240$@linux.intel.com> (raw)
In-Reply-To: <20201120205858.GA1722419@robh.at.kernel.org>

Hi Rob,

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Friday, November 20, 2020 8:59 PM
> To: Martina Krasteva <martinax.krasteva@linux.intel.com>
> Cc: linux-media@vger.kernel.org; robh+dt@kernel.org; mchehab@kernel.org;
> devicetree@vger.kernel.org; daniele.alessandrelli@linux.intel.com;
> gjorgjix.rosikopulos@linux.intel.com; sakari.ailus@linux.intel.com
> Subject: Re: [PATCH 1/2] dt-bindings: media: Add bindings for imx334
> 
> On Fri, 20 Nov 2020 14:28:02 +0000, Martina Krasteva wrote:
> > From: Martina Krasteva <martinax.krasteva@intel.com>
> >
> > - Add dt-bindings documentation for Sony imx334 sensor driver.
> > - Add MAINTAINERS entry for Sony imx334 binding documentation.
> >
> > Signed-off-by: Martina Krasteva <martinax.krasteva@intel.com>
> > Reviewed-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@intel.com>
> > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
> > ---
> >  .../devicetree/bindings/media/i2c/sony,imx334.yaml | 59
> ++++++++++++++++++++++
> >  MAINTAINERS                                        |  7 +++
> >  2 files changed, 66 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> >
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:34:15:
> [warning] wrong indentation: expected 12 but found 14 (indentation)
> ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:36:15:
> [warning] wrong indentation: expected 12 but found 14 (indentation)
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:
> 'additionalProperties' is a required property
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:
> ignoring, error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> 
> 
> See https://patchwork.ozlabs.org/patch/1403740
> 
> The base for the patch is generally the last rc1. Any dependencies should
be
> noted.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.

Thank you, I will fix these warnings in the next version

Best Regards,
Martina


  reply	other threads:[~2020-11-30 11:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 14:28 [PATCH 0/2] IMX334 Camera Sensor Driver Martina Krasteva
2020-11-20 14:28 ` [PATCH 1/2] dt-bindings: media: Add bindings for imx334 Martina Krasteva
2020-11-20 20:58   ` Rob Herring
2020-11-30 10:58     ` martinax.krasteva [this message]
2020-11-20 14:28 ` [PATCH 2/2] media: Add imx334 camera sensor driver Martina Krasteva
2020-11-23 11:10   ` Jacopo Mondi
2020-11-23 11:36     ` Andrey Konovalov
2020-11-30 10:53       ` martinax.krasteva
2020-11-23 14:02     ` Sakari Ailus
2020-11-30 10:21       ` martinax.krasteva
2020-11-30 13:39         ` 'Sakari Ailus'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002101d6c707$b103c0c0$130b4240$@linux.intel.com' \
    --to=martinax.krasteva@linux.intel.com \
    --cc=daniele.alessandrelli@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gjorgjix.rosikopulos@linux.intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).