From: <Eugen.Hristev@microchip.com>
To: <sakari.ailus@iki.fi>
Cc: <mchehab@kernel.org>, <hverkuil@xs4all.nl>, <robh+dt@kernel.org>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: media: csi2dc: add bindings for microchip csi2dc
Date: Wed, 19 Aug 2020 12:45:29 +0000 [thread overview]
Message-ID: <07583628-1fd0-cb05-dc12-f4a3c76da3de@microchip.com> (raw)
In-Reply-To: <20200813224619.GN840@valkosipuli.retiisi.org.uk>
On 14.08.2020 01:46, Sakari Ailus wrote:
> Hi Eugen,
>
> On Fri, Jul 03, 2020 at 10:44:13AM +0300, Eugen Hristev wrote:
>> Add bindings documentation for microchip CSI2 Demultiplexer controller.
>
> ...
>
>> + port@1:
>> + type: object
>> + description:
>> + Output port node, single endpoint, describing the output pad.
>> +
>> + properties:
>> + '#address-cells':
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 0
>> +
>> + reg:
>> + const: 1
>> +
>> + patternProperties:
>> + "^endpoint@[0-9a-f]$":
>> + type: object
>> +
>> + properties:
>> + reg:
>> + enum: [0, 1, 2, 3]
>> + description: virtual channel for the endpoint
>
> Unless you need this right now I'd just hard code this to zero in the
> driver. You can't have more endpoints for active devices anyway, can you?
Hello Sakari,
You are right, but, the virtual ID must be written in hardware
registers. So I can take the virtual ID from this property.
Otherwise, if I hardcode this in the driver, another virtual ID would be
impossible to use without changing the driver. And if the binding is
accepted without this property, it will be 'set in stone' and difficult
to change afterwards.
What do you think ?
Eugen
>
> --
> Sakari Ailus
>
next prev parent reply other threads:[~2020-08-19 12:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 7:44 [PATCH v2 0/4] media: introduce microchip csi2dc driver Eugen Hristev
2020-07-03 7:44 ` [PATCH v2 1/4] dt-bindings: media: csi2dc: add bindings for microchip csi2dc Eugen Hristev
2020-07-14 2:55 ` Rob Herring
2020-08-19 12:47 ` Eugen.Hristev
2020-08-13 22:46 ` Sakari Ailus
2020-08-19 12:45 ` Eugen.Hristev [this message]
2020-08-19 12:59 ` Eugen.Hristev
2020-07-03 7:44 ` [PATCH v2 2/4] media: misc: introduce miscellaneous menu for helper chips Eugen Hristev
2020-07-03 7:44 ` [PATCH v2 3/4] media: misc: introduce microchip_csi2dc driver Eugen Hristev
2020-08-13 22:44 ` Sakari Ailus
2020-08-25 12:44 ` Eugen.Hristev
2020-08-25 13:19 ` Eugen.Hristev
2020-07-03 7:44 ` [PATCH v2 4/4] MAINTAINERS: add microchip csi2dc Eugen Hristev
2020-08-13 22:24 ` Sakari Ailus
2020-08-13 22:23 ` [PATCH v2 0/4] media: introduce microchip csi2dc driver Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07583628-1fd0-cb05-dc12-f4a3c76da3de@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).