From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 080E3C388F7 for ; Tue, 20 Oct 2020 16:24:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A77CC22250 for ; Tue, 20 Oct 2020 16:24:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394577AbgJTQX4 (ORCPT ); Tue, 20 Oct 2020 12:23:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727004AbgJTQX4 (ORCPT ); Tue, 20 Oct 2020 12:23:56 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62EEEC0613CE; Tue, 20 Oct 2020 09:23:56 -0700 (PDT) Received: from [IPv6:2003:c7:cf43:5b00:28a3:2f4e:277d:2227] (p200300c7cf435b0028a32f4e277d2227.dip0.t-ipconnect.de [IPv6:2003:c7:cf43:5b00:28a3:2f4e:277d:2227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C8B441F451DF; Tue, 20 Oct 2020 17:23:54 +0100 (BST) Subject: Re: [PATCH] media: staging: rkisp1: rsz: make const array static, makes object smaller To: Colin King , Helen Koike , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201020144655.53251-1-colin.king@canonical.com> From: Dafna Hirschfeld Message-ID: <07b92ab9-bade-623e-395d-89320d9f88f6@collabora.com> Date: Tue, 20 Oct 2020 18:23:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201020144655.53251-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, thanks, Am 20.10.20 um 16:46 schrieb Colin King: > From: Colin Ian King > > Don't populate the const array dev_names on the stack but instead it > static. Makes the object code smaller by 15 bytes. > > Before: > text data bss dec hex filename > 17091 2648 64 19803 4d5b media/rkisp1/rkisp1-resizer.o > > After: > text data bss dec hex filename > 17012 2712 64 19788 4d4c media/rkisp1/rkisp1-resizer.o On the other hand the data segment is 64 bytes bigger. I don't know what is more important to save. Anyway, the rkisp1-capture.c does the same with the names so it is better to be consistent. Thanks, Dafna > > (gcc version 10.2.0) > > Signed-off-by: Colin Ian King > --- > drivers/staging/media/rkisp1/rkisp1-resizer.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c b/drivers/staging/media/rkisp1/rkisp1-resizer.c > index 1687d82e6c68..7ca5b47c5bf5 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-resizer.c > +++ b/drivers/staging/media/rkisp1/rkisp1-resizer.c > @@ -763,8 +763,10 @@ static void rkisp1_rsz_unregister(struct rkisp1_resizer *rsz) > > static int rkisp1_rsz_register(struct rkisp1_resizer *rsz) > { > - const char * const dev_names[] = {RKISP1_RSZ_MP_DEV_NAME, > - RKISP1_RSZ_SP_DEV_NAME}; > + static const char * const dev_names[] = { > + RKISP1_RSZ_MP_DEV_NAME, > + RKISP1_RSZ_SP_DEV_NAME > + }; > struct media_pad *pads = rsz->pads; > struct v4l2_subdev *sd = &rsz->sd; > int ret; >