From: Hans Verkuil <hverkuil@xs4all.nl>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
kieran.bingham+renesas@ideasonboard.com,
laurent.pinchart+renesas@ideasonboard.com,
niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, Hyun Kwon <hyunk@xilinx.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
sergei.shtylyov@gmail.com,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v8 1/5] media: i2c: Add driver for RDACM21 camera module
Date: Mon, 8 Feb 2021 12:21:01 +0100 [thread overview]
Message-ID: <0b118385-70bc-01eb-8ddf-829c604d533b@xs4all.nl> (raw)
In-Reply-To: <20210114170429.139762-2-jacopo+renesas@jmondi.org>
Hi Jacopo,
On 14/01/2021 18:04, Jacopo Mondi wrote:
> The RDACM21 is a GMSL camera supporting 1280x1080 resolution images
> developed by IMI based on an Omnivision OV10640 sensor, an Omnivision
> OV490 ISP and a Maxim MAX9271 GMSL serializer.
>
> The driver uses the max9271 library module, to maximize code reuse with
> other camera module drivers using the same serializer, such as rdacm20.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> MAINTAINERS | 12 +
> drivers/media/i2c/Kconfig | 13 +
> drivers/media/i2c/Makefile | 2 +
> drivers/media/i2c/rdacm21.c | 623 ++++++++++++++++++++++++++++++++++++
> 4 files changed, 650 insertions(+)
> create mode 100644 drivers/media/i2c/rdacm21.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 14adf87d90c7..1822d73ed615 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14967,6 +14967,18 @@ F: drivers/media/i2c/max9271.c
> F: drivers/media/i2c/max9271.h
> F: drivers/media/i2c/rdacm20.c
>
> +RDACM21 Camera Sensor
> +M: Jacopo Mondi <jacopo+renesas@jmondi.org>
> +M: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> +M: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> +M: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> +L: linux-media@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/media/i2c/rdacm2x-gmsl.yaml
> +F: drivers/media/i2c/max9271.c
> +F: drivers/media/i2c/max9271.h
> +F: drivers/media/i2c/rdacm21.c
> +
> RDC R-321X SoC
> M: Florian Fainelli <florian@openwrt.org>
> S: Maintained
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 2b9d81e4794a..d500edb8638b 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -1212,6 +1212,19 @@ config VIDEO_RDACM20
> This camera should be used in conjunction with a GMSL
> deserialiser such as the MAX9286.
>
> +config VIDEO_RDACM21
> + tristate "IMI RDACM21 camera support"
> + depends on I2C
> + select V4L2_FWNODE
> + select VIDEO_V4L2_SUBDEV_API
> + select MEDIA_CONTROLLER
> + help
> + This driver supports the IMI RDACM21 GMSL camera, used in
> + ADAS systems.
> +
> + This camera should be used in conjunction with a GMSL
> + deserialiser such as the MAX9286.
> +
> config VIDEO_RJ54N1
> tristate "Sharp RJ54N1CB0C sensor support"
> depends on I2C && VIDEO_V4L2
> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> index a3149dce21bb..85b1edc62508 100644
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -124,6 +124,8 @@ obj-$(CONFIG_VIDEO_IMX355) += imx355.o
> obj-$(CONFIG_VIDEO_MAX9286) += max9286.o
> rdacm20-camera_module-objs := rdacm20.o max9271.o
> obj-$(CONFIG_VIDEO_RDACM20) += rdacm20-camera_module.o
> +rdacm21-camera_module-objs := rdacm21.o max9271.o
> +obj-$(CONFIG_VIDEO_RDACM21) += rdacm21-camera_module.o
> obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o
This isn't right. The max9271 code exports various functions, but since it is
included with *two* modules (rdacm20/1-camera_module.ko) it is exported twice.
Since max9271 is not a self-contained driver it should not export symbols.
Can you provide a patch fixing that?
Thanks,
Hans
next prev parent reply other threads:[~2021-02-08 11:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 17:04 [PATCH v8 0/5] media: i2c: Add RDACM21 camera module Jacopo Mondi
2021-01-14 17:04 ` [PATCH v8 1/5] media: i2c: Add driver for " Jacopo Mondi
2021-02-08 11:21 ` Hans Verkuil [this message]
2021-02-08 11:28 ` Laurent Pinchart
2021-02-08 11:34 ` Hans Verkuil
2021-02-08 11:37 ` Laurent Pinchart
2021-02-08 11:28 ` Hans Verkuil
2021-02-08 11:43 ` Jacopo Mondi
2021-01-14 17:04 ` [PATCH v8 2/5] dt-bindings: media: max9286: Document 'maxim,reverse-channel-microvolt' Jacopo Mondi
2021-01-14 17:04 ` [PATCH v8 3/5] media: i2c: max9286: Break-out reverse channel setup Jacopo Mondi
2021-01-14 17:04 ` [PATCH v8 4/5] media: i2c: max9286: Make channel amplitude programmable Jacopo Mondi
2021-01-14 17:04 ` [PATCH v8 5/5] media: i2c: max9286: Configure reverse channel amplitude Jacopo Mondi
2021-02-01 8:54 ` [PATCH v8 0/5] media: i2c: Add RDACM21 camera module Jacopo Mondi
2021-02-01 13:00 ` Sakari Ailus
2021-02-01 18:14 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b118385-70bc-01eb-8ddf-829c604d533b@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=geert@linux-m68k.org \
--cc=hyunk@xilinx.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).