From: Hans Verkuil <hverkuil@xs4all.nl>
To: Ken Sloat <KSloat@aampglobal.com>,
"eugen.hristev@microchip.com" <eugen.hristev@microchip.com>
Cc: "mchehab@kernel.org" <mchehab@kernel.org>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"ludovic.desroches@microchip.com"
<ludovic.desroches@microchip.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] media: atmel-isc: Update device tree binding documentation
Date: Tue, 8 Jan 2019 14:45:55 +0100 [thread overview]
Message-ID: <0be61a88-93c9-6181-b0ea-b1048c98e0e1@xs4all.nl> (raw)
In-Reply-To: <fd9073b4-7625-6f91-546e-9dad0bf6201f@xs4all.nl>
On 01/08/19 14:44, Hans Verkuil wrote:
> On 12/28/18 17:59, Ken Sloat wrote:
>> From: Ken Sloat <ksloat@aampglobal.com>
>>
>> Update device tree binding documentation specifying how to
>> enable BT656 with CRC decoding.
>>
>> Signed-off-by: Ken Sloat <ksloat@aampglobal.com>
>> ---
>> Documentation/devicetree/bindings/media/atmel-isc.txt | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/atmel-isc.txt b/Documentation/devicetree/bindings/media/atmel-isc.txt
>> index bbe0e87c6188..e787edeea7da 100644
>> --- a/Documentation/devicetree/bindings/media/atmel-isc.txt
>> +++ b/Documentation/devicetree/bindings/media/atmel-isc.txt
>> @@ -25,6 +25,9 @@ ISC supports a single port node with parallel bus. It should contain one
>> 'port' child node with child 'endpoint' node. Please refer to the bindings
>> defined in Documentation/devicetree/bindings/media/video-interfaces.txt.
>>
>> +If all endpoint bus flags (i.e. hsync-active) are omitted, then CCIR656
>> +decoding (embedded sync) with CRC decoding is enabled.
>
> Sorry, this is wrong. There is a bus-type property defined in video-interfaces.txt
> that you should use to determine whether this is a parallel or a Bt.656 bus.
Actually, that's what your code already does, so it seems this text in the bindings doc
is just plain wrong.
Hans
>
> BTW, for v2 also CC this to devicetree@vger.kernel.org, since it has to be reviewed
> by the DT maintainers.
>
> Regards,
>
> Hans
>
>> +
>> Example:
>> isc: isc@f0008000 {
>> compatible = "atmel,sama5d2-isc";
>>
>
next prev parent reply other threads:[~2019-01-08 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 16:59 [PATCH v1 1/2] media: atmel-isc: Add support for BT656 with CRC decoding Ken Sloat
2018-12-28 16:59 ` [PATCH v1 2/2] media: atmel-isc: Update device tree binding documentation Ken Sloat
2019-01-07 11:10 ` Eugen.Hristev
2019-01-08 13:44 ` Hans Verkuil
2019-01-08 13:45 ` Hans Verkuil [this message]
2019-01-14 20:31 ` Ken Sloat
2019-01-07 11:10 ` [PATCH v1 1/2] media: atmel-isc: Add support for BT656 with CRC decoding Eugen.Hristev
2019-01-14 20:27 ` Ken Sloat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0be61a88-93c9-6181-b0ea-b1048c98e0e1@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=KSloat@aampglobal.com \
--cc=alexandre.belloni@bootlin.com \
--cc=eugen.hristev@microchip.com \
--cc=linux-media@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mchehab@kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).