linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vandana BN <bnvandana@gmail.com>
To: Akihiro TSUKADA <tskd08@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH] media:dvb-frontends:Return if Max devices are added in dvb_pll_attach().
Date: Fri, 19 Jul 2019 12:32:14 +0530	[thread overview]
Message-ID: <0cfa5617-7517-fc7c-0630-46cf854bf8d2@gmail.com> (raw)
In-Reply-To: <2912b5af-ae8f-e6c9-0e74-8790f5762997@gmail.com>


On 19/07/19 7:11 AM, Akihiro TSUKADA wrote:
>> Will it be better, if dvb_pll_devcount is decremented in dvb_pll_release(),  instead of removing module params?
> But you cannot know deterministically which device corrensponds to
> what "id" (when you have multiple dvb_pll devices),
> since "id" is dependent on the history of register and unregister
> of dvb_pll devices.
dvb_pll_release() frees  fe->tuner_priv, and priv->nr is dvb_pll_devcount, but, decrementing  count will only tell array has a free slot, and now if that free slot needs to be used it will have to either maintain free index list to be consumed next or convert array id to a list.
> So I wonder about the benefit / practical usecase of "id" parameter.

Ok, I will remove the module parameters and send a patch.

Thanks,

Vandana.

>
> --
> Akihiro

  reply	other threads:[~2019-07-19  7:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 14:12 [PATCH] media:dvb-frontends:Return if Max devices are added in dvb_pll_attach() Vandana BN
2019-07-18  0:35 ` Akihiro TSUKADA
2019-07-18  9:10   ` Vandana BN
2019-07-19  1:41     ` Akihiro TSUKADA
2019-07-19  7:02       ` Vandana BN [this message]
2019-07-20  6:13 ` [PATCH v2] media:dvb-frontends:Remove dvb_pll_devcount and id module parameters Vandana BN
2019-07-24  5:36   ` Sean Young
2019-08-01  5:09     ` Sean Young
2019-08-01  8:53       ` Vandana BN
2019-08-01  9:01     ` Michael Ira Krufky
2019-08-02  6:50       ` Vandana BN
2019-08-03  0:24         ` Sean Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cfa5617-7517-fc7c-0630-46cf854bf8d2@gmail.com \
    --to=bnvandana@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=tskd08@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).