Linux-Media Archive on lore.kernel.org
 help / color / Atom feed
From: Steve Longerbeam <slongerbeam@gmail.com>
To: Fabio Estevam <festevam@gmail.com>, hverkuil-cisco@xs4all.nl
Cc: mchehab@kernel.org, p.zabel@pengutronix.de,
	linux-media@vger.kernel.org, tharvey@gateworks.com
Subject: Re: [PATCH] media: imx.rst: Update the imx6-sabreauto ADV7180 instructions
Date: Sat, 12 Oct 2019 13:14:22 -0700
Message-ID: <0f7a7910-8652-7a95-1f04-e25278ec05aa@gmail.com> (raw)
In-Reply-To: <20191010154417.9437-1-festevam@gmail.com>

Hi Fabio,

On 10/10/19 8:44 AM, Fabio Estevam wrote:
> In kernel 5.3.x the I2C bus that the adv7180 is under has changed from
> bus 3 to 4 and the ipu_csi0_mux numbers has also changed as shown by
> the kernel log below:
>
> [    5.159423] imx-media: ipu1_csi0_mux:5 -> ipu1_csi0:0
> [    5.164618] imx-media: ipu1_csi1_mux:5 -> ipu1_csi1:0
> [    5.169953] imx-media: adv7180 4-0021:0 -> ipu1_csi0_mux:4
>
> Update the instructions accordingly.

I just booted the imx6q SabreAuto with 5.4.0-rc1 (and media-tree HEAD 
3ff3a712a9ea), I am getting:

arm:~ % uname -r
5.4.0-rc1-13672-g3ff3a712a9ea
arm:~ % dmesg | grep 'ipu[12]_csi[01]_mux'
[   13.042519] imx-media: ipu1_csi0_mux:2 -> ipu1_csi0:0
[   13.042590] imx-media: ipu2_csi1_mux:2 -> ipu2_csi1:0
[   13.042656] imx-media: adv7180 3-0021:0 -> ipu1_csi0_mux:1
arm:~ % dmesg | grep adv7180
[   12.905157] adv7180 3-0021: chip found @ 0x21 (i2c-2-mux (chan_id 1))
[   13.042656] imx-media: adv7180 3-0021:0 -> ipu1_csi0_mux:1


So the adv7180 i2c-bus and pad numbers have not changed. The adv7180 is 
still on bus 3, and the output pad from the IPU-CSI video muxes are 
still pad 2. The video muxes have no such pad 5 in fact. I'd be curious 
in learning how you came about that pad number.

> Also, in the last line pass the fmt field explicitly as done in the
> previous lines.

Thanks for catching that, it was left over from a pipeline configuration 
script of mine.

Steve

>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>   Documentation/media/v4l-drivers/imx.rst | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/media/v4l-drivers/imx.rst b/Documentation/media/v4l-drivers/imx.rst
> index 1d7eb8c7bd5c..75430cd2f222 100644
> --- a/Documentation/media/v4l-drivers/imx.rst
> +++ b/Documentation/media/v4l-drivers/imx.rst
> @@ -530,12 +530,12 @@ NTSC, or 'alternate'):
>   .. code-block:: none
>   
>      # Setup links
> -   media-ctl -l "'adv7180 3-0021':0 -> 'ipu1_csi0_mux':1[1]"
> -   media-ctl -l "'ipu1_csi0_mux':2 -> 'ipu1_csi0':0[1]"
> +   media-ctl -l "'adv7180 4-0021':0 -> 'ipu1_csi0_mux':4[1]"
> +   media-ctl -l "'ipu1_csi0_mux':5 -> 'ipu1_csi0':0[1]"
>      media-ctl -l "'ipu1_csi0':2 -> 'ipu1_csi0 capture':0[1]"
>      # Configure pads
> -   media-ctl -V "'adv7180 3-0021':0 [fmt:UYVY2X8/720x480 field:seq-bt]"
> -   media-ctl -V "'ipu1_csi0_mux':2 [fmt:UYVY2X8/720x480]"
> +   media-ctl -V "'adv7180 4-0021':0 [fmt:UYVY2X8/720x480 field:seq-bt]"
> +   media-ctl -V "'ipu1_csi0_mux':5 [fmt:UYVY2X8/720x480]"
>      media-ctl -V "'ipu1_csi0':2 [fmt:AYUV32/720x480]"
>      # Configure "ipu1_csi0 capture" interface (assumed at /dev/video4)
>      v4l2-ctl -d4 --set-fmt-video=field=interlaced_bt
> @@ -553,19 +553,19 @@ at its output pad:
>   .. code-block:: none
>   
>      # Setup links
> -   media-ctl -l "'adv7180 3-0021':0 -> 'ipu1_csi0_mux':1[1]"
> -   media-ctl -l "'ipu1_csi0_mux':2 -> 'ipu1_csi0':0[1]"
> +   media-ctl -l "'adv7180 4-0021':0 -> 'ipu1_csi0_mux':4[1]"
> +   media-ctl -l "'ipu1_csi0_mux':5 -> 'ipu1_csi0':0[1]"
>      media-ctl -l "'ipu1_csi0':1 -> 'ipu1_vdic':0[1]"
>      media-ctl -l "'ipu1_vdic':2 -> 'ipu1_ic_prp':0[1]"
>      media-ctl -l "'ipu1_ic_prp':2 -> 'ipu1_ic_prpvf':0[1]"
>      media-ctl -l "'ipu1_ic_prpvf':1 -> 'ipu1_ic_prpvf capture':0[1]"
>      # Configure pads
> -   media-ctl -V "'adv7180 3-0021':0 [fmt:UYVY2X8/720x576 field:seq-tb]"
> -   media-ctl -V "'ipu1_csi0_mux':2 [fmt:UYVY2X8/720x576]"
> +   media-ctl -V "'adv7180 4-0021':0 [fmt:UYVY2X8/720x576 field:seq-tb]"
> +   media-ctl -V "'ipu1_csi0_mux':5 [fmt:UYVY2X8/720x576]"
>      media-ctl -V "'ipu1_csi0':1 [fmt:AYUV32/720x576]"
>      media-ctl -V "'ipu1_vdic':2 [fmt:AYUV32/720x576 field:none]"
>      media-ctl -V "'ipu1_ic_prp':2 [fmt:AYUV32/720x576 field:none]"
> -   media-ctl -V "'ipu1_ic_prpvf':1 [fmt:$outputfmt field:none]"
> +   media-ctl -V "'ipu1_ic_prpvf':1 [fmt:AYUV32/720x576 field:none]"
>   
>   Streaming can then begin on the capture device node at
>   "ipu1_ic_prpvf capture". The v4l2-ctl tool can be used to select any


  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 15:44 Fabio Estevam
2019-10-12 20:14 ` Steve Longerbeam [this message]
2019-10-12 20:24   ` Steve Longerbeam
2019-10-12 21:19     ` Fabio Estevam
2019-10-15 15:49       ` Tim Harvey
2019-10-15 15:53         ` Fabio Estevam
2019-10-15 16:07           ` Tim Harvey
2019-10-15 16:16             ` Fabio Estevam
2019-10-15 16:33               ` Tim Harvey
2019-10-15 16:42                 ` Fabio Estevam
2019-10-15 18:19                   ` Steve Longerbeam
2019-10-15 19:11                     ` Fabio Estevam

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f7a7910-8652-7a95-1f04-e25278ec05aa@gmail.com \
    --to=slongerbeam@gmail.com \
    --cc=festevam@gmail.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=tharvey@gateworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Media Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-media/0 linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ https://lore.kernel.org/linux-media \
		linux-media@vger.kernel.org linux-media@archiver.kernel.org
	public-inbox-index linux-media

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-media


AGPL code for this site: git clone https://public-inbox.org/ public-inbox