From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>,
Jeongtae Park <jtp.park@samsung.com>,
Kamil Debski <kamil@wypas.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [media] s5p-mfc: Adjust a null pointer check in four functions
Date: Tue, 12 Sep 2017 15:21:38 +0200 [thread overview]
Message-ID: <0fa9a180-be67-3a33-682c-bff819c36c6a@samsung.com> (raw)
In-Reply-To: <a68020cc-2477-5d6c-bc61-d753253b755a@users.sourceforge.net>
On 09/11/2017 09:21 PM, SF Markus Elfring wrote:
>>> Date: Fri, 8 Sep 2017 22:37:00 +0200
>>> MIME-Version: 1.0
>>> Content-Type: text/plain; charset=UTF-8
>>> Content-Transfer-Encoding: 8bit
>>
>> Can you resend with that 4 lines removed?
>
> * Do you care to preserve an information like the author date?
In this case not, but actually the Date line is not an issue. Anyway
the patch is malformed, please try to save your posted patch and apply
with git am and see how finally the commit message looks like.
> * Would you like to support special characters in the commit message?
I can't see any need for special characters in the patch itself.
Please submit the patch in a way that it can be applied properly with
patchwork client (or git am).
>> Are you using git send-email for sending patches?
>
> Not so far.
I would suggest switching to git send-email, then issues like
above could be easily avoided.
--
Regards,
Sylwester
next prev parent reply other threads:[~2017-09-12 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 20:50 [PATCH 0/3] S5P MFC: Adjustments for five function implementations SF Markus Elfring
2017-09-08 20:51 ` [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe() SF Markus Elfring
[not found] ` <CGME20170911091439epcas1p3f8b62f55cae4255d250b1fe990fbf1ff@epcas1p3.samsung.com>
2017-09-11 9:14 ` Sylwester Nawrocki
2017-09-11 19:34 ` SF Markus Elfring
2017-09-08 20:52 ` [PATCH 2/3] [media] s5p-mfc: Improve a size determination in s5p_mfc_alloc_memdev() SF Markus Elfring
[not found] ` <CGME20170911091700epcas1p1bd85f95a6b776581ad4cd6f3108d09ba@epcas1p1.samsung.com>
2017-09-11 9:16 ` Sylwester Nawrocki
2017-09-08 20:53 ` [PATCH 3/3] [media] s5p-mfc: Adjust a null pointer check in four functions SF Markus Elfring
[not found] ` <CGME20170911092134epcas2p1a1b11c056b52d68c3b0e4ea2e1e8f758@epcas2p1.samsung.com>
2017-09-11 9:21 ` Sylwester Nawrocki
2017-09-11 19:21 ` SF Markus Elfring
2017-09-12 13:21 ` Sylwester Nawrocki [this message]
2017-09-12 15:00 ` SF Markus Elfring
2017-09-12 17:41 ` Sylwester Nawrocki
2017-09-12 20:33 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fa9a180-be67-3a33-682c-bff819c36c6a@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=a.hajda@samsung.com \
--cc=elfring@users.sourceforge.net \
--cc=jtp.park@samsung.com \
--cc=kamil@wypas.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).