From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B06894D9E2 for ; Mon, 18 Mar 2024 14:50:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710773461; cv=none; b=KVOMuZbGYkceSAD29H1ZVjLYzGdO4P2B11wiQkayQhteDbptt4k6OEeLHSMFOf1a1v/Wgi/AIsfnegD2FcH2wzZ+FQkk7XwvF+Q8QN4GQ4rokmWOKjsiS5ZnCc1LK0DjwzQLLM6kDJ6bg7YEgE7QonET+ASlcGQ5R1Wi9o00Hf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710773461; c=relaxed/simple; bh=ijgWv+hkt7MPS/3r6Fl7OChFfUER0e/KI95LrtFDwa4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ixiRRqVH3J4PriClsurDN6aZqdrtHt5+4c+YeztQ889qqrzQsnIy2ogiPiabQ9MzlC69EM3S5Hw+v6BhCmCMfB4IX6rvQEYMJA0YGnb3M8tQ0DOn0/BNiCP6WhdoZ4GOBmZwf0dtrT9Wsp+BjyILdosyjFTnwvG8ePghEhDVXF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmEK7-0004ix-UT; Mon, 18 Mar 2024 15:50:47 +0100 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rmEK6-00766i-DA; Mon, 18 Mar 2024 15:50:46 +0100 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1rmEK6-000COV-16; Mon, 18 Mar 2024 15:50:46 +0100 Message-ID: <0faf621bd00847dc8f5776504faf0b223e8ae35c.camel@pengutronix.de> Subject: Re: [PATCH 2/6] media: chips-media: wave5: support reset lines From: Philipp Zabel To: Ivan Bornyakov , Nas Chung , Jackson Lee , Mauro Carvalho Chehab Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Mon, 18 Mar 2024 15:50:46 +0100 In-Reply-To: <20240318144225.30835-3-brnkv.i1@gmail.com> References: <20240318144225.30835-1-brnkv.i1@gmail.com> <20240318144225.30835-3-brnkv.i1@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-media@vger.kernel.org Hi Ivan, On Mo, 2024-03-18 at 17:42 +0300, Ivan Bornyakov wrote: > Add initial support for optional reset lines. For now, simply deassert > resets on driver probe and assert them back on driver remove. >=20 > Signed-off-by: Ivan Bornyakov > --- > .../media/platform/chips-media/wave5/wave5-vpu.c | 13 +++++++++++++ > .../media/platform/chips-media/wave5/wave5-vpuapi.h | 1 + > 2 files changed, 14 insertions(+) >=20 > diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drive= rs/media/platform/chips-media/wave5/wave5-vpu.c > index 1b3df5b04249..f3ecadefd37a 100644 > --- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c > +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include "wave5-vpu.h" > #include "wave5-regdefine.h" > #include "wave5-vpuconfig.h" > @@ -151,6 +152,17 @@ static int wave5_vpu_probe(struct platform_device *p= dev) > dev_set_drvdata(&pdev->dev, dev); > dev->dev =3D &pdev->dev; > =20 > + dev->resets =3D devm_reset_control_array_get_optional_exclusive(&pdev->= dev); > + if (IS_ERR(dev->resets)) { > + return dev_err_probe(&pdev->dev, PTR_ERR(dev->resets), > + "Failed to get reset control\n"); > + } else { > + ret =3D reset_control_deassert(dev->resets); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, > + "Failed to deassert resets\n"); This doesn't have to be in an else block, the error path above returns. > + } > + > ret =3D devm_clk_bulk_get_all(&pdev->dev, &dev->clks); I'd expect the reset control to be asserted in the error path. regards Philipp